All of lore.kernel.org
 help / color / mirror / Atom feed
* [U-Boot] [PATCH] SPL ext: cosmetic: correct error message in spl_load_image_ext()
@ 2016-06-14  9:44 Petr Kulhavy
  2016-06-17 12:05 ` Guillaume Gardet
  2016-06-17 14:43 ` Tom Rini
  0 siblings, 2 replies; 3+ messages in thread
From: Petr Kulhavy @ 2016-06-14  9:44 UTC (permalink / raw)
  To: u-boot

Correct the error message in spl_load_image_ext() when image parsing
fails. Instead of "ext4fs_read failed" print "failed to parse image
header".

Signed-off-by: Petr Kulhavy <brain@jikos.cz>
CC: Guillaume GARDET <guillaume.gardet@free.fr>
---
 common/spl/spl_ext.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/common/spl/spl_ext.c b/common/spl/spl_ext.c
index ade5496..074b31e 100644
--- a/common/spl/spl_ext.c
+++ b/common/spl/spl_ext.c
@@ -50,7 +50,7 @@ int spl_load_image_ext(struct blk_desc *block_dev,
 
 	err = spl_parse_image_header(header);
 	if (err < 0) {
-		puts("spl: ext4fs_read failed\n");
+		puts("spl: failed to parse image header\n");
 		goto end;
 	}
 
-- 
2.5.0

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* [U-Boot] [PATCH] SPL ext: cosmetic: correct error message in spl_load_image_ext()
  2016-06-14  9:44 [U-Boot] [PATCH] SPL ext: cosmetic: correct error message in spl_load_image_ext() Petr Kulhavy
@ 2016-06-17 12:05 ` Guillaume Gardet
  2016-06-17 14:43 ` Tom Rini
  1 sibling, 0 replies; 3+ messages in thread
From: Guillaume Gardet @ 2016-06-17 12:05 UTC (permalink / raw)
  To: u-boot



Le 14/06/2016 11:44, Petr Kulhavy a ?crit :
> Correct the error message in spl_load_image_ext() when image parsing
> fails. Instead of "ext4fs_read failed" print "failed to parse image
> header".
>
> Signed-off-by: Petr Kulhavy <brain@jikos.cz>
> CC: Guillaume GARDET <guillaume.gardet@free.fr>

Acked-by:  Guillaume GARDET <guillaume.gardet@free.fr>

> ---
>   common/spl/spl_ext.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/common/spl/spl_ext.c b/common/spl/spl_ext.c
> index ade5496..074b31e 100644
> --- a/common/spl/spl_ext.c
> +++ b/common/spl/spl_ext.c
> @@ -50,7 +50,7 @@ int spl_load_image_ext(struct blk_desc *block_dev,
>   
>   	err = spl_parse_image_header(header);
>   	if (err < 0) {
> -		puts("spl: ext4fs_read failed\n");
> +		puts("spl: failed to parse image header\n");
>   		goto end;
>   	}
>   

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [U-Boot] [PATCH] SPL ext: cosmetic: correct error message in spl_load_image_ext()
  2016-06-14  9:44 [U-Boot] [PATCH] SPL ext: cosmetic: correct error message in spl_load_image_ext() Petr Kulhavy
  2016-06-17 12:05 ` Guillaume Gardet
@ 2016-06-17 14:43 ` Tom Rini
  1 sibling, 0 replies; 3+ messages in thread
From: Tom Rini @ 2016-06-17 14:43 UTC (permalink / raw)
  To: u-boot

On Tue, Jun 14, 2016 at 11:44:56AM +0200, Petr Kulhavy wrote:

> Correct the error message in spl_load_image_ext() when image parsing
> fails. Instead of "ext4fs_read failed" print "failed to parse image
> header".
> 
> Signed-off-by: Petr Kulhavy <brain@jikos.cz>
> CC: Guillaume GARDET <guillaume.gardet@free.fr>
> ---
>  common/spl/spl_ext.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/common/spl/spl_ext.c b/common/spl/spl_ext.c
> index ade5496..074b31e 100644
> --- a/common/spl/spl_ext.c
> +++ b/common/spl/spl_ext.c
> @@ -50,7 +50,7 @@ int spl_load_image_ext(struct blk_desc *block_dev,
>  
>  	err = spl_parse_image_header(header);
>  	if (err < 0) {
> -		puts("spl: ext4fs_read failed\n");
> +		puts("spl: failed to parse image header\n");

Can you please make this: "spl: ext: failed to parse image header" so
that when encountered someone knows it's in the ext path?  Thanks!

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20160617/b790fe92/attachment.sig>

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2016-06-17 14:43 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-06-14  9:44 [U-Boot] [PATCH] SPL ext: cosmetic: correct error message in spl_load_image_ext() Petr Kulhavy
2016-06-17 12:05 ` Guillaume Gardet
2016-06-17 14:43 ` Tom Rini

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.