From: Kishon Vijay Abraham I <kishon-l0cyMroinI0@public.gmane.org>
To: "Heiko Stübner" <heiko-4mtYJXux2i+zQB+pC5nmwQ@public.gmane.org>,
weiyj_lk-9Onoh4P/yGk@public.gmane.org
Cc: linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
Wei Yongjun
<yongjun_wei-zrsr2BFq86L20UzCJQGyNP8+0UxHXcjY@public.gmane.org>,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org
Subject: Re: [PATCH] phy: rockchip-dp: fix return value check in rockchip_dp_phy_probe()
Date: Fri, 17 Jun 2016 18:45:18 +0530 [thread overview]
Message-ID: <5763F7E6.9090702@ti.com> (raw)
In-Reply-To: <4354296.6MbJoqdM2Z@diego>
On Tuesday 14 June 2016 12:09 PM, Heiko Stübner wrote:
> Am Montag, 13. Juni 2016, 23:31:47 schrieb weiyj_lk-9Onoh4P/yGk@public.gmane.org:
>> From: Wei Yongjun <yongjun_wei-zrsr2BFq86L20UzCJQGyNP8+0UxHXcjY@public.gmane.org>
>>
>> In case of error, the function devm_kzalloc() returns NULL pointer
>> not ERR_PTR(). The IS_ERR() test in the return value check should
>> be replaced with NULL test.
>>
>> Signed-off-by: Wei Yongjun <yongjun_wei-zrsr2BFq86L20UzCJQGyNP8+0UxHXcjY@public.gmane.org>
>
> obviously correct, thanks for catching.
>
> Reviewed-by: Heiko Stuebner <heiko-4mtYJXux2i+zQB+pC5nmwQ@public.gmane.org>
applied, thanks.
-Kishon
WARNING: multiple messages have this Message-ID (diff)
From: kishon@ti.com (Kishon Vijay Abraham I)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] phy: rockchip-dp: fix return value check in rockchip_dp_phy_probe()
Date: Fri, 17 Jun 2016 18:45:18 +0530 [thread overview]
Message-ID: <5763F7E6.9090702@ti.com> (raw)
In-Reply-To: <4354296.6MbJoqdM2Z@diego>
On Tuesday 14 June 2016 12:09 PM, Heiko St?bner wrote:
> Am Montag, 13. Juni 2016, 23:31:47 schrieb weiyj_lk at 163.com:
>> From: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
>>
>> In case of error, the function devm_kzalloc() returns NULL pointer
>> not ERR_PTR(). The IS_ERR() test in the return value check should
>> be replaced with NULL test.
>>
>> Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
>
> obviously correct, thanks for catching.
>
> Reviewed-by: Heiko Stuebner <heiko@sntech.de>
applied, thanks.
-Kishon
WARNING: multiple messages have this Message-ID (diff)
From: Kishon Vijay Abraham I <kishon@ti.com>
To: "Heiko Stübner" <heiko@sntech.de>, weiyj_lk@163.com
Cc: Wei Yongjun <yongjun_wei@trendmicro.com.cn>,
<linux-kernel@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-rockchip@lists.infradead.org>
Subject: Re: [PATCH] phy: rockchip-dp: fix return value check in rockchip_dp_phy_probe()
Date: Fri, 17 Jun 2016 18:45:18 +0530 [thread overview]
Message-ID: <5763F7E6.9090702@ti.com> (raw)
In-Reply-To: <4354296.6MbJoqdM2Z@diego>
On Tuesday 14 June 2016 12:09 PM, Heiko Stübner wrote:
> Am Montag, 13. Juni 2016, 23:31:47 schrieb weiyj_lk@163.com:
>> From: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
>>
>> In case of error, the function devm_kzalloc() returns NULL pointer
>> not ERR_PTR(). The IS_ERR() test in the return value check should
>> be replaced with NULL test.
>>
>> Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
>
> obviously correct, thanks for catching.
>
> Reviewed-by: Heiko Stuebner <heiko@sntech.de>
applied, thanks.
-Kishon
next prev parent reply other threads:[~2016-06-17 13:15 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-13 23:31 [PATCH] phy: rockchip-dp: fix return value check in rockchip_dp_phy_probe() weiyj_lk-9Onoh4P/yGk
2016-06-13 23:31 ` weiyj_lk
2016-06-13 23:31 ` weiyj_lk at 163.com
2016-06-14 6:39 ` Heiko Stübner
2016-06-14 6:39 ` Heiko Stübner
2016-06-17 13:15 ` Kishon Vijay Abraham I [this message]
2016-06-17 13:15 ` Kishon Vijay Abraham I
2016-06-17 13:15 ` Kishon Vijay Abraham I
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5763F7E6.9090702@ti.com \
--to=kishon-l0cymroini0@public.gmane.org \
--cc=heiko-4mtYJXux2i+zQB+pC5nmwQ@public.gmane.org \
--cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=weiyj_lk-9Onoh4P/yGk@public.gmane.org \
--cc=yongjun_wei-zrsr2BFq86L20UzCJQGyNP8+0UxHXcjY@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.