All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Jernej Škrabec" <jernej.skrabec@gmail.com>
To: Paul Kocialkowski <paul.kocialkowski@bootlin.com>,
	Mauro Carvalho Chehab <mchehab@kernel.org>,
	linux-media@vger.kernel.org, Samuel Holland <samuel@sholland.org>
Cc: Rob Herring <robh+dt@kernel.org>,
	devicetree@vger.kernel.org, Maxime Ripard <mripard@kernel.org>,
	Chen-Yu Tsai <wens@csie.org>,
	linux-sunxi@lists.linux.dev, Samuel Holland <samuel@sholland.org>,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	linux-staging@lists.linux.dev
Subject: Re: [PATCH 2/2] media: cedrus: Add support for the D1 variant
Date: Fri, 19 Nov 2021 16:53:41 +0100	[thread overview]
Message-ID: <5766379.lOV4Wx5bFT@kista> (raw)
In-Reply-To: <20211119031519.23430-2-samuel@sholland.org>

Hi Samuel!

Dne petek, 19. november 2021 ob 04:15:18 CET je Samuel Holland napisal(a):
> D1 has a unique variant of the video engine, which appears to drop the
> VP8 support found on most earlier variants.
> 
> Signed-off-by: Samuel Holland <samuel@sholland.org>
> ---
> 
>  drivers/staging/media/sunxi/cedrus/cedrus.c | 12 ++++++++++++
>  1 file changed, 12 insertions(+)
> 
> diff --git a/drivers/staging/media/sunxi/cedrus/cedrus.c b/drivers/staging/
media/sunxi/cedrus/cedrus.c
> index c76fc97d97a0..4a4b714b0f26 100644
> --- a/drivers/staging/media/sunxi/cedrus/cedrus.c
> +++ b/drivers/staging/media/sunxi/cedrus/cedrus.c
> @@ -580,6 +580,14 @@ static const struct cedrus_variant 
sun8i_r40_cedrus_variant = {
>  	.mod_rate	= 297000000,
>  };
>  
> +static const struct cedrus_variant sun20i_d1_cedrus_variant = {
> +	.capabilities	= CEDRUS_CAPABILITY_UNTILED |
> +			  CEDRUS_CAPABILITY_MPEG2_DEC |
> +			  CEDRUS_CAPABILITY_H264_DEC |
> +			  CEDRUS_CAPABILITY_H265_DEC,

Did you check if VP8 really doesn't work? It would be strange because it 
shares decoding blocks with H264 and VP8 is present in (almost) all SoCs.

Best regards,
Jernej

> +	.mod_rate	= 432000000,
> +};
> +
>  static const struct cedrus_variant sun50i_a64_cedrus_variant = {
>  	.capabilities	= CEDRUS_CAPABILITY_UNTILED |
>  			  CEDRUS_CAPABILITY_MPEG2_DEC |
> @@ -637,6 +645,10 @@ static const struct of_device_id cedrus_dt_match[] = {
>  		.compatible = "allwinner,sun8i-r40-video-engine",
>  		.data = &sun8i_r40_cedrus_variant,
>  	},
> +	{
> +		.compatible = "allwinner,sun20i-d1-video-engine",
> +		.data = &sun20i_d1_cedrus_variant,
> +	},
>  	{
>  		.compatible = "allwinner,sun50i-a64-video-engine",
>  		.data = &sun50i_a64_cedrus_variant,
> -- 
> 2.32.0
> 
> 



WARNING: multiple messages have this Message-ID (diff)
From: "Jernej Škrabec" <jernej.skrabec@gmail.com>
To: Paul Kocialkowski <paul.kocialkowski@bootlin.com>,
	Mauro Carvalho Chehab <mchehab@kernel.org>,
	linux-media@vger.kernel.org, Samuel Holland <samuel@sholland.org>
Cc: Rob Herring <robh+dt@kernel.org>,
	devicetree@vger.kernel.org, Maxime Ripard <mripard@kernel.org>,
	Chen-Yu Tsai <wens@csie.org>,
	linux-sunxi@lists.linux.dev, Samuel Holland <samuel@sholland.org>,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	linux-staging@lists.linux.dev
Subject: Re: [PATCH 2/2] media: cedrus: Add support for the D1 variant
Date: Fri, 19 Nov 2021 16:53:41 +0100	[thread overview]
Message-ID: <5766379.lOV4Wx5bFT@kista> (raw)
In-Reply-To: <20211119031519.23430-2-samuel@sholland.org>

Hi Samuel!

Dne petek, 19. november 2021 ob 04:15:18 CET je Samuel Holland napisal(a):
> D1 has a unique variant of the video engine, which appears to drop the
> VP8 support found on most earlier variants.
> 
> Signed-off-by: Samuel Holland <samuel@sholland.org>
> ---
> 
>  drivers/staging/media/sunxi/cedrus/cedrus.c | 12 ++++++++++++
>  1 file changed, 12 insertions(+)
> 
> diff --git a/drivers/staging/media/sunxi/cedrus/cedrus.c b/drivers/staging/
media/sunxi/cedrus/cedrus.c
> index c76fc97d97a0..4a4b714b0f26 100644
> --- a/drivers/staging/media/sunxi/cedrus/cedrus.c
> +++ b/drivers/staging/media/sunxi/cedrus/cedrus.c
> @@ -580,6 +580,14 @@ static const struct cedrus_variant 
sun8i_r40_cedrus_variant = {
>  	.mod_rate	= 297000000,
>  };
>  
> +static const struct cedrus_variant sun20i_d1_cedrus_variant = {
> +	.capabilities	= CEDRUS_CAPABILITY_UNTILED |
> +			  CEDRUS_CAPABILITY_MPEG2_DEC |
> +			  CEDRUS_CAPABILITY_H264_DEC |
> +			  CEDRUS_CAPABILITY_H265_DEC,

Did you check if VP8 really doesn't work? It would be strange because it 
shares decoding blocks with H264 and VP8 is present in (almost) all SoCs.

Best regards,
Jernej

> +	.mod_rate	= 432000000,
> +};
> +
>  static const struct cedrus_variant sun50i_a64_cedrus_variant = {
>  	.capabilities	= CEDRUS_CAPABILITY_UNTILED |
>  			  CEDRUS_CAPABILITY_MPEG2_DEC |
> @@ -637,6 +645,10 @@ static const struct of_device_id cedrus_dt_match[] = {
>  		.compatible = "allwinner,sun8i-r40-video-engine",
>  		.data = &sun8i_r40_cedrus_variant,
>  	},
> +	{
> +		.compatible = "allwinner,sun20i-d1-video-engine",
> +		.data = &sun20i_d1_cedrus_variant,
> +	},
>  	{
>  		.compatible = "allwinner,sun50i-a64-video-engine",
>  		.data = &sun50i_a64_cedrus_variant,
> -- 
> 2.32.0
> 
> 



_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  parent reply	other threads:[~2021-11-19 15:53 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-19  3:15 [PATCH 1/2] dt-bindings: media: Add compatible for D1 Samuel Holland
2021-11-19  3:15 ` Samuel Holland
2021-11-19  3:15 ` [PATCH 2/2] media: cedrus: Add support for the D1 variant Samuel Holland
2021-11-19  3:15   ` Samuel Holland
2021-11-19  8:23   ` Maxime Ripard
2021-11-19  8:23     ` Maxime Ripard
2021-11-19 15:53   ` Jernej Škrabec [this message]
2021-11-19 15:53     ` Jernej Škrabec
2021-11-19  8:22 ` [PATCH 1/2] dt-bindings: media: Add compatible for D1 Maxime Ripard
2021-11-19  8:22   ` Maxime Ripard
2021-11-29 23:12 ` Rob Herring
2021-11-29 23:12   ` Rob Herring

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5766379.lOV4Wx5bFT@kista \
    --to=jernej.skrabec@gmail.com \
    --cc=devicetree@vger.kernel.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=linux-staging@lists.linux.dev \
    --cc=linux-sunxi@lists.linux.dev \
    --cc=mchehab@kernel.org \
    --cc=mripard@kernel.org \
    --cc=paul.kocialkowski@bootlin.com \
    --cc=robh+dt@kernel.org \
    --cc=samuel@sholland.org \
    --cc=wens@csie.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.