From: Sergey Fedorov <sergey.fedorov@linaro.org>
To: Peter Maydell <peter.maydell@linaro.org>,
qemu-arm@nongnu.org, qemu-devel@nongnu.org
Cc: patches@linaro.org
Subject: Re: [Qemu-devel] [PATCH] hw/intc/arm_gicv3: Fix compilation with simple trace backend
Date: Mon, 20 Jun 2016 13:22:26 +0300 [thread overview]
Message-ID: <5767C3E2.6010604@linaro.org> (raw)
In-Reply-To: <1466416634-9798-1-git-send-email-peter.maydell@linaro.org>
On 20/06/16 12:57, Peter Maydell wrote:
> Fix missing includes of qemu/log.h, which broke compilation with the
> simple trace backend (the default backend pulls in log.h implicitly
> via trace.h).
>
> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
Tested-by: Sergey Fedorov <sergey.fedorov@linaro.org>
Reviewed-by: Sergey Fedorov <sergey.fedorov@linaro.org>
Thanks,
Sergey
> ---
> In particular, this broke travis builds.
> ---
> hw/intc/arm_gicv3_dist.c | 1 +
> hw/intc/arm_gicv3_redist.c | 1 +
> 2 files changed, 2 insertions(+)
>
> diff --git a/hw/intc/arm_gicv3_dist.c b/hw/intc/arm_gicv3_dist.c
> index b977ae5..3ea3dd0 100644
> --- a/hw/intc/arm_gicv3_dist.c
> +++ b/hw/intc/arm_gicv3_dist.c
> @@ -10,6 +10,7 @@
> */
>
> #include "qemu/osdep.h"
> +#include "qemu/log.h"
> #include "trace.h"
> #include "gicv3_internal.h"
>
> diff --git a/hw/intc/arm_gicv3_redist.c b/hw/intc/arm_gicv3_redist.c
> index 55c25e8..2f60096 100644
> --- a/hw/intc/arm_gicv3_redist.c
> +++ b/hw/intc/arm_gicv3_redist.c
> @@ -10,6 +10,7 @@
> */
>
> #include "qemu/osdep.h"
> +#include "qemu/log.h"
> #include "trace.h"
> #include "gicv3_internal.h"
>
next prev parent reply other threads:[~2016-06-20 10:24 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-20 9:57 [Qemu-arm] [PATCH] hw/intc/arm_gicv3: Fix compilation with simple trace backend Peter Maydell
2016-06-20 9:57 ` [Qemu-devel] " Peter Maydell
2016-06-20 10:22 ` Sergey Fedorov [this message]
2016-06-20 11:53 ` [Qemu-arm] " Peter Maydell
2016-06-20 11:53 ` [Qemu-devel] " Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5767C3E2.6010604@linaro.org \
--to=sergey.fedorov@linaro.org \
--cc=patches@linaro.org \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.