* [Qemu-arm] [PATCH] hw/intc/arm_gicv3: Fix compilation with simple trace backend
@ 2016-06-20 9:57 ` Peter Maydell
0 siblings, 0 replies; 5+ messages in thread
From: Peter Maydell @ 2016-06-20 9:57 UTC (permalink / raw)
To: qemu-arm, qemu-devel; +Cc: Sergey Fedorov, patches
Fix missing includes of qemu/log.h, which broke compilation with the
simple trace backend (the default backend pulls in log.h implicitly
via trace.h).
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
---
In particular, this broke travis builds.
---
hw/intc/arm_gicv3_dist.c | 1 +
hw/intc/arm_gicv3_redist.c | 1 +
2 files changed, 2 insertions(+)
diff --git a/hw/intc/arm_gicv3_dist.c b/hw/intc/arm_gicv3_dist.c
index b977ae5..3ea3dd0 100644
--- a/hw/intc/arm_gicv3_dist.c
+++ b/hw/intc/arm_gicv3_dist.c
@@ -10,6 +10,7 @@
*/
#include "qemu/osdep.h"
+#include "qemu/log.h"
#include "trace.h"
#include "gicv3_internal.h"
diff --git a/hw/intc/arm_gicv3_redist.c b/hw/intc/arm_gicv3_redist.c
index 55c25e8..2f60096 100644
--- a/hw/intc/arm_gicv3_redist.c
+++ b/hw/intc/arm_gicv3_redist.c
@@ -10,6 +10,7 @@
*/
#include "qemu/osdep.h"
+#include "qemu/log.h"
#include "trace.h"
#include "gicv3_internal.h"
--
1.9.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [Qemu-devel] [PATCH] hw/intc/arm_gicv3: Fix compilation with simple trace backend
@ 2016-06-20 9:57 ` Peter Maydell
0 siblings, 0 replies; 5+ messages in thread
From: Peter Maydell @ 2016-06-20 9:57 UTC (permalink / raw)
To: qemu-arm, qemu-devel; +Cc: patches, Sergey Fedorov
Fix missing includes of qemu/log.h, which broke compilation with the
simple trace backend (the default backend pulls in log.h implicitly
via trace.h).
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
---
In particular, this broke travis builds.
---
hw/intc/arm_gicv3_dist.c | 1 +
hw/intc/arm_gicv3_redist.c | 1 +
2 files changed, 2 insertions(+)
diff --git a/hw/intc/arm_gicv3_dist.c b/hw/intc/arm_gicv3_dist.c
index b977ae5..3ea3dd0 100644
--- a/hw/intc/arm_gicv3_dist.c
+++ b/hw/intc/arm_gicv3_dist.c
@@ -10,6 +10,7 @@
*/
#include "qemu/osdep.h"
+#include "qemu/log.h"
#include "trace.h"
#include "gicv3_internal.h"
diff --git a/hw/intc/arm_gicv3_redist.c b/hw/intc/arm_gicv3_redist.c
index 55c25e8..2f60096 100644
--- a/hw/intc/arm_gicv3_redist.c
+++ b/hw/intc/arm_gicv3_redist.c
@@ -10,6 +10,7 @@
*/
#include "qemu/osdep.h"
+#include "qemu/log.h"
#include "trace.h"
#include "gicv3_internal.h"
--
1.9.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [Qemu-devel] [PATCH] hw/intc/arm_gicv3: Fix compilation with simple trace backend
2016-06-20 9:57 ` [Qemu-devel] " Peter Maydell
(?)
@ 2016-06-20 10:22 ` Sergey Fedorov
2016-06-20 11:53 ` [Qemu-devel] " Peter Maydell
-1 siblings, 1 reply; 5+ messages in thread
From: Sergey Fedorov @ 2016-06-20 10:22 UTC (permalink / raw)
To: Peter Maydell, qemu-arm, qemu-devel; +Cc: patches
On 20/06/16 12:57, Peter Maydell wrote:
> Fix missing includes of qemu/log.h, which broke compilation with the
> simple trace backend (the default backend pulls in log.h implicitly
> via trace.h).
>
> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
Tested-by: Sergey Fedorov <sergey.fedorov@linaro.org>
Reviewed-by: Sergey Fedorov <sergey.fedorov@linaro.org>
Thanks,
Sergey
> ---
> In particular, this broke travis builds.
> ---
> hw/intc/arm_gicv3_dist.c | 1 +
> hw/intc/arm_gicv3_redist.c | 1 +
> 2 files changed, 2 insertions(+)
>
> diff --git a/hw/intc/arm_gicv3_dist.c b/hw/intc/arm_gicv3_dist.c
> index b977ae5..3ea3dd0 100644
> --- a/hw/intc/arm_gicv3_dist.c
> +++ b/hw/intc/arm_gicv3_dist.c
> @@ -10,6 +10,7 @@
> */
>
> #include "qemu/osdep.h"
> +#include "qemu/log.h"
> #include "trace.h"
> #include "gicv3_internal.h"
>
> diff --git a/hw/intc/arm_gicv3_redist.c b/hw/intc/arm_gicv3_redist.c
> index 55c25e8..2f60096 100644
> --- a/hw/intc/arm_gicv3_redist.c
> +++ b/hw/intc/arm_gicv3_redist.c
> @@ -10,6 +10,7 @@
> */
>
> #include "qemu/osdep.h"
> +#include "qemu/log.h"
> #include "trace.h"
> #include "gicv3_internal.h"
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Qemu-arm] [PATCH] hw/intc/arm_gicv3: Fix compilation with simple trace backend
2016-06-20 10:22 ` Sergey Fedorov
@ 2016-06-20 11:53 ` Peter Maydell
0 siblings, 0 replies; 5+ messages in thread
From: Peter Maydell @ 2016-06-20 11:53 UTC (permalink / raw)
To: Sergey Fedorov; +Cc: qemu-arm, QEMU Developers, Patch Tracking
On 20 June 2016 at 11:22, Sergey Fedorov <sergey.fedorov@linaro.org> wrote:
> On 20/06/16 12:57, Peter Maydell wrote:
>> Fix missing includes of qemu/log.h, which broke compilation with the
>> simple trace backend (the default backend pulls in log.h implicitly
>> via trace.h).
>>
>> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
>
> Tested-by: Sergey Fedorov <sergey.fedorov@linaro.org>
> Reviewed-by: Sergey Fedorov <sergey.fedorov@linaro.org>
Thanks. Applied to master as a build fix.
-- PMM
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Qemu-devel] [PATCH] hw/intc/arm_gicv3: Fix compilation with simple trace backend
@ 2016-06-20 11:53 ` Peter Maydell
0 siblings, 0 replies; 5+ messages in thread
From: Peter Maydell @ 2016-06-20 11:53 UTC (permalink / raw)
To: Sergey Fedorov; +Cc: qemu-arm, QEMU Developers, Patch Tracking
On 20 June 2016 at 11:22, Sergey Fedorov <sergey.fedorov@linaro.org> wrote:
> On 20/06/16 12:57, Peter Maydell wrote:
>> Fix missing includes of qemu/log.h, which broke compilation with the
>> simple trace backend (the default backend pulls in log.h implicitly
>> via trace.h).
>>
>> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
>
> Tested-by: Sergey Fedorov <sergey.fedorov@linaro.org>
> Reviewed-by: Sergey Fedorov <sergey.fedorov@linaro.org>
Thanks. Applied to master as a build fix.
-- PMM
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2016-06-20 11:53 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-06-20 9:57 [Qemu-arm] [PATCH] hw/intc/arm_gicv3: Fix compilation with simple trace backend Peter Maydell
2016-06-20 9:57 ` [Qemu-devel] " Peter Maydell
2016-06-20 10:22 ` Sergey Fedorov
2016-06-20 11:53 ` [Qemu-arm] " Peter Maydell
2016-06-20 11:53 ` [Qemu-devel] " Peter Maydell
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.