From: Hans Verkuil <hverkuil@xs4all.nl>
To: Sakari Ailus <sakari.ailus@linux.intel.com>, linux-media@vger.kernel.org
Cc: g.liakhovetski@gmx.de, Jouni Ukkonen <jouni.ukkonen@intel.com>
Subject: Re: [PATCH 4/6] media: Add 1X14 14-bit raw bayer media bus code definitions
Date: Mon, 20 Jun 2016 17:23:21 +0200 [thread overview]
Message-ID: <57680A69.4040705@xs4all.nl> (raw)
In-Reply-To: <1464353080-18300-5-git-send-email-sakari.ailus@linux.intel.com>
On 05/27/2016 02:44 PM, Sakari Ailus wrote:
> From: Jouni Ukkonen <jouni.ukkonen@intel.com>
>
> The codes will be called:
>
> MEDIA_BUS_FMT_SBGGR14_1X14
> MEDIA_BUS_FMT_SGBRG14_1X14
> MEDIA_BUS_FMT_SGRBG14_1X14
> MEDIA_BUS_FMT_SRGGB14_1X14
>
> Signed-off-by: Jouni Ukkonen <jouni.ukkonen@intel.com>
> Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
Acked-by: Hans Verkuil <hans.verkuil@cisco.com>
Hans
> ---
> Documentation/DocBook/media/v4l/subdev-formats.xml | 162 +++++++++++++++++++--
> include/uapi/linux/media-bus-format.h | 6 +-
> 2 files changed, 154 insertions(+), 14 deletions(-)
>
> diff --git a/Documentation/DocBook/media/v4l/subdev-formats.xml b/Documentation/DocBook/media/v4l/subdev-formats.xml
> index 199c84e..6d45dc8 100644
> --- a/Documentation/DocBook/media/v4l/subdev-formats.xml
> +++ b/Documentation/DocBook/media/v4l/subdev-formats.xml
> @@ -1098,22 +1098,24 @@ see <xref linkend="colorspaces" />.</entry>
>
> <table pgwide="0" frame="none" id="v4l2-mbus-pixelcode-bayer">
> <title>Bayer Formats</title>
> - <tgroup cols="15">
> + <tgroup cols="17">
> <colspec colname="id" align="left" />
> <colspec colname="code" align="center"/>
> <colspec colname="bit" />
> - <colspec colnum="4" colname="b11" align="center" />
> - <colspec colnum="5" colname="b10" align="center" />
> - <colspec colnum="6" colname="b09" align="center" />
> - <colspec colnum="7" colname="b08" align="center" />
> - <colspec colnum="8" colname="b07" align="center" />
> - <colspec colnum="9" colname="b06" align="center" />
> - <colspec colnum="10" colname="b05" align="center" />
> - <colspec colnum="11" colname="b04" align="center" />
> - <colspec colnum="12" colname="b03" align="center" />
> - <colspec colnum="13" colname="b02" align="center" />
> - <colspec colnum="14" colname="b01" align="center" />
> - <colspec colnum="15" colname="b00" align="center" />
> + <colspec colnum="4" colname="b13" align="center" />
> + <colspec colnum="5" colname="b12" align="center" />
> + <colspec colnum="6" colname="b11" align="center" />
> + <colspec colnum="7" colname="b10" align="center" />
> + <colspec colnum="8" colname="b09" align="center" />
> + <colspec colnum="9" colname="b08" align="center" />
> + <colspec colnum="10" colname="b07" align="center" />
> + <colspec colnum="11" colname="b06" align="center" />
> + <colspec colnum="12" colname="b05" align="center" />
> + <colspec colnum="13" colname="b04" align="center" />
> + <colspec colnum="14" colname="b03" align="center" />
> + <colspec colnum="15" colname="b02" align="center" />
> + <colspec colnum="16" colname="b01" align="center" />
> + <colspec colnum="17" colname="b00" align="center" />
> <spanspec namest="b11" nameend="b00" spanname="b0" />
> <thead>
> <row>
> @@ -1126,6 +1128,8 @@ see <xref linkend="colorspaces" />.</entry>
> <entry></entry>
> <entry></entry>
> <entry>Bit</entry>
> + <entry>13</entry>
> + <entry>12</entry>
> <entry>11</entry>
> <entry>10</entry>
> <entry>9</entry>
> @@ -1149,6 +1153,8 @@ see <xref linkend="colorspaces" />.</entry>
> <entry>-</entry>
> <entry>-</entry>
> <entry>-</entry>
> + <entry>-</entry>
> + <entry>-</entry>
> <entry>b<subscript>7</subscript></entry>
> <entry>b<subscript>6</subscript></entry>
> <entry>b<subscript>5</subscript></entry>
> @@ -1166,6 +1172,8 @@ see <xref linkend="colorspaces" />.</entry>
> <entry>-</entry>
> <entry>-</entry>
> <entry>-</entry>
> + <entry>-</entry>
> + <entry>-</entry>
> <entry>g<subscript>7</subscript></entry>
> <entry>g<subscript>6</subscript></entry>
> <entry>g<subscript>5</subscript></entry>
> @@ -1183,6 +1191,8 @@ see <xref linkend="colorspaces" />.</entry>
> <entry>-</entry>
> <entry>-</entry>
> <entry>-</entry>
> + <entry>-</entry>
> + <entry>-</entry>
> <entry>g<subscript>7</subscript></entry>
> <entry>g<subscript>6</subscript></entry>
> <entry>g<subscript>5</subscript></entry>
> @@ -1200,6 +1210,8 @@ see <xref linkend="colorspaces" />.</entry>
> <entry>-</entry>
> <entry>-</entry>
> <entry>-</entry>
> + <entry>-</entry>
> + <entry>-</entry>
> <entry>r<subscript>7</subscript></entry>
> <entry>r<subscript>6</subscript></entry>
> <entry>r<subscript>5</subscript></entry>
> @@ -1217,6 +1229,8 @@ see <xref linkend="colorspaces" />.</entry>
> <entry>-</entry>
> <entry>-</entry>
> <entry>-</entry>
> + <entry>-</entry>
> + <entry>-</entry>
> <entry>b<subscript>7</subscript></entry>
> <entry>b<subscript>6</subscript></entry>
> <entry>b<subscript>5</subscript></entry>
> @@ -1234,6 +1248,8 @@ see <xref linkend="colorspaces" />.</entry>
> <entry>-</entry>
> <entry>-</entry>
> <entry>-</entry>
> + <entry>-</entry>
> + <entry>-</entry>
> <entry>g<subscript>7</subscript></entry>
> <entry>g<subscript>6</subscript></entry>
> <entry>g<subscript>5</subscript></entry>
> @@ -1251,6 +1267,8 @@ see <xref linkend="colorspaces" />.</entry>
> <entry>-</entry>
> <entry>-</entry>
> <entry>-</entry>
> + <entry>-</entry>
> + <entry>-</entry>
> <entry>g<subscript>7</subscript></entry>
> <entry>g<subscript>6</subscript></entry>
> <entry>g<subscript>5</subscript></entry>
> @@ -1268,6 +1286,8 @@ see <xref linkend="colorspaces" />.</entry>
> <entry>-</entry>
> <entry>-</entry>
> <entry>-</entry>
> + <entry>-</entry>
> + <entry>-</entry>
> <entry>r<subscript>7</subscript></entry>
> <entry>r<subscript>6</subscript></entry>
> <entry>r<subscript>5</subscript></entry>
> @@ -1285,6 +1305,8 @@ see <xref linkend="colorspaces" />.</entry>
> <entry>-</entry>
> <entry>-</entry>
> <entry>-</entry>
> + <entry>-</entry>
> + <entry>-</entry>
> <entry>b<subscript>7</subscript></entry>
> <entry>b<subscript>6</subscript></entry>
> <entry>b<subscript>5</subscript></entry>
> @@ -1302,6 +1324,8 @@ see <xref linkend="colorspaces" />.</entry>
> <entry>-</entry>
> <entry>-</entry>
> <entry>-</entry>
> + <entry>-</entry>
> + <entry>-</entry>
> <entry>g<subscript>7</subscript></entry>
> <entry>g<subscript>6</subscript></entry>
> <entry>g<subscript>5</subscript></entry>
> @@ -1319,6 +1343,8 @@ see <xref linkend="colorspaces" />.</entry>
> <entry>-</entry>
> <entry>-</entry>
> <entry>-</entry>
> + <entry>-</entry>
> + <entry>-</entry>
> <entry>g<subscript>7</subscript></entry>
> <entry>g<subscript>6</subscript></entry>
> <entry>g<subscript>5</subscript></entry>
> @@ -1336,6 +1362,8 @@ see <xref linkend="colorspaces" />.</entry>
> <entry>-</entry>
> <entry>-</entry>
> <entry>-</entry>
> + <entry>-</entry>
> + <entry>-</entry>
> <entry>r<subscript>7</subscript></entry>
> <entry>r<subscript>6</subscript></entry>
> <entry>r<subscript>5</subscript></entry>
> @@ -1353,6 +1381,8 @@ see <xref linkend="colorspaces" />.</entry>
> <entry>-</entry>
> <entry>-</entry>
> <entry>-</entry>
> + <entry>-</entry>
> + <entry>-</entry>
> <entry>0</entry>
> <entry>0</entry>
> <entry>0</entry>
> @@ -1370,6 +1400,8 @@ see <xref linkend="colorspaces" />.</entry>
> <entry>-</entry>
> <entry>-</entry>
> <entry>-</entry>
> + <entry>-</entry>
> + <entry>-</entry>
> <entry>b<subscript>7</subscript></entry>
> <entry>b<subscript>6</subscript></entry>
> <entry>b<subscript>5</subscript></entry>
> @@ -1387,6 +1419,8 @@ see <xref linkend="colorspaces" />.</entry>
> <entry>-</entry>
> <entry>-</entry>
> <entry>-</entry>
> + <entry>-</entry>
> + <entry>-</entry>
> <entry>b<subscript>7</subscript></entry>
> <entry>b<subscript>6</subscript></entry>
> <entry>b<subscript>5</subscript></entry>
> @@ -1404,6 +1438,8 @@ see <xref linkend="colorspaces" />.</entry>
> <entry>-</entry>
> <entry>-</entry>
> <entry>-</entry>
> + <entry>-</entry>
> + <entry>-</entry>
> <entry>0</entry>
> <entry>0</entry>
> <entry>0</entry>
> @@ -1421,6 +1457,8 @@ see <xref linkend="colorspaces" />.</entry>
> <entry>-</entry>
> <entry>-</entry>
> <entry>-</entry>
> + <entry>-</entry>
> + <entry>-</entry>
> <entry>b<subscript>9</subscript></entry>
> <entry>b<subscript>8</subscript></entry>
> <entry>b<subscript>7</subscript></entry>
> @@ -1438,6 +1476,8 @@ see <xref linkend="colorspaces" />.</entry>
> <entry>-</entry>
> <entry>-</entry>
> <entry>-</entry>
> + <entry>-</entry>
> + <entry>-</entry>
> <entry>b<subscript>1</subscript></entry>
> <entry>b<subscript>0</subscript></entry>
> <entry>0</entry>
> @@ -1455,6 +1495,8 @@ see <xref linkend="colorspaces" />.</entry>
> <entry>-</entry>
> <entry>-</entry>
> <entry>-</entry>
> + <entry>-</entry>
> + <entry>-</entry>
> <entry>b<subscript>1</subscript></entry>
> <entry>b<subscript>0</subscript></entry>
> <entry>0</entry>
> @@ -1472,6 +1514,8 @@ see <xref linkend="colorspaces" />.</entry>
> <entry>-</entry>
> <entry>-</entry>
> <entry>-</entry>
> + <entry>-</entry>
> + <entry>-</entry>
> <entry>b<subscript>9</subscript></entry>
> <entry>b<subscript>8</subscript></entry>
> <entry>b<subscript>7</subscript></entry>
> @@ -1487,6 +1531,8 @@ see <xref linkend="colorspaces" />.</entry>
> <entry></entry>
> <entry>-</entry>
> <entry>-</entry>
> + <entry>-</entry>
> + <entry>-</entry>
> <entry>b<subscript>9</subscript></entry>
> <entry>b<subscript>8</subscript></entry>
> <entry>b<subscript>7</subscript></entry>
> @@ -1504,6 +1550,8 @@ see <xref linkend="colorspaces" />.</entry>
> <entry></entry>
> <entry>-</entry>
> <entry>-</entry>
> + <entry>-</entry>
> + <entry>-</entry>
> <entry>g<subscript>9</subscript></entry>
> <entry>g<subscript>8</subscript></entry>
> <entry>g<subscript>7</subscript></entry>
> @@ -1521,6 +1569,8 @@ see <xref linkend="colorspaces" />.</entry>
> <entry></entry>
> <entry>-</entry>
> <entry>-</entry>
> + <entry>-</entry>
> + <entry>-</entry>
> <entry>g<subscript>9</subscript></entry>
> <entry>g<subscript>8</subscript></entry>
> <entry>g<subscript>7</subscript></entry>
> @@ -1538,6 +1588,8 @@ see <xref linkend="colorspaces" />.</entry>
> <entry></entry>
> <entry>-</entry>
> <entry>-</entry>
> + <entry>-</entry>
> + <entry>-</entry>
> <entry>r<subscript>9</subscript></entry>
> <entry>r<subscript>8</subscript></entry>
> <entry>r<subscript>7</subscript></entry>
> @@ -1553,6 +1605,8 @@ see <xref linkend="colorspaces" />.</entry>
> <entry>MEDIA_BUS_FMT_SBGGR12_1X12</entry>
> <entry>0x3008</entry>
> <entry></entry>
> + <entry>-</entry>
> + <entry>-</entry>
> <entry>b<subscript>11</subscript></entry>
> <entry>b<subscript>10</subscript></entry>
> <entry>b<subscript>9</subscript></entry>
> @@ -1570,6 +1624,8 @@ see <xref linkend="colorspaces" />.</entry>
> <entry>MEDIA_BUS_FMT_SGBRG12_1X12</entry>
> <entry>0x3010</entry>
> <entry></entry>
> + <entry>-</entry>
> + <entry>-</entry>
> <entry>g<subscript>11</subscript></entry>
> <entry>g<subscript>10</subscript></entry>
> <entry>g<subscript>9</subscript></entry>
> @@ -1587,6 +1643,8 @@ see <xref linkend="colorspaces" />.</entry>
> <entry>MEDIA_BUS_FMT_SGRBG12_1X12</entry>
> <entry>0x3011</entry>
> <entry></entry>
> + <entry>-</entry>
> + <entry>-</entry>
> <entry>g<subscript>11</subscript></entry>
> <entry>g<subscript>10</subscript></entry>
> <entry>g<subscript>9</subscript></entry>
> @@ -1604,6 +1662,84 @@ see <xref linkend="colorspaces" />.</entry>
> <entry>MEDIA_BUS_FMT_SRGGB12_1X12</entry>
> <entry>0x3012</entry>
> <entry></entry>
> + <entry>-</entry>
> + <entry>-</entry>
> + <entry>r<subscript>11</subscript></entry>
> + <entry>r<subscript>10</subscript></entry>
> + <entry>r<subscript>9</subscript></entry>
> + <entry>r<subscript>8</subscript></entry>
> + <entry>r<subscript>7</subscript></entry>
> + <entry>r<subscript>6</subscript></entry>
> + <entry>r<subscript>5</subscript></entry>
> + <entry>r<subscript>4</subscript></entry>
> + <entry>r<subscript>3</subscript></entry>
> + <entry>r<subscript>2</subscript></entry>
> + <entry>r<subscript>1</subscript></entry>
> + <entry>r<subscript>0</subscript></entry>
> + </row>
> + <row id="MEDIA-BUS-FMT-SBGGR14-1X14">
> + <entry>MEDIA_BUS_FMT_SBGGR14_1X14</entry>
> + <entry>0x3019</entry>
> + <entry></entry>
> + <entry>b<subscript>13</subscript></entry>
> + <entry>b<subscript>12</subscript></entry>
> + <entry>b<subscript>11</subscript></entry>
> + <entry>b<subscript>10</subscript></entry>
> + <entry>b<subscript>9</subscript></entry>
> + <entry>b<subscript>8</subscript></entry>
> + <entry>b<subscript>7</subscript></entry>
> + <entry>b<subscript>6</subscript></entry>
> + <entry>b<subscript>5</subscript></entry>
> + <entry>b<subscript>4</subscript></entry>
> + <entry>b<subscript>3</subscript></entry>
> + <entry>b<subscript>2</subscript></entry>
> + <entry>b<subscript>1</subscript></entry>
> + <entry>b<subscript>0</subscript></entry>
> + </row>
> + <row id="MEDIA-BUS-FMT-SGBRG14-1X14">
> + <entry>MEDIA_BUS_FMT_SGBRG14_1X14</entry>
> + <entry>0x301a</entry>
> + <entry></entry>
> + <entry>g<subscript>13</subscript></entry>
> + <entry>g<subscript>12</subscript></entry>
> + <entry>g<subscript>11</subscript></entry>
> + <entry>g<subscript>10</subscript></entry>
> + <entry>g<subscript>9</subscript></entry>
> + <entry>g<subscript>8</subscript></entry>
> + <entry>g<subscript>7</subscript></entry>
> + <entry>g<subscript>6</subscript></entry>
> + <entry>g<subscript>5</subscript></entry>
> + <entry>g<subscript>4</subscript></entry>
> + <entry>g<subscript>3</subscript></entry>
> + <entry>g<subscript>2</subscript></entry>
> + <entry>g<subscript>1</subscript></entry>
> + <entry>g<subscript>0</subscript></entry>
> + </row>
> + <row id="MEDIA-BUS-FMT-SGRBG14-1X14">
> + <entry>MEDIA_BUS_FMT_SGRBG14_1X14</entry>
> + <entry>0x301b</entry>
> + <entry></entry>
> + <entry>g<subscript>13</subscript></entry>
> + <entry>g<subscript>12</subscript></entry>
> + <entry>g<subscript>11</subscript></entry>
> + <entry>g<subscript>10</subscript></entry>
> + <entry>g<subscript>9</subscript></entry>
> + <entry>g<subscript>8</subscript></entry>
> + <entry>g<subscript>7</subscript></entry>
> + <entry>g<subscript>6</subscript></entry>
> + <entry>g<subscript>5</subscript></entry>
> + <entry>g<subscript>4</subscript></entry>
> + <entry>g<subscript>3</subscript></entry>
> + <entry>g<subscript>2</subscript></entry>
> + <entry>g<subscript>1</subscript></entry>
> + <entry>g<subscript>0</subscript></entry>
> + </row>
> + <row id="MEDIA-BUS-FMT-SRGGB14-1X14">
> + <entry>MEDIA_BUS_FMT_SRGGB14_1X14</entry>
> + <entry>0x301c</entry>
> + <entry></entry>
> + <entry>r<subscript>13</subscript></entry>
> + <entry>r<subscript>12</subscript></entry>
> <entry>r<subscript>11</subscript></entry>
> <entry>r<subscript>10</subscript></entry>
> <entry>r<subscript>9</subscript></entry>
> diff --git a/include/uapi/linux/media-bus-format.h b/include/uapi/linux/media-bus-format.h
> index 190d491..1dff459 100644
> --- a/include/uapi/linux/media-bus-format.h
> +++ b/include/uapi/linux/media-bus-format.h
> @@ -97,7 +97,7 @@
> #define MEDIA_BUS_FMT_YUV10_1X30 0x2016
> #define MEDIA_BUS_FMT_AYUV8_1X32 0x2017
>
> -/* Bayer - next is 0x3019 */
> +/* Bayer - next is 0x301d */
> #define MEDIA_BUS_FMT_SBGGR8_1X8 0x3001
> #define MEDIA_BUS_FMT_SGBRG8_1X8 0x3013
> #define MEDIA_BUS_FMT_SGRBG8_1X8 0x3002
> @@ -122,6 +122,10 @@
> #define MEDIA_BUS_FMT_SGBRG12_1X12 0x3010
> #define MEDIA_BUS_FMT_SGRBG12_1X12 0x3011
> #define MEDIA_BUS_FMT_SRGGB12_1X12 0x3012
> +#define MEDIA_BUS_FMT_SBGGR14_1X14 0x3019
> +#define MEDIA_BUS_FMT_SGBRG14_1X14 0x301a
> +#define MEDIA_BUS_FMT_SGRBG14_1X14 0x301b
> +#define MEDIA_BUS_FMT_SRGGB14_1X14 0x301c
>
> /* JPEG compressed formats - next is 0x4002 */
> #define MEDIA_BUS_FMT_JPEG_1X8 0x4001
>
next prev parent reply other threads:[~2016-06-20 15:25 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-27 12:44 [PATCH 0/6] New raw bayer format definitions, fixes Sakari Ailus
2016-05-27 12:44 ` [PATCH 1/6] v4l: Correct the ordering of LSBs of the 10-bit raw packed formats Sakari Ailus
2016-06-20 15:12 ` Hans Verkuil
2016-06-20 15:34 ` Sakari Ailus
2016-05-27 12:44 ` [PATCH 2/6] v4l: Fix number of zeroed high order bits in 12-bit raw format defs Sakari Ailus
2016-06-20 15:13 ` Hans Verkuil
2016-05-27 12:44 ` [PATCH 3/6] v4l: Add packed Bayer raw12 pixel formats Sakari Ailus
2016-06-20 15:21 ` Hans Verkuil
2016-06-20 15:37 ` Sakari Ailus
2016-05-27 12:44 ` [PATCH 4/6] media: Add 1X14 14-bit raw bayer media bus code definitions Sakari Ailus
2016-06-20 15:23 ` Hans Verkuil [this message]
2016-05-27 12:44 ` [PATCH 5/6] v4l: Add 14-bit raw bayer pixel format definitions Sakari Ailus
2016-06-20 15:24 ` Hans Verkuil
2016-06-20 16:03 ` Sakari Ailus
2016-06-20 16:05 ` Hans Verkuil
2016-05-27 12:44 ` [PATCH 6/6] v4l: Add packed Bayer raw14 pixel formats Sakari Ailus
2016-06-20 15:29 ` Hans Verkuil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=57680A69.4040705@xs4all.nl \
--to=hverkuil@xs4all.nl \
--cc=g.liakhovetski@gmx.de \
--cc=jouni.ukkonen@intel.com \
--cc=linux-media@vger.kernel.org \
--cc=sakari.ailus@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.