From: Stephen Warren <swarren@wwwdotorg.org>
To: Thierry Reding <thierry.reding@gmail.com>
Cc: Mark Rutland <mark.rutland@arm.com>,
devicetree@vger.kernel.org, Alexandre Courbot <gnurou@gmail.com>,
Marcel Ziswiler <marcel.ziswiler@toradex.com>,
linux-kernel@vger.kernel.org,
Russell King <linux@armlinux.org.uk>,
Rob Herring <robh+dt@kernel.org>,
linux-tegra@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2] arm: tegra124: remove commas from unit addresses
Date: Mon, 20 Jun 2016 10:45:55 -0600 [thread overview]
Message-ID: <57681DC3.9090801@wwwdotorg.org> (raw)
In-Reply-To: <20160620164057.GD6175@ulmo.ba.sec>
On 06/20/2016 10:40 AM, Thierry Reding wrote:
> On Mon, Jun 20, 2016 at 09:50:26AM -0600, Stephen Warren wrote:
>> On 06/18/2016 07:04 PM, Marcel Ziswiler wrote:
>>> Remove commas from unit addresses as suggested by Rob Herring upon me
>>> posting initial Apalis TK1 support:
>>>
>>> http://article.gmane.org/gmane.linux.ports.tegra/26608
>>
>> Acked-by: Stephen Warren <swarren@nvidia.com>
>
> I'm confused now. I posted almost exactly the same patch a while ago and
> we agreed that we couldn't do this because the node names were to be
> considered part of the ABI.
>
> Is it or is it not?
The particular case where it matters is the GPU node, which U-Boot
manipulates. This revised patch version no longer renames the GPU node
and so in practice avoids any issues that I'm aware of.
If there's a more general rule that node names are part of the ABI, then
indeed we shouldn't take this patch.
WARNING: multiple messages have this Message-ID (diff)
From: swarren@wwwdotorg.org (Stephen Warren)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2] arm: tegra124: remove commas from unit addresses
Date: Mon, 20 Jun 2016 10:45:55 -0600 [thread overview]
Message-ID: <57681DC3.9090801@wwwdotorg.org> (raw)
In-Reply-To: <20160620164057.GD6175@ulmo.ba.sec>
On 06/20/2016 10:40 AM, Thierry Reding wrote:
> On Mon, Jun 20, 2016 at 09:50:26AM -0600, Stephen Warren wrote:
>> On 06/18/2016 07:04 PM, Marcel Ziswiler wrote:
>>> Remove commas from unit addresses as suggested by Rob Herring upon me
>>> posting initial Apalis TK1 support:
>>>
>>> http://article.gmane.org/gmane.linux.ports.tegra/26608
>>
>> Acked-by: Stephen Warren <swarren@nvidia.com>
>
> I'm confused now. I posted almost exactly the same patch a while ago and
> we agreed that we couldn't do this because the node names were to be
> considered part of the ABI.
>
> Is it or is it not?
The particular case where it matters is the GPU node, which U-Boot
manipulates. This revised patch version no longer renames the GPU node
and so in practice avoids any issues that I'm aware of.
If there's a more general rule that node names are part of the ABI, then
indeed we shouldn't take this patch.
WARNING: multiple messages have this Message-ID (diff)
From: Stephen Warren <swarren@wwwdotorg.org>
To: Thierry Reding <thierry.reding@gmail.com>
Cc: Marcel Ziswiler <marcel.ziswiler@toradex.com>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
Rob Herring <robh+dt@kernel.org>,
linux-tegra@vger.kernel.org, Mark Rutland <mark.rutland@arm.com>,
Alexandre Courbot <gnurou@gmail.com>,
Russell King <linux@armlinux.org.uk>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2] arm: tegra124: remove commas from unit addresses
Date: Mon, 20 Jun 2016 10:45:55 -0600 [thread overview]
Message-ID: <57681DC3.9090801@wwwdotorg.org> (raw)
In-Reply-To: <20160620164057.GD6175@ulmo.ba.sec>
On 06/20/2016 10:40 AM, Thierry Reding wrote:
> On Mon, Jun 20, 2016 at 09:50:26AM -0600, Stephen Warren wrote:
>> On 06/18/2016 07:04 PM, Marcel Ziswiler wrote:
>>> Remove commas from unit addresses as suggested by Rob Herring upon me
>>> posting initial Apalis TK1 support:
>>>
>>> http://article.gmane.org/gmane.linux.ports.tegra/26608
>>
>> Acked-by: Stephen Warren <swarren@nvidia.com>
>
> I'm confused now. I posted almost exactly the same patch a while ago and
> we agreed that we couldn't do this because the node names were to be
> considered part of the ABI.
>
> Is it or is it not?
The particular case where it matters is the GPU node, which U-Boot
manipulates. This revised patch version no longer renames the GPU node
and so in practice avoids any issues that I'm aware of.
If there's a more general rule that node names are part of the ABI, then
indeed we shouldn't take this patch.
next prev parent reply other threads:[~2016-06-20 16:45 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-19 1:04 [PATCH v2] arm: tegra124: remove commas from unit addresses Marcel Ziswiler
2016-06-19 1:04 ` Marcel Ziswiler
2016-06-19 1:04 ` Marcel Ziswiler
2016-06-20 15:50 ` Stephen Warren
2016-06-20 15:50 ` Stephen Warren
2016-06-20 15:50 ` Stephen Warren
2016-06-20 16:40 ` Thierry Reding
2016-06-20 16:40 ` Thierry Reding
2016-06-20 16:45 ` Stephen Warren [this message]
2016-06-20 16:45 ` Stephen Warren
2016-06-20 16:45 ` Stephen Warren
2016-06-20 17:11 ` Thierry Reding
2016-06-20 17:11 ` Thierry Reding
2016-06-20 17:11 ` Thierry Reding
2016-06-21 7:56 ` Marcel Ziswiler
2016-06-21 7:56 ` Marcel Ziswiler
2016-06-21 7:56 ` Marcel Ziswiler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=57681DC3.9090801@wwwdotorg.org \
--to=swarren@wwwdotorg.org \
--cc=devicetree@vger.kernel.org \
--cc=gnurou@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=marcel.ziswiler@toradex.com \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.