* [Qemu-devel] [PATCH] linux-user, trivial: display "0x%x" instead of "0x%d"
@ 2016-06-20 9:51 ` Laurent Vivier
0 siblings, 0 replies; 10+ messages in thread
From: Laurent Vivier @ 2016-06-20 9:51 UTC (permalink / raw)
To: Riku Voipio; +Cc: qemu-devel, qemu-trivial, Laurent Vivier
Display an exception number, generally defined as an hexadecimal
number (for instance, EXCP_HLT is 0x10001).
Signed-off-by: Laurent Vivier <laurent@vivier.eu>
---
Resent to fix qemu-trivial email address.
linux-user/main.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/linux-user/main.c b/linux-user/main.c
index b9a4e0e..c79f5cb 100644
--- a/linux-user/main.c
+++ b/linux-user/main.c
@@ -2036,7 +2036,7 @@ void cpu_loop(CPUPPCState *env)
/* just indicate that signals should be handled asap */
break;
default:
- cpu_abort(cs, "Unknown exception 0x%d. Aborting\n", trapnr);
+ cpu_abort(cs, "Unknown exception 0x%x. Aborting\n", trapnr);
break;
}
process_pending_signals(env);
--
2.5.5
^ permalink raw reply related [flat|nested] 10+ messages in thread* Re: [Qemu-trivial] [Qemu-devel] [PATCH] linux-user, trivial: display "0x%x" instead of "0x%d"
2016-06-20 9:51 ` [Qemu-devel] " Laurent Vivier
@ 2016-06-20 16:49 ` Eric Blake
-1 siblings, 0 replies; 10+ messages in thread
From: Eric Blake @ 2016-06-20 16:49 UTC (permalink / raw)
To: Laurent Vivier, Riku Voipio; +Cc: qemu-trivial, qemu-devel
[-- Attachment #1.1: Type: text/plain, Size: 1237 bytes --]
On 06/20/2016 03:51 AM, Laurent Vivier wrote:
> Display an exception number, generally defined as an hexadecimal
> number (for instance, EXCP_HLT is 0x10001).
>
> Signed-off-by: Laurent Vivier <laurent@vivier.eu>
> ---
> Resent to fix qemu-trivial email address.
>
> linux-user/main.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
Reviewed-by: Eric Blake <eblake@redhat.com>
Can you also fix the occurrence of 0x%d in trace-events, for
mhp_pc_dimm_assigned_slot()? (Or whatever file it lands in after the
trace-events split pull request)
> diff --git a/linux-user/main.c b/linux-user/main.c
> index b9a4e0e..c79f5cb 100644
> --- a/linux-user/main.c
> +++ b/linux-user/main.c
> @@ -2036,7 +2036,7 @@ void cpu_loop(CPUPPCState *env)
> /* just indicate that signals should be handled asap */
> break;
> default:
> - cpu_abort(cs, "Unknown exception 0x%d. Aborting\n", trapnr);
> + cpu_abort(cs, "Unknown exception 0x%x. Aborting\n", trapnr);
> break;
> }
> process_pending_signals(env);
>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [Qemu-devel] [PATCH] linux-user, trivial: display "0x%x" instead of "0x%d"
@ 2016-06-20 16:49 ` Eric Blake
0 siblings, 0 replies; 10+ messages in thread
From: Eric Blake @ 2016-06-20 16:49 UTC (permalink / raw)
To: Laurent Vivier, Riku Voipio; +Cc: qemu-trivial, qemu-devel
[-- Attachment #1: Type: text/plain, Size: 1237 bytes --]
On 06/20/2016 03:51 AM, Laurent Vivier wrote:
> Display an exception number, generally defined as an hexadecimal
> number (for instance, EXCP_HLT is 0x10001).
>
> Signed-off-by: Laurent Vivier <laurent@vivier.eu>
> ---
> Resent to fix qemu-trivial email address.
>
> linux-user/main.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
Reviewed-by: Eric Blake <eblake@redhat.com>
Can you also fix the occurrence of 0x%d in trace-events, for
mhp_pc_dimm_assigned_slot()? (Or whatever file it lands in after the
trace-events split pull request)
> diff --git a/linux-user/main.c b/linux-user/main.c
> index b9a4e0e..c79f5cb 100644
> --- a/linux-user/main.c
> +++ b/linux-user/main.c
> @@ -2036,7 +2036,7 @@ void cpu_loop(CPUPPCState *env)
> /* just indicate that signals should be handled asap */
> break;
> default:
> - cpu_abort(cs, "Unknown exception 0x%d. Aborting\n", trapnr);
> + cpu_abort(cs, "Unknown exception 0x%x. Aborting\n", trapnr);
> break;
> }
> process_pending_signals(env);
>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [Qemu-trivial] [Qemu-devel] [PATCH] linux-user, trivial: display "0x%x" instead of "0x%d"
2016-06-20 16:49 ` Eric Blake
@ 2016-06-20 17:24 ` Laurent Vivier
-1 siblings, 0 replies; 10+ messages in thread
From: Laurent Vivier @ 2016-06-20 17:24 UTC (permalink / raw)
To: Eric Blake, Riku Voipio; +Cc: qemu-trivial, qemu-devel
[-- Attachment #1.1: Type: text/plain, Size: 1283 bytes --]
Le 20/06/2016 à 18:49, Eric Blake a écrit :
> On 06/20/2016 03:51 AM, Laurent Vivier wrote:
>> Display an exception number, generally defined as an hexadecimal
>> number (for instance, EXCP_HLT is 0x10001).
>>
>> Signed-off-by: Laurent Vivier <laurent@vivier.eu>
>> ---
>> Resent to fix qemu-trivial email address.
>>
>> linux-user/main.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>
> Reviewed-by: Eric Blake <eblake@redhat.com>
>
> Can you also fix the occurrence of 0x%d in trace-events, for
> mhp_pc_dimm_assigned_slot()? (Or whatever file it lands in after the
> trace-events split pull request)
Yes, after the after split pull request.
Thanks,
Laurent
>
>> diff --git a/linux-user/main.c b/linux-user/main.c
>> index b9a4e0e..c79f5cb 100644
>> --- a/linux-user/main.c
>> +++ b/linux-user/main.c
>> @@ -2036,7 +2036,7 @@ void cpu_loop(CPUPPCState *env)
>> /* just indicate that signals should be handled asap */
>> break;
>> default:
>> - cpu_abort(cs, "Unknown exception 0x%d. Aborting\n", trapnr);
>> + cpu_abort(cs, "Unknown exception 0x%x. Aborting\n", trapnr);
>> break;
>> }
>> process_pending_signals(env);
>>
>
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [Qemu-devel] [PATCH] linux-user, trivial: display "0x%x" instead of "0x%d"
@ 2016-06-20 17:24 ` Laurent Vivier
0 siblings, 0 replies; 10+ messages in thread
From: Laurent Vivier @ 2016-06-20 17:24 UTC (permalink / raw)
To: Eric Blake, Riku Voipio; +Cc: qemu-trivial, qemu-devel
[-- Attachment #1: Type: text/plain, Size: 1283 bytes --]
Le 20/06/2016 à 18:49, Eric Blake a écrit :
> On 06/20/2016 03:51 AM, Laurent Vivier wrote:
>> Display an exception number, generally defined as an hexadecimal
>> number (for instance, EXCP_HLT is 0x10001).
>>
>> Signed-off-by: Laurent Vivier <laurent@vivier.eu>
>> ---
>> Resent to fix qemu-trivial email address.
>>
>> linux-user/main.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>
> Reviewed-by: Eric Blake <eblake@redhat.com>
>
> Can you also fix the occurrence of 0x%d in trace-events, for
> mhp_pc_dimm_assigned_slot()? (Or whatever file it lands in after the
> trace-events split pull request)
Yes, after the after split pull request.
Thanks,
Laurent
>
>> diff --git a/linux-user/main.c b/linux-user/main.c
>> index b9a4e0e..c79f5cb 100644
>> --- a/linux-user/main.c
>> +++ b/linux-user/main.c
>> @@ -2036,7 +2036,7 @@ void cpu_loop(CPUPPCState *env)
>> /* just indicate that signals should be handled asap */
>> break;
>> default:
>> - cpu_abort(cs, "Unknown exception 0x%d. Aborting\n", trapnr);
>> + cpu_abort(cs, "Unknown exception 0x%x. Aborting\n", trapnr);
>> break;
>> }
>> process_pending_signals(env);
>>
>
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [Qemu-trivial] [PATCH] linux-user, trivial: display "0x%x" instead of "0x%d"
2016-06-20 9:51 ` [Qemu-devel] " Laurent Vivier
@ 2016-06-21 19:22 ` Riku Voipio
-1 siblings, 0 replies; 10+ messages in thread
From: Riku Voipio @ 2016-06-21 19:22 UTC (permalink / raw)
To: Laurent Vivier; +Cc: qemu-devel, qemu-trivial
On Mon, Jun 20, 2016 at 11:51:32AM +0200, Laurent Vivier wrote:
> Display an exception number, generally defined as an hexadecimal
> number (for instance, EXCP_HLT is 0x10001).
Acked-by: Riku Voipio <riku.voipio@linaro.org>
> Signed-off-by: Laurent Vivier <laurent@vivier.eu>
> ---
> Resent to fix qemu-trivial email address.
>
> linux-user/main.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/linux-user/main.c b/linux-user/main.c
> index b9a4e0e..c79f5cb 100644
> --- a/linux-user/main.c
> +++ b/linux-user/main.c
> @@ -2036,7 +2036,7 @@ void cpu_loop(CPUPPCState *env)
> /* just indicate that signals should be handled asap */
> break;
> default:
> - cpu_abort(cs, "Unknown exception 0x%d. Aborting\n", trapnr);
> + cpu_abort(cs, "Unknown exception 0x%x. Aborting\n", trapnr);
> break;
> }
> process_pending_signals(env);
> --
> 2.5.5
>
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [Qemu-devel] [PATCH] linux-user, trivial: display "0x%x" instead of "0x%d"
@ 2016-06-21 19:22 ` Riku Voipio
0 siblings, 0 replies; 10+ messages in thread
From: Riku Voipio @ 2016-06-21 19:22 UTC (permalink / raw)
To: Laurent Vivier; +Cc: qemu-devel, qemu-trivial
On Mon, Jun 20, 2016 at 11:51:32AM +0200, Laurent Vivier wrote:
> Display an exception number, generally defined as an hexadecimal
> number (for instance, EXCP_HLT is 0x10001).
Acked-by: Riku Voipio <riku.voipio@linaro.org>
> Signed-off-by: Laurent Vivier <laurent@vivier.eu>
> ---
> Resent to fix qemu-trivial email address.
>
> linux-user/main.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/linux-user/main.c b/linux-user/main.c
> index b9a4e0e..c79f5cb 100644
> --- a/linux-user/main.c
> +++ b/linux-user/main.c
> @@ -2036,7 +2036,7 @@ void cpu_loop(CPUPPCState *env)
> /* just indicate that signals should be handled asap */
> break;
> default:
> - cpu_abort(cs, "Unknown exception 0x%d. Aborting\n", trapnr);
> + cpu_abort(cs, "Unknown exception 0x%x. Aborting\n", trapnr);
> break;
> }
> process_pending_signals(env);
> --
> 2.5.5
>
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [Qemu-trivial] [PATCH] linux-user, trivial: display "0x%x" instead of "0x%d"
2016-06-20 9:51 ` [Qemu-devel] " Laurent Vivier
@ 2016-07-26 12:34 ` Michael Tokarev
-1 siblings, 0 replies; 10+ messages in thread
From: Michael Tokarev @ 2016-07-26 12:34 UTC (permalink / raw)
To: Laurent Vivier, Riku Voipio; +Cc: qemu-trivial, qemu-devel
20.06.2016 12:51, Laurent Vivier wrote:
> Display an exception number, generally defined as an hexadecimal
> number (for instance, EXCP_HLT is 0x10001).
Applied to -trivial, thanks!
/mjt
^ permalink raw reply [flat|nested] 10+ messages in thread