From: Heiko Stuebner <heiko@sntech.de>
To: "Michele Zuccalà" <ardutu@gmail.com>
Cc: Johan Jonker <jbx6244@gmail.com>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org, devicetree@vger.kernel.org,
Alex Bee <knaerzche@gmail.com>,
Corentin Labbe <clabbe@baylibre.com>
Subject: Re: [PATCH] arm: dts: rockchip: add crypto node for RK322x
Date: Thu, 20 Oct 2022 13:24:20 +0200 [thread overview]
Message-ID: <5768534.MhkbZ0Pkbq@phil> (raw)
In-Reply-To: <CAK1Nf75B-4wzM3pafaOVHCD9WugT3YPjphbEq25-WLRGh3Jhbw@mail.gmail.com>
Hi Michele,
Am Donnerstag, 20. Oktober 2022, 13:13:10 CEST schrieb Michele Zuccalà:
> > no worries, we'll get you through it :-)
> >
>
> thank you
>
> >
> > actually you want to go the following route:
> >
> > (1) pick up
> > - https://lore.kernel.org/all/20220927075511.3147847-25-clabbe@baylibre.com/
> > - https://lore.kernel.org/all/20220927075511.3147847-26-clabbe@baylibre.com/
> > as a base to work on
> >
> > (2) create a patch to add your compatible.
> > I _think_ after that, the compatible block should looks
> > something like:
> >
> > compatible:
> > oneOf:
> > - const: rockchip,rk3288-crypto
> > - const: rockchip,rk3328-crypto
> > - const: rockchip,rk3399-crypto
> > - items:
> > - const: rockchip,rk3228-crypto
> > - const: rockchip,rk3288-crypto
> >
> > to handle the new dual element compatible.
> > make dt_binding_check
> > should tell you about a wrong format.
> >
> > (3) modify your dts patch to use the two compatibles
> > (4) export patches by
> > git format-patch -2 --cover-letter
> > and mention in the cover-letter the dependency on the
> > yaml conversion.
>
> very clear. But excuse the stupid question, this way it becomes a new patchset
> and not the v2 of this patch, right?! Will this patch be automatically
> ignored ?!
The new patchset still should become v2, as it still addresses
your overall goal of adding crypto support for the rk3228.
Heiko
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
WARNING: multiple messages have this Message-ID (diff)
From: Heiko Stuebner <heiko@sntech.de>
To: "Michele Zuccalà" <ardutu@gmail.com>
Cc: Johan Jonker <jbx6244@gmail.com>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org, devicetree@vger.kernel.org,
Alex Bee <knaerzche@gmail.com>,
Corentin Labbe <clabbe@baylibre.com>
Subject: Re: [PATCH] arm: dts: rockchip: add crypto node for RK322x
Date: Thu, 20 Oct 2022 13:24:20 +0200 [thread overview]
Message-ID: <5768534.MhkbZ0Pkbq@phil> (raw)
In-Reply-To: <CAK1Nf75B-4wzM3pafaOVHCD9WugT3YPjphbEq25-WLRGh3Jhbw@mail.gmail.com>
Hi Michele,
Am Donnerstag, 20. Oktober 2022, 13:13:10 CEST schrieb Michele Zuccalà:
> > no worries, we'll get you through it :-)
> >
>
> thank you
>
> >
> > actually you want to go the following route:
> >
> > (1) pick up
> > - https://lore.kernel.org/all/20220927075511.3147847-25-clabbe@baylibre.com/
> > - https://lore.kernel.org/all/20220927075511.3147847-26-clabbe@baylibre.com/
> > as a base to work on
> >
> > (2) create a patch to add your compatible.
> > I _think_ after that, the compatible block should looks
> > something like:
> >
> > compatible:
> > oneOf:
> > - const: rockchip,rk3288-crypto
> > - const: rockchip,rk3328-crypto
> > - const: rockchip,rk3399-crypto
> > - items:
> > - const: rockchip,rk3228-crypto
> > - const: rockchip,rk3288-crypto
> >
> > to handle the new dual element compatible.
> > make dt_binding_check
> > should tell you about a wrong format.
> >
> > (3) modify your dts patch to use the two compatibles
> > (4) export patches by
> > git format-patch -2 --cover-letter
> > and mention in the cover-letter the dependency on the
> > yaml conversion.
>
> very clear. But excuse the stupid question, this way it becomes a new patchset
> and not the v2 of this patch, right?! Will this patch be automatically
> ignored ?!
The new patchset still should become v2, as it still addresses
your overall goal of adding crypto support for the rk3228.
Heiko
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Heiko Stuebner <heiko@sntech.de>
To: "Michele Zuccalà" <ardutu@gmail.com>
Cc: Johan Jonker <jbx6244@gmail.com>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org, devicetree@vger.kernel.org,
Alex Bee <knaerzche@gmail.com>,
Corentin Labbe <clabbe@baylibre.com>
Subject: Re: [PATCH] arm: dts: rockchip: add crypto node for RK322x
Date: Thu, 20 Oct 2022 13:24:20 +0200 [thread overview]
Message-ID: <5768534.MhkbZ0Pkbq@phil> (raw)
In-Reply-To: <CAK1Nf75B-4wzM3pafaOVHCD9WugT3YPjphbEq25-WLRGh3Jhbw@mail.gmail.com>
Hi Michele,
Am Donnerstag, 20. Oktober 2022, 13:13:10 CEST schrieb Michele Zuccalà:
> > no worries, we'll get you through it :-)
> >
>
> thank you
>
> >
> > actually you want to go the following route:
> >
> > (1) pick up
> > - https://lore.kernel.org/all/20220927075511.3147847-25-clabbe@baylibre.com/
> > - https://lore.kernel.org/all/20220927075511.3147847-26-clabbe@baylibre.com/
> > as a base to work on
> >
> > (2) create a patch to add your compatible.
> > I _think_ after that, the compatible block should looks
> > something like:
> >
> > compatible:
> > oneOf:
> > - const: rockchip,rk3288-crypto
> > - const: rockchip,rk3328-crypto
> > - const: rockchip,rk3399-crypto
> > - items:
> > - const: rockchip,rk3228-crypto
> > - const: rockchip,rk3288-crypto
> >
> > to handle the new dual element compatible.
> > make dt_binding_check
> > should tell you about a wrong format.
> >
> > (3) modify your dts patch to use the two compatibles
> > (4) export patches by
> > git format-patch -2 --cover-letter
> > and mention in the cover-letter the dependency on the
> > yaml conversion.
>
> very clear. But excuse the stupid question, this way it becomes a new patchset
> and not the v2 of this patch, right?! Will this patch be automatically
> ignored ?!
The new patchset still should become v2, as it still addresses
your overall goal of adding crypto support for the rk3228.
Heiko
next prev parent reply other threads:[~2022-10-20 12:17 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-19 16:47 [PATCH] arm: dts: rockchip: add crypto node for RK322x Michele Zuccalà
2022-10-19 16:47 ` Michele Zuccalà
2022-10-19 16:47 ` Michele Zuccalà
2022-10-19 17:39 ` Johan Jonker
2022-10-19 17:39 ` Johan Jonker
2022-10-19 17:39 ` Johan Jonker
2022-10-20 7:10 ` ilmich
2022-10-20 7:10 ` ilmich
2022-10-20 7:10 ` ilmich
2022-10-20 8:53 ` Heiko Stuebner
2022-10-20 8:53 ` Heiko Stuebner
2022-10-20 8:53 ` Heiko Stuebner
2022-10-20 11:13 ` Michele Zuccalà
2022-10-20 11:13 ` Michele Zuccalà
2022-10-20 11:13 ` Michele Zuccalà
2022-10-20 11:24 ` Heiko Stuebner [this message]
2022-10-20 11:24 ` Heiko Stuebner
2022-10-20 11:24 ` Heiko Stuebner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5768534.MhkbZ0Pkbq@phil \
--to=heiko@sntech.de \
--cc=ardutu@gmail.com \
--cc=clabbe@baylibre.com \
--cc=devicetree@vger.kernel.org \
--cc=jbx6244@gmail.com \
--cc=knaerzche@gmail.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.