All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stephen Boyd <sboyd@codeaurora.org>
To: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>,
	Andy Gross <andy.gross@linaro.org>
Cc: devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	David Brown <david.brown@linaro.org>,
	Rob Herring <robh+dt@kernel.org>,
	linux-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 1/8] arm64: dts: db820c: add basic board support
Date: Mon, 20 Jun 2016 16:23:52 -0700	[thread overview]
Message-ID: <57687B08.9060900@codeaurora.org> (raw)
In-Reply-To: <1466452907-23290-2-git-send-email-srinivas.kandagatla@linaro.org>

On 06/20/2016 01:01 PM, Srinivas Kandagatla wrote:
> This patch adds apq8096 db820c basic support with serial port.
>
> Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
> ---
>  arch/arm64/boot/dts/qcom/Makefile            |  2 +-
>  arch/arm64/boot/dts/qcom/apq8096-db820c.dts  | 21 +++++++++++++++++
>  arch/arm64/boot/dts/qcom/apq8096-db820c.dtsi | 34 ++++++++++++++++++++++++++++
>  3 files changed, 56 insertions(+), 1 deletion(-)
>  create mode 100644 arch/arm64/boot/dts/qcom/apq8096-db820c.dts
>  create mode 100644 arch/arm64/boot/dts/qcom/apq8096-db820c.dtsi
>
> diff --git a/arch/arm64/boot/dts/qcom/Makefile b/arch/arm64/boot/dts/qcom/Makefile
> index fa1f661..80ecdfe 100644
> --- a/arch/arm64/boot/dts/qcom/Makefile
> +++ b/arch/arm64/boot/dts/qcom/Makefile
> @@ -1,5 +1,5 @@
>  dtb-$(CONFIG_ARCH_QCOM)	+= apq8016-sbc.dtb msm8916-mtp.dtb
> -dtb-$(CONFIG_ARCH_QCOM)	+= msm8996-mtp.dtb
> +dtb-$(CONFIG_ARCH_QCOM)	+= msm8996-mtp.dtb apq8096-db820c.dtb

We should do a new line for each board as other arm64 vendors have done?

> diff --git a/arch/arm64/boot/dts/qcom/apq8096-db820c.dts b/arch/arm64/boot/dts/qcom/apq8096-db820c.dts
> new file mode 100644
> index 0000000..e1a55b1
> --- /dev/null
> +++ b/arch/arm64/boot/dts/qcom/apq8096-db820c.dts
> @@ -0,0 +1,21 @@
> +/*
> + * Copyright (c) 2014-2016, The Linux Foundation. All rights reserved.
> + *
> + * This program is free software; you can redistribute it and/or modify
> + * it under the terms of the GNU General Public License version 2 and
> + * only version 2 as published by the Free Software Foundation.
> + *
> + * This program is distributed in the hope that it will be useful,
> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> + * GNU General Public License for more details.
> + */
> +
> +/dts-v1/;
> +
> +#include "apq8096-db820c.dtsi"
> +
> +/ {
> +	model = "Qualcomm Technologies, Inc. DB820c";
> +	compatible = "qcom,apq8096-db820c";

Should be qcom,apq8096-sbc? At least I have to use that on my board to
match the board ids.

-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project

WARNING: multiple messages have this Message-ID (diff)
From: sboyd@codeaurora.org (Stephen Boyd)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/8] arm64: dts: db820c: add basic board support
Date: Mon, 20 Jun 2016 16:23:52 -0700	[thread overview]
Message-ID: <57687B08.9060900@codeaurora.org> (raw)
In-Reply-To: <1466452907-23290-2-git-send-email-srinivas.kandagatla@linaro.org>

On 06/20/2016 01:01 PM, Srinivas Kandagatla wrote:
> This patch adds apq8096 db820c basic support with serial port.
>
> Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
> ---
>  arch/arm64/boot/dts/qcom/Makefile            |  2 +-
>  arch/arm64/boot/dts/qcom/apq8096-db820c.dts  | 21 +++++++++++++++++
>  arch/arm64/boot/dts/qcom/apq8096-db820c.dtsi | 34 ++++++++++++++++++++++++++++
>  3 files changed, 56 insertions(+), 1 deletion(-)
>  create mode 100644 arch/arm64/boot/dts/qcom/apq8096-db820c.dts
>  create mode 100644 arch/arm64/boot/dts/qcom/apq8096-db820c.dtsi
>
> diff --git a/arch/arm64/boot/dts/qcom/Makefile b/arch/arm64/boot/dts/qcom/Makefile
> index fa1f661..80ecdfe 100644
> --- a/arch/arm64/boot/dts/qcom/Makefile
> +++ b/arch/arm64/boot/dts/qcom/Makefile
> @@ -1,5 +1,5 @@
>  dtb-$(CONFIG_ARCH_QCOM)	+= apq8016-sbc.dtb msm8916-mtp.dtb
> -dtb-$(CONFIG_ARCH_QCOM)	+= msm8996-mtp.dtb
> +dtb-$(CONFIG_ARCH_QCOM)	+= msm8996-mtp.dtb apq8096-db820c.dtb

We should do a new line for each board as other arm64 vendors have done?

> diff --git a/arch/arm64/boot/dts/qcom/apq8096-db820c.dts b/arch/arm64/boot/dts/qcom/apq8096-db820c.dts
> new file mode 100644
> index 0000000..e1a55b1
> --- /dev/null
> +++ b/arch/arm64/boot/dts/qcom/apq8096-db820c.dts
> @@ -0,0 +1,21 @@
> +/*
> + * Copyright (c) 2014-2016, The Linux Foundation. All rights reserved.
> + *
> + * This program is free software; you can redistribute it and/or modify
> + * it under the terms of the GNU General Public License version 2 and
> + * only version 2 as published by the Free Software Foundation.
> + *
> + * This program is distributed in the hope that it will be useful,
> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> + * GNU General Public License for more details.
> + */
> +
> +/dts-v1/;
> +
> +#include "apq8096-db820c.dtsi"
> +
> +/ {
> +	model = "Qualcomm Technologies, Inc. DB820c";
> +	compatible = "qcom,apq8096-db820c";

Should be qcom,apq8096-sbc? At least I have to use that on my board to
match the board ids.

-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project

WARNING: multiple messages have this Message-ID (diff)
From: Stephen Boyd <sboyd@codeaurora.org>
To: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>,
	Andy Gross <andy.gross@linaro.org>
Cc: Rob Herring <robh+dt@kernel.org>,
	David Brown <david.brown@linaro.org>,
	devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org,
	linux-soc@vger.kernel.org
Subject: Re: [PATCH 1/8] arm64: dts: db820c: add basic board support
Date: Mon, 20 Jun 2016 16:23:52 -0700	[thread overview]
Message-ID: <57687B08.9060900@codeaurora.org> (raw)
In-Reply-To: <1466452907-23290-2-git-send-email-srinivas.kandagatla@linaro.org>

On 06/20/2016 01:01 PM, Srinivas Kandagatla wrote:
> This patch adds apq8096 db820c basic support with serial port.
>
> Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
> ---
>  arch/arm64/boot/dts/qcom/Makefile            |  2 +-
>  arch/arm64/boot/dts/qcom/apq8096-db820c.dts  | 21 +++++++++++++++++
>  arch/arm64/boot/dts/qcom/apq8096-db820c.dtsi | 34 ++++++++++++++++++++++++++++
>  3 files changed, 56 insertions(+), 1 deletion(-)
>  create mode 100644 arch/arm64/boot/dts/qcom/apq8096-db820c.dts
>  create mode 100644 arch/arm64/boot/dts/qcom/apq8096-db820c.dtsi
>
> diff --git a/arch/arm64/boot/dts/qcom/Makefile b/arch/arm64/boot/dts/qcom/Makefile
> index fa1f661..80ecdfe 100644
> --- a/arch/arm64/boot/dts/qcom/Makefile
> +++ b/arch/arm64/boot/dts/qcom/Makefile
> @@ -1,5 +1,5 @@
>  dtb-$(CONFIG_ARCH_QCOM)	+= apq8016-sbc.dtb msm8916-mtp.dtb
> -dtb-$(CONFIG_ARCH_QCOM)	+= msm8996-mtp.dtb
> +dtb-$(CONFIG_ARCH_QCOM)	+= msm8996-mtp.dtb apq8096-db820c.dtb

We should do a new line for each board as other arm64 vendors have done?

> diff --git a/arch/arm64/boot/dts/qcom/apq8096-db820c.dts b/arch/arm64/boot/dts/qcom/apq8096-db820c.dts
> new file mode 100644
> index 0000000..e1a55b1
> --- /dev/null
> +++ b/arch/arm64/boot/dts/qcom/apq8096-db820c.dts
> @@ -0,0 +1,21 @@
> +/*
> + * Copyright (c) 2014-2016, The Linux Foundation. All rights reserved.
> + *
> + * This program is free software; you can redistribute it and/or modify
> + * it under the terms of the GNU General Public License version 2 and
> + * only version 2 as published by the Free Software Foundation.
> + *
> + * This program is distributed in the hope that it will be useful,
> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> + * GNU General Public License for more details.
> + */
> +
> +/dts-v1/;
> +
> +#include "apq8096-db820c.dtsi"
> +
> +/ {
> +	model = "Qualcomm Technologies, Inc. DB820c";
> +	compatible = "qcom,apq8096-db820c";

Should be qcom,apq8096-sbc? At least I have to use that on my board to
match the board ids.

-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project

  reply	other threads:[~2016-06-20 23:23 UTC|newest]

Thread overview: 39+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-06-20 20:01 [PATCH 0/8] arm64: dts: db820c: Add basic board support Srinivas Kandagatla
2016-06-20 20:01 ` Srinivas Kandagatla
2016-06-20 20:01 ` Srinivas Kandagatla
2016-06-20 20:01 ` [PATCH 1/8] arm64: dts: db820c: add " Srinivas Kandagatla
2016-06-20 20:01   ` Srinivas Kandagatla
2016-06-20 20:01   ` Srinivas Kandagatla
2016-06-20 23:23   ` Stephen Boyd [this message]
2016-06-20 23:23     ` Stephen Boyd
2016-06-20 23:23     ` Stephen Boyd
     [not found]     ` <57687B08.9060900-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
2016-06-21  9:14       ` Srinivas Kandagatla
2016-06-21  9:14         ` Srinivas Kandagatla
2016-06-21  9:14         ` Srinivas Kandagatla
     [not found]         ` <5769058D.9020008-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2016-06-28 17:17           ` Stephen Boyd
2016-06-28 17:17             ` Stephen Boyd
2016-06-28 17:17             ` Stephen Boyd
2016-06-20 20:01 ` [PATCH 2/8] arm64: dts: db820c: add support to LS-UART0 Srinivas Kandagatla
2016-06-20 20:01   ` Srinivas Kandagatla
2016-06-20 20:01   ` Srinivas Kandagatla
2016-06-20 20:01 ` [PATCH 3/8] arm64: dts: db820c: add support to LS-I2C0 Srinivas Kandagatla
2016-06-20 20:01   ` Srinivas Kandagatla
2016-06-20 20:01   ` Srinivas Kandagatla
2016-06-20 20:01 ` [PATCH 4/8] arm64: dts: db820c: add support to LS-I2C1 Srinivas Kandagatla
2016-06-20 20:01   ` Srinivas Kandagatla
2016-06-20 20:01   ` Srinivas Kandagatla
2016-06-20 20:01 ` [PATCH 5/8] arm64: dts: db820c: add support to I2C on HS Srinivas Kandagatla
2016-06-20 20:01   ` Srinivas Kandagatla
2016-06-20 20:01   ` Srinivas Kandagatla
2016-06-20 20:01 ` [PATCH 6/8] arm64: dts: db820c: add support to LS-SPI0 Srinivas Kandagatla
2016-06-20 20:01   ` Srinivas Kandagatla
2016-06-20 20:01   ` Srinivas Kandagatla
2016-06-20 20:01 ` [PATCH 7/8] arm64: dts: db820c: add support to SPI on HS Srinivas Kandagatla
2016-06-20 20:01   ` Srinivas Kandagatla
2016-06-20 20:01   ` Srinivas Kandagatla
2016-06-20 20:01 ` [PATCH 8/8] arm64: dts: db820c: add support to external sd card Srinivas Kandagatla
2016-06-20 20:01   ` Srinivas Kandagatla
2016-06-20 20:01   ` Srinivas Kandagatla
2016-06-20 22:53   ` kbuild test robot
2016-06-20 22:53     ` kbuild test robot
2016-06-20 22:53     ` kbuild test robot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=57687B08.9060900@codeaurora.org \
    --to=sboyd@codeaurora.org \
    --cc=andy.gross@linaro.org \
    --cc=david.brown@linaro.org \
    --cc=devicetree@vger.kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-soc@vger.kernel.org \
    --cc=robh+dt@kernel.org \
    --cc=srinivas.kandagatla@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.