From: Jaehoon Chung <jh80.chung-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
To: Alex Lemberg
<Alex.Lemberg-XdAiOPVOjttBDgjK7y7TUQ@public.gmane.org>,
Shawn Lin <shawn.lin-TNX95d0MmH7DzftRWevZcw@public.gmane.org>,
Ulf Hansson <ulf.hansson-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
Cc: "linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org"
<linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org>,
Doug Anderson <dianders-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>,
"linux-mmc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<linux-mmc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
Adrian Hunter
<adrian.hunter-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>,
"linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: Re: [PATCH] mmc: core: add auto bkops support
Date: Tue, 21 Jun 2016 09:38:16 +0900 [thread overview]
Message-ID: <57688C78.1020006@samsung.com> (raw)
In-Reply-To: <7078F2B9-63B6-4170-BFA1-5AC370F0D4DD-XdAiOPVOjttBDgjK7y7TUQ@public.gmane.org>
On 06/20/2016 10:33 PM, Alex Lemberg wrote:
> Hi Shawn,
>
> […]
>
>>>> +
>>>> +static int mmc_stop_auto_bkops(struct mmc_card *card)
>>>> +{
>>>> + int err = 0;
>>>> +
>>>> + if (!card->ext_csd.auto_bkops_en)
>>>> + return 0;
>>>> +
>>>
>>> Shouldn’t the BKOPS_STATUS be checked prior to disabling the BKOPS activity of the device?
>>>
>>
>> Hrmm.. I read the whole section of spec for it, and I did find this
>> requirement for manul bkops but not for the auto one. So what should we
>> do if using the auto one?
>>
>
> In case of AUTO BKOPS, the eMMC Device should perform internal GC
> in the same way as in case of MANUAL BKOPS.
> The only difference is a host awareness.
> Although there is no requirement in the spec, I think the driver can
> give some time to the device to perform/complete its internal GC during the idle time.
> Thus I think we can check the BKOPS_STATUS on Runtime suspend.
I'm not sure we can check BKOPS_STATUS when use the AUTO_BKOPS.
I have also read the SPEC, but it's not clearly for checking the BKOPS_STATUS.
Just i understood that it should be operated without a host's awareness.
Best Regards,
Jaehoon Chung
>
> […]
>
> Thanks,
> Alex
>
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
WARNING: multiple messages have this Message-ID (diff)
From: Jaehoon Chung <jh80.chung@samsung.com>
To: Alex Lemberg <Alex.Lemberg@sandisk.com>,
Shawn Lin <shawn.lin@rock-chips.com>,
Ulf Hansson <ulf.hansson@linaro.org>
Cc: Adrian Hunter <adrian.hunter@intel.com>,
"linux-mmc@vger.kernel.org" <linux-mmc@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Doug Anderson <dianders@chromium.org>,
"linux-rockchip@lists.infradead.org"
<linux-rockchip@lists.infradead.org>
Subject: Re: [PATCH] mmc: core: add auto bkops support
Date: Tue, 21 Jun 2016 09:38:16 +0900 [thread overview]
Message-ID: <57688C78.1020006@samsung.com> (raw)
In-Reply-To: <7078F2B9-63B6-4170-BFA1-5AC370F0D4DD@sandisk.com>
On 06/20/2016 10:33 PM, Alex Lemberg wrote:
> Hi Shawn,
>
> […]
>
>>>> +
>>>> +static int mmc_stop_auto_bkops(struct mmc_card *card)
>>>> +{
>>>> + int err = 0;
>>>> +
>>>> + if (!card->ext_csd.auto_bkops_en)
>>>> + return 0;
>>>> +
>>>
>>> Shouldn’t the BKOPS_STATUS be checked prior to disabling the BKOPS activity of the device?
>>>
>>
>> Hrmm.. I read the whole section of spec for it, and I did find this
>> requirement for manul bkops but not for the auto one. So what should we
>> do if using the auto one?
>>
>
> In case of AUTO BKOPS, the eMMC Device should perform internal GC
> in the same way as in case of MANUAL BKOPS.
> The only difference is a host awareness.
> Although there is no requirement in the spec, I think the driver can
> give some time to the device to perform/complete its internal GC during the idle time.
> Thus I think we can check the BKOPS_STATUS on Runtime suspend.
I'm not sure we can check BKOPS_STATUS when use the AUTO_BKOPS.
I have also read the SPEC, but it's not clearly for checking the BKOPS_STATUS.
Just i understood that it should be operated without a host's awareness.
Best Regards,
Jaehoon Chung
>
> […]
>
> Thanks,
> Alex
>
next prev parent reply other threads:[~2016-06-21 0:38 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-06 3:07 [PATCH] mmc: core: add auto bkops support Shawn Lin
[not found] ` <1465182439-27963-1-git-send-email-shawn.lin-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
2016-06-08 14:46 ` Alex Lemberg
2016-06-08 14:46 ` Alex Lemberg
2016-06-12 1:13 ` Shawn Lin
[not found] ` <d5c75760-e8b4-1784-a7de-3d78eeca1d0e-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
2016-06-20 13:33 ` Alex Lemberg
2016-06-20 13:33 ` Alex Lemberg
[not found] ` <7078F2B9-63B6-4170-BFA1-5AC370F0D4DD-XdAiOPVOjttBDgjK7y7TUQ@public.gmane.org>
2016-06-21 0:38 ` Jaehoon Chung [this message]
2016-06-21 0:38 ` Jaehoon Chung
2016-06-21 1:44 ` Shawn Lin
2016-06-21 1:44 ` Shawn Lin
[not found] ` <29966a6f-eb14-0307-08cc-f91a97f50382-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
2016-06-22 14:08 ` Alex Lemberg
2016-06-22 14:08 ` Alex Lemberg
2016-06-23 1:33 ` Shawn Lin
2016-06-23 5:22 ` Adrian Hunter
2016-06-27 9:08 ` Ulf Hansson
[not found] ` <CAPDyKFoxTH_-U_Aj0jHWPKbwd+4OoOYBTdOeD-6SpG4XyM=3AA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2016-06-27 11:30 ` Alex Lemberg
2016-06-27 11:30 ` Alex Lemberg
2016-06-13 6:29 ` Adrian Hunter
[not found] ` <575E52AC.6000902-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2016-06-13 7:48 ` Shawn Lin
2016-06-13 7:48 ` Shawn Lin
2016-06-13 8:17 ` Adrian Hunter
2016-06-13 8:58 ` Shawn Lin
2016-06-13 12:25 ` Adrian Hunter
2016-06-22 10:21 ` Ulf Hansson
2016-06-22 10:21 ` Ulf Hansson
[not found] ` <CAPDyKFq7Pr1YiacwpeDq3eAYmApydTj8Kbkyh=Cb6+vJC9BV3Q-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2016-06-22 14:20 ` Alex Lemberg
2016-06-22 14:20 ` Alex Lemberg
[not found] ` <B9A5F20C-E8A0-4E81-BA07-79E60017E728-XdAiOPVOjttBDgjK7y7TUQ@public.gmane.org>
2016-06-22 14:28 ` Ulf Hansson
2016-06-22 14:28 ` Ulf Hansson
2016-06-22 14:57 ` Alex Lemberg
[not found] ` <362217AA-5AE7-471A-AF58-985676E261A4-XdAiOPVOjttBDgjK7y7TUQ@public.gmane.org>
2016-06-22 15:03 ` Ulf Hansson
2016-06-22 15:03 ` Ulf Hansson
2016-06-23 2:08 ` Shawn Lin
2016-06-27 9:00 ` Ulf Hansson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=57688C78.1020006@samsung.com \
--to=jh80.chung-sze3o3uu22jbdgjk7y7tuq@public.gmane.org \
--cc=Alex.Lemberg-XdAiOPVOjttBDgjK7y7TUQ@public.gmane.org \
--cc=adrian.hunter-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
--cc=dianders-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-mmc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=shawn.lin-TNX95d0MmH7DzftRWevZcw@public.gmane.org \
--cc=ulf.hansson-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.