All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Simon Kågström" <simon.kagstrom@netinsight.net>
To: cristian.dumitrescu@intel.com, stephen@networkplumber.org,
	dev@dpdk.org, thomas.monjalon@6wind.com
Subject: Re: [PATCH / RFC] sched: Correct subport calcuation
Date: Tue, 21 Jun 2016 08:40:58 +0200	[thread overview]
Message-ID: <5768E17A.4060404@netinsight.net> (raw)
In-Reply-To: <20160610082913.4878ab77@miho>

Hi again!

Any news about this patch? I'm off for parental leave starting next week
(until january), so any comments (or simply dropping it!) would be good
to have before that :-)

// Simon

On 2016-06-10 08:29, Simon Kagstrom wrote:
> Signed-off-by: Simon Kagstrom <simon.kagstrom@netinsight.net>
> ---
> I'm a total newbie to the rte_sched design and implementation, so I've
> added the RFC.
> 
> We get crashes (at other places in the scheduler) without this code.
> 
>  lib/librte_sched/rte_sched.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/lib/librte_sched/rte_sched.c b/lib/librte_sched/rte_sched.c
> index 1609ea8..b46ecfb 100644
> --- a/lib/librte_sched/rte_sched.c
> +++ b/lib/librte_sched/rte_sched.c
> @@ -1869,7 +1869,7 @@ grinder_next_pipe(struct rte_sched_port *port, uint32_t pos)
>  
>  	/* Install new pipe in the grinder */
>  	grinder->pindex = pipe_qindex >> 4;
> -	grinder->subport = port->subport + (grinder->pindex / port->n_pipes_per_subport);
> +	grinder->subport = port->subport + (grinder->pindex / port->n_subports_per_port);
>  	grinder->pipe = port->pipe + grinder->pindex;
>  	grinder->pipe_params = NULL; /* to be set after the pipe structure is prefetched */
>  	grinder->productive = 0;
> 

  reply	other threads:[~2016-06-21  6:41 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-06-10  6:29 [PATCH / RFC] sched: Correct subport calcuation Simon Kagstrom
2016-06-21  6:40 ` Simon Kågström [this message]
2016-06-21  9:03   ` Dumitrescu, Cristian
2016-06-23 19:44 ` Dumitrescu, Cristian

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5768E17A.4060404@netinsight.net \
    --to=simon.kagstrom@netinsight.net \
    --cc=cristian.dumitrescu@intel.com \
    --cc=dev@dpdk.org \
    --cc=stephen@networkplumber.org \
    --cc=thomas.monjalon@6wind.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.