* [PATCH bluetooth-next] atusb: don't change csma settings while set channel
@ 2016-06-20 15:01 Alexander Aring
2016-06-21 9:36 ` Stefan Schmidt
0 siblings, 1 reply; 2+ messages in thread
From: Alexander Aring @ 2016-06-20 15:01 UTC (permalink / raw)
To: linux-wpan; +Cc: kernel, Alexander Aring, Stefan Schmidt
This patch fixes the behaviour to not overwrite csma settings when
set channel afterwards.
Cc: Stefan Schmidt <stefan@osg.samsung.com>
Signed-off-by: Alexander Aring <aar@pengutronix.de>
---
drivers/net/ieee802154/atusb.c | 6 +-----
1 file changed, 1 insertion(+), 5 deletions(-)
diff --git a/drivers/net/ieee802154/atusb.c b/drivers/net/ieee802154/atusb.c
index 52c9051..1056ed1 100644
--- a/drivers/net/ieee802154/atusb.c
+++ b/drivers/net/ieee802154/atusb.c
@@ -366,11 +366,7 @@ static int atusb_channel(struct ieee802154_hw *hw, u8 page, u8 channel)
struct atusb *atusb = hw->priv;
int ret;
- /* This implicitly sets the CCA (Clear Channel Assessment) mode to 0,
- * "Mode 3a, Carrier sense OR energy above threshold".
- * We should probably make this configurable. @@@
- */
- ret = atusb_write_reg(atusb, RG_PHY_CC_CCA, channel);
+ ret = atusb_write_subreg(atusb, SR_CHANNEL, channel);
if (ret < 0)
return ret;
msleep(1); /* @@@ ugly synchronization */
--
2.9.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH bluetooth-next] atusb: don't change csma settings while set channel
2016-06-20 15:01 [PATCH bluetooth-next] atusb: don't change csma settings while set channel Alexander Aring
@ 2016-06-21 9:36 ` Stefan Schmidt
0 siblings, 0 replies; 2+ messages in thread
From: Stefan Schmidt @ 2016-06-21 9:36 UTC (permalink / raw)
To: Alexander Aring, linux-wpan; +Cc: kernel
Hello.
On 20/06/16 17:01, Alexander Aring wrote:
> This patch fixes the behaviour to not overwrite csma settings when
> set channel afterwards.
>
> Cc: Stefan Schmidt <stefan@osg.samsung.com>
> Signed-off-by: Alexander Aring <aar@pengutronix.de>
> ---
> drivers/net/ieee802154/atusb.c | 6 +-----
> 1 file changed, 1 insertion(+), 5 deletions(-)
>
> diff --git a/drivers/net/ieee802154/atusb.c b/drivers/net/ieee802154/atusb.c
> index 52c9051..1056ed1 100644
> --- a/drivers/net/ieee802154/atusb.c
> +++ b/drivers/net/ieee802154/atusb.c
> @@ -366,11 +366,7 @@ static int atusb_channel(struct ieee802154_hw *hw, u8 page, u8 channel)
> struct atusb *atusb = hw->priv;
> int ret;
>
> - /* This implicitly sets the CCA (Clear Channel Assessment) mode to 0,
> - * "Mode 3a, Carrier sense OR energy above threshold".
> - * We should probably make this configurable. @@@
> - */
> - ret = atusb_write_reg(atusb, RG_PHY_CC_CCA, channel);
> + ret = atusb_write_subreg(atusb, SR_CHANNEL, channel);
> if (ret < 0)
> return ret;
> msleep(1); /* @@@ ugly synchronization */
Good point. We have csma ops and iwpan support for csma now this setting
is no longer needed.
Acked-by: Stefan Schmidt <stefan@osg.samsung.com>
regards
Stefan Schmidt
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-06-21 9:54 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-06-20 15:01 [PATCH bluetooth-next] atusb: don't change csma settings while set channel Alexander Aring
2016-06-21 9:36 ` Stefan Schmidt
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.