From: Ben Greear <greearb@candelatech.com>
To: Mohammed Shafi Shajakhan <mohammed@codeaurora.org>
Cc: "linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
ath10k <ath10k@lists.infradead.org>,
Mohammed Shafi Shajakhan <mohammed@qti.qualcomm.com>
Subject: Re: Bug with: ath10k: enable parsing per station rx duration for 10.4?
Date: Tue, 21 Jun 2016 07:10:28 -0700 [thread overview]
Message-ID: <57694AD4.3020101@candelatech.com> (raw)
In-Reply-To: <20160621051829.GA20604@atheros-ThinkPad-T61>
On 06/20/2016 10:18 PM, Mohammed Shafi Shajakhan wrote:
> Hi Ben,
>
> thanks for reporting ...
>
> On Mon, Jun 20, 2016 at 04:06:52PM -0700, Ben Greear wrote:
>> I'm working on bringing up my hacked up version of 4.7 ath10k and 10.4 firmware, and I think
>> I may have found a regression.
>
> [shafi] let me know what is the issue.. some steps to recreate the issue.
ethtool -S wlan0
or similar should reproduce it.
You would see stats timeout messages in dmesg, and with a bit more debugging,
you notice that the driver is basically busy-spinning trying to get stats over
WMI and/or it is giving errors because skb pull fails because there actually is
not extd stats struct.
>>
>> My 10.4.3-ish firmware source has a bunch of:
>>
>> if (stats_id == WMI_REQUEST_PEER_STAT)
>> logic in it. In other words, it is not using that id as a bitfield.
>
> [shafi] will check this.
I fixed my firmware to treat it as a bitfield, and to specifically un-set the EXTD stats
bit, and now it works with my 4.7. Firmware fix should be backwards compatible.
>> Now, I can fix the firmware, but I am guessing that at least some stock
>> 10.4 firmware has this same issue, and of course any older firmware
>> that does not have this change will still be broken.
>>
>> So, do you want to back out this patch below, at least the part where it sends
>> in 0x9 as the stats_id?
>
> [shafi] request if you can check this please, there was some misunderstanding
> in the design when this feature got enabled in 10.4, we fixed it in
> https://patchwork.kernel.org/patch/9149357/
That might have fixed it, but it is not in 4.7, so I didn't have it
in my tree when testing yesterday.
Thanks,
Ben
--
Ben Greear <greearb@candelatech.com>
Candela Technologies Inc http://www.candelatech.com
_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k
WARNING: multiple messages have this Message-ID (diff)
From: Ben Greear <greearb@candelatech.com>
To: Mohammed Shafi Shajakhan <mohammed@codeaurora.org>
Cc: ath10k <ath10k@lists.infradead.org>,
"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
Mohammed Shafi Shajakhan <mohammed@qti.qualcomm.com>
Subject: Re: Bug with: ath10k: enable parsing per station rx duration for 10.4?
Date: Tue, 21 Jun 2016 07:10:28 -0700 [thread overview]
Message-ID: <57694AD4.3020101@candelatech.com> (raw)
In-Reply-To: <20160621051829.GA20604@atheros-ThinkPad-T61>
On 06/20/2016 10:18 PM, Mohammed Shafi Shajakhan wrote:
> Hi Ben,
>
> thanks for reporting ...
>
> On Mon, Jun 20, 2016 at 04:06:52PM -0700, Ben Greear wrote:
>> I'm working on bringing up my hacked up version of 4.7 ath10k and 10.4 firmware, and I think
>> I may have found a regression.
>
> [shafi] let me know what is the issue.. some steps to recreate the issue.
ethtool -S wlan0
or similar should reproduce it.
You would see stats timeout messages in dmesg, and with a bit more debugging,
you notice that the driver is basically busy-spinning trying to get stats over
WMI and/or it is giving errors because skb pull fails because there actually is
not extd stats struct.
>>
>> My 10.4.3-ish firmware source has a bunch of:
>>
>> if (stats_id == WMI_REQUEST_PEER_STAT)
>> logic in it. In other words, it is not using that id as a bitfield.
>
> [shafi] will check this.
I fixed my firmware to treat it as a bitfield, and to specifically un-set the EXTD stats
bit, and now it works with my 4.7. Firmware fix should be backwards compatible.
>> Now, I can fix the firmware, but I am guessing that at least some stock
>> 10.4 firmware has this same issue, and of course any older firmware
>> that does not have this change will still be broken.
>>
>> So, do you want to back out this patch below, at least the part where it sends
>> in 0x9 as the stats_id?
>
> [shafi] request if you can check this please, there was some misunderstanding
> in the design when this feature got enabled in 10.4, we fixed it in
> https://patchwork.kernel.org/patch/9149357/
That might have fixed it, but it is not in 4.7, so I didn't have it
in my tree when testing yesterday.
Thanks,
Ben
--
Ben Greear <greearb@candelatech.com>
Candela Technologies Inc http://www.candelatech.com
next prev parent reply other threads:[~2016-06-21 14:11 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-20 23:06 Bug with: ath10k: enable parsing per station rx duration for 10.4? Ben Greear
2016-06-20 23:06 ` Ben Greear
2016-06-21 5:18 ` Mohammed Shafi Shajakhan
2016-06-21 5:18 ` Mohammed Shafi Shajakhan
2016-06-21 14:10 ` Ben Greear [this message]
2016-06-21 14:10 ` Ben Greear
2016-06-21 15:41 ` Mohammed Shafi Shajakhan
2016-06-21 15:41 ` Mohammed Shafi Shajakhan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=57694AD4.3020101@candelatech.com \
--to=greearb@candelatech.com \
--cc=ath10k@lists.infradead.org \
--cc=linux-wireless@vger.kernel.org \
--cc=mohammed@codeaurora.org \
--cc=mohammed@qti.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.