All of lore.kernel.org
 help / color / mirror / Atom feed
From: Juergen Gross <jgross@suse.com>
To: Boris Ostrovsky <boris.ostrovsky@oracle.com>, david.vrabel@citrix.com
Cc: xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] xen/PMU: Log VPMU initialization error at lower level
Date: Tue, 21 Jun 2016 16:26:31 +0200	[thread overview]
Message-ID: <57694E97.3030604@suse.com> (raw)
In-Reply-To: <1466518653-25153-1-git-send-email-boris.ostrovsky@oracle.com>

On 21/06/16 16:17, Boris Ostrovsky wrote:
> This will match how PMU errors are reported at check_hw_exists()'s
> msr_fail label, which is reached when VPMU initialzation fails.
> 
> Signed-off-by: Boris Ostrovsky <boris.ostrovsky@oracle.com>

Acked-by: Juergen Gross <jgross@suse.com>

> ---
>  arch/x86/xen/pmu.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/x86/xen/pmu.c b/arch/x86/xen/pmu.c
> index 9466354..32bdc2c 100644
> --- a/arch/x86/xen/pmu.c
> +++ b/arch/x86/xen/pmu.c
> @@ -547,7 +547,7 @@ void xen_pmu_init(int cpu)
>  	return;
>  
>  fail:
> -	pr_warn_once("Could not initialize VPMU for cpu %d, error %d\n",
> +	pr_info_once("Could not initialize VPMU for cpu %d, error %d\n",
>  		cpu, err);
>  	free_pages((unsigned long)xenpmu_data, 0);
>  }
> 

WARNING: multiple messages have this Message-ID (diff)
From: Juergen Gross <jgross@suse.com>
To: Boris Ostrovsky <boris.ostrovsky@oracle.com>, david.vrabel@citrix.com
Cc: xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] xen/PMU: Log VPMU initialization error at lower level
Date: Tue, 21 Jun 2016 16:26:31 +0200	[thread overview]
Message-ID: <57694E97.3030604@suse.com> (raw)
In-Reply-To: <1466518653-25153-1-git-send-email-boris.ostrovsky@oracle.com>

On 21/06/16 16:17, Boris Ostrovsky wrote:
> This will match how PMU errors are reported at check_hw_exists()'s
> msr_fail label, which is reached when VPMU initialzation fails.
> 
> Signed-off-by: Boris Ostrovsky <boris.ostrovsky@oracle.com>

Acked-by: Juergen Gross <jgross@suse.com>

> ---
>  arch/x86/xen/pmu.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/x86/xen/pmu.c b/arch/x86/xen/pmu.c
> index 9466354..32bdc2c 100644
> --- a/arch/x86/xen/pmu.c
> +++ b/arch/x86/xen/pmu.c
> @@ -547,7 +547,7 @@ void xen_pmu_init(int cpu)
>  	return;
>  
>  fail:
> -	pr_warn_once("Could not initialize VPMU for cpu %d, error %d\n",
> +	pr_info_once("Could not initialize VPMU for cpu %d, error %d\n",
>  		cpu, err);
>  	free_pages((unsigned long)xenpmu_data, 0);
>  }
> 


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel

  parent reply	other threads:[~2016-06-21 14:44 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-06-21 14:17 [PATCH] xen/PMU: Log VPMU initialization error at lower level Boris Ostrovsky
2016-06-21 14:22 ` [Xen-devel] " Konrad Rzeszutek Wilk
2016-06-21 14:22   ` Konrad Rzeszutek Wilk
2016-06-21 14:26 ` Juergen Gross [this message]
2016-06-21 14:26   ` Juergen Gross
2016-06-21 15:19 ` [Xen-devel] " David Vrabel
2016-06-21 15:19 ` David Vrabel
  -- strict thread matches above, loose matches on Subject: below --
2016-06-21 14:17 Boris Ostrovsky

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=57694E97.3030604@suse.com \
    --to=jgross@suse.com \
    --cc=boris.ostrovsky@oracle.com \
    --cc=david.vrabel@citrix.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.