From: fixed-term.Oleksij.Rempel <fixed-term.Oleksij.Rempel@de.bosch.com>
To: Rob Herring <robh@kernel.org>, Dirk Behme <dirk.behme@de.bosch.com>
Cc: <rtc-linux@googlegroups.com>, <devicetree@vger.kernel.org>
Subject: [rtc-linux] Re: [PATCH 2/4] dt/bindings: Add bindings for Micro Crystal rv8803
Date: Wed, 22 Jun 2016 07:15:12 +0200 [thread overview]
Message-ID: <576A1EE0.4000603@de.bosch.com> (raw)
In-Reply-To: <20160621214836.GA10197@rob-hp-laptop>
On 21.06.2016 23:48, Rob Herring wrote:
> On Tue, Jun 21, 2016 at 08:57:18AM +0200, Dirk Behme wrote:
>> From: Oleksij Rempel <fixed-term.Oleksij.Rempel@de.bosch.com>
>>
>> ... and Epson RX8900 real time clock
>>
>> Signed-off-by: Oleksij Rempel <fixed-term.Oleksij.Rempel@de.bosch.com>
>> Cc: devicetree@vger.kernel.org
>> ---
>> .../devicetree/bindings/rtc/epson,rx8900.txt | 21 +++++++++++++++++++++
>> 1 file changed, 21 insertions(+)
>> create mode 100644 Documentation/devicetree/bindings/rtc/epson,rx8900.txt
>>
>> diff --git a/Documentation/devicetree/bindings/rtc/epson,rx8900.txt b/Documentation/devicetree/bindings/rtc/epson,rx8900.txt
>> new file mode 100644
>> index 0000000..51959de
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/rtc/epson,rx8900.txt
>> @@ -0,0 +1,21 @@
>> +Real Time Clock driver for:
>> + - Epson RX8900
>> + - Micro Crystal rv8803
>> +
>> +Required properties:
>> +- compatible: should be: "mc,rv8803" or "epson,rx8900"
>> +- reg : the I2C address of the device for I2C
>> +
>> +Optional properties:
>> +- epson,vdetoff : Disable Voltage Detector. Should be set if no
>> + backup battery is used.
>
> set to no? Looks like a boolean to me.
>
> How about epson,vdet-disable to be consistent.
>
>> +- trickle-diode-disable : Disable internal trickle charger diode
>
> boolean?
>
> Needs a vendor prefix.
This is common name used by many rtc driver without vendor prefix.
--
You received this message because you are subscribed to "rtc-linux".
Membership options at http://groups.google.com/group/rtc-linux .
Please read http://groups.google.com/group/rtc-linux/web/checklist
before submitting a driver.
---
You received this message because you are subscribed to the Google Groups "rtc-linux" group.
To unsubscribe from this group and stop receiving emails from it, send an email to rtc-linux+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
WARNING: multiple messages have this Message-ID (diff)
From: fixed-term.Oleksij.Rempel <fixed-term.Oleksij.Rempel-V5te9oGctAVWk0Htik3J/w@public.gmane.org>
To: Rob Herring <robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
Dirk Behme <dirk.behme-V5te9oGctAVWk0Htik3J/w@public.gmane.org>
Cc: rtc-linux-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH 2/4] dt/bindings: Add bindings for Micro Crystal rv8803
Date: Wed, 22 Jun 2016 07:15:12 +0200 [thread overview]
Message-ID: <576A1EE0.4000603@de.bosch.com> (raw)
In-Reply-To: <20160621214836.GA10197@rob-hp-laptop>
On 21.06.2016 23:48, Rob Herring wrote:
> On Tue, Jun 21, 2016 at 08:57:18AM +0200, Dirk Behme wrote:
>> From: Oleksij Rempel <fixed-term.Oleksij.Rempel-V5te9oGctAVWk0Htik3J/w@public.gmane.org>
>>
>> ... and Epson RX8900 real time clock
>>
>> Signed-off-by: Oleksij Rempel <fixed-term.Oleksij.Rempel-V5te9oGctAVWk0Htik3J/w@public.gmane.org>
>> Cc: devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
>> ---
>> .../devicetree/bindings/rtc/epson,rx8900.txt | 21 +++++++++++++++++++++
>> 1 file changed, 21 insertions(+)
>> create mode 100644 Documentation/devicetree/bindings/rtc/epson,rx8900.txt
>>
>> diff --git a/Documentation/devicetree/bindings/rtc/epson,rx8900.txt b/Documentation/devicetree/bindings/rtc/epson,rx8900.txt
>> new file mode 100644
>> index 0000000..51959de
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/rtc/epson,rx8900.txt
>> @@ -0,0 +1,21 @@
>> +Real Time Clock driver for:
>> + - Epson RX8900
>> + - Micro Crystal rv8803
>> +
>> +Required properties:
>> +- compatible: should be: "mc,rv8803" or "epson,rx8900"
>> +- reg : the I2C address of the device for I2C
>> +
>> +Optional properties:
>> +- epson,vdetoff : Disable Voltage Detector. Should be set if no
>> + backup battery is used.
>
> set to no? Looks like a boolean to me.
>
> How about epson,vdet-disable to be consistent.
>
>> +- trickle-diode-disable : Disable internal trickle charger diode
>
> boolean?
>
> Needs a vendor prefix.
This is common name used by many rtc driver without vendor prefix.
--
You received this message because you are subscribed to "rtc-linux".
Membership options at http://groups.google.com/group/rtc-linux .
Please read http://groups.google.com/group/rtc-linux/web/checklist
before submitting a driver.
---
You received this message because you are subscribed to the Google Groups "rtc-linux" group.
To unsubscribe from this group and stop receiving emails from it, send an email to rtc-linux+unsubscribe-/JYPxA39Uh5TLH3MbocFF+G/Ez6ZCGd0@public.gmane.org
For more options, visit https://groups.google.com/d/optout.
next prev parent reply other threads:[~2016-06-22 5:15 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-21 6:57 [rtc-linux] [PATCH 1/4] devicetree: Add Micro Crystal AG vendor id Dirk Behme
2016-06-21 6:57 ` Dirk Behme
2016-06-21 6:57 ` [rtc-linux] [PATCH 2/4] dt/bindings: Add bindings for Micro Crystal rv8803 Dirk Behme
2016-06-21 6:57 ` Dirk Behme
2016-06-21 21:48 ` [rtc-linux] " Rob Herring
2016-06-21 21:48 ` Rob Herring
2016-06-22 5:15 ` fixed-term.Oleksij.Rempel [this message]
2016-06-22 5:15 ` fixed-term.Oleksij.Rempel
2016-06-21 6:57 ` [rtc-linux] [PATCH 3/4] rtc: rv8803: add device tree compatible names Dirk Behme
2016-06-21 6:57 ` Dirk Behme
2016-06-21 6:57 ` [rtc-linux] [PATCH 4/4] rtc: rv8803: Be able to set VDETOFF and SWOFF via devcie tree Dirk Behme
2016-06-21 6:57 ` Dirk Behme
2016-06-21 21:45 ` [rtc-linux] Re: [PATCH 1/4] devicetree: Add Micro Crystal AG vendor id Rob Herring
2016-06-21 21:45 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=576A1EE0.4000603@de.bosch.com \
--to=fixed-term.oleksij.rempel@de.bosch.com \
--cc=devicetree@vger.kernel.org \
--cc=dirk.behme@de.bosch.com \
--cc=robh@kernel.org \
--cc=rtc-linux@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.