* [PATCH] coresight: document binding acronyms
@ 2016-06-21 18:41 ` Mathieu Poirier
0 siblings, 0 replies; 7+ messages in thread
From: Mathieu Poirier @ 2016-06-21 18:41 UTC (permalink / raw)
To: robh+dt, mark.rutland
Cc: linux-arm-kernel, devicetree, linux-kernel, sudeep.holla,
suzuki.poulose, olof
It can be hard for people not familiar with the CoreSight IP blocks
to make sense of the acronyms found in the current bindings. As such
this patch expands each acronym in the hope of providing a better
description of the IP block they represent.
Signed-off-by: Mathieu Poirier <mathieu.poirier@linaro.org>
---
.../devicetree/bindings/arm/coresight.txt | 32 ++++++++++++++++------
1 file changed, 24 insertions(+), 8 deletions(-)
diff --git a/Documentation/devicetree/bindings/arm/coresight.txt b/Documentation/devicetree/bindings/arm/coresight.txt
index 93147c0c8a0e..c73a7f773998 100644
--- a/Documentation/devicetree/bindings/arm/coresight.txt
+++ b/Documentation/devicetree/bindings/arm/coresight.txt
@@ -12,14 +12,30 @@ its hardware characteristcs.
* compatible: These have to be supplemented with "arm,primecell" as
drivers are using the AMBA bus interface. Possible values include:
- - "arm,coresight-etb10", "arm,primecell";
- - "arm,coresight-tpiu", "arm,primecell";
- - "arm,coresight-tmc", "arm,primecell";
- - "arm,coresight-funnel", "arm,primecell";
- - "arm,coresight-etm3x", "arm,primecell";
- - "arm,coresight-etm4x", "arm,primecell";
- - "qcom,coresight-replicator1x", "arm,primecell";
- - "arm,coresight-stm", "arm,primecell"; [1]
+ - Embedded Trace Buffer (version 1.0):
+ "arm,coresight-etb10", "arm,primecell";
+
+ - Trace Port Interface Unit:
+ "arm,coresight-tpiu", "arm,primecell";
+
+ - Trace Memory Controller (ETB, ETF, ETR):
+ "arm,coresight-tmc", "arm,primecell";
+
+ - Trace Funnel:
+ "arm,coresight-funnel", "arm,primecell";
+
+ - Embedded Trace Macrocell (version 3.x) and
+ Program Flow Trace Macrocell:
+ "arm,coresight-etm3x", "arm,primecell";
+
+ - Embedded Trace Macrocell (version 4.x):
+ "arm,coresight-etm4x", "arm,primecell";
+
+ - Qualcomm Configurable Replicator (version 1.x):
+ "qcom,coresight-replicator1x", "arm,primecell";
+
+ - System Trace Macrocell:
+ "arm,coresight-stm", "arm,primecell"; [1]
* reg: physical base address and length of the register
set(s) of the component.
--
2.7.4
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [PATCH] coresight: document binding acronyms
2016-06-21 18:41 ` Mathieu Poirier
@ 2016-06-22 9:10 ` Suzuki K Poulose
-1 siblings, 0 replies; 7+ messages in thread
From: Suzuki K Poulose @ 2016-06-22 9:10 UTC (permalink / raw)
To: linux-arm-kernel
On 21/06/16 19:41, Mathieu Poirier wrote:
> It can be hard for people not familiar with the CoreSight IP blocks
> to make sense of the acronyms found in the current bindings. As such
> this patch expands each acronym in the hope of providing a better
> description of the IP block they represent.
>
> Signed-off-by: Mathieu Poirier <mathieu.poirier@linaro.org>
Thanks for the update. One minor comment below.
> ---
> .../devicetree/bindings/arm/coresight.txt | 32 ++++++++++++++++------
> 1 file changed, 24 insertions(+), 8 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/arm/coresight.txt b/Documentation/devicetree/bindings/arm/coresight.txt
> index 93147c0c8a0e..c73a7f773998 100644
> --- a/Documentation/devicetree/bindings/arm/coresight.txt
> +++ b/Documentation/devicetree/bindings/arm/coresight.txt
> @@ -12,14 +12,30 @@ its hardware characteristcs.
>
> * compatible: These have to be supplemented with "arm,primecell" as
> drivers are using the AMBA bus interface. Possible values include:
> - - "arm,coresight-etb10", "arm,primecell";
> - - "arm,coresight-tpiu", "arm,primecell";
> - - "arm,coresight-tmc", "arm,primecell";
> - - "arm,coresight-funnel", "arm,primecell";
> - - "arm,coresight-etm3x", "arm,primecell";
> - - "arm,coresight-etm4x", "arm,primecell";
> - - "qcom,coresight-replicator1x", "arm,primecell";
> - - "arm,coresight-stm", "arm,primecell"; [1]
> + - Embedded Trace Buffer (version 1.0):
> + "arm,coresight-etb10", "arm,primecell";
> +
> + - Trace Port Interface Unit:
> + "arm,coresight-tpiu", "arm,primecell";
> +
> + - Trace Memory Controller (ETB, ETF, ETR):
> + "arm,coresight-tmc", "arm,primecell";
Is it worth an explicit mention about this, something like :
"We don't need special bindings for the mode (e.g, ETB, ETF or ETR) in
which the Coresight TMC is configured".
Either way, looks good to me.
Suzuki
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] coresight: document binding acronyms
@ 2016-06-22 9:10 ` Suzuki K Poulose
0 siblings, 0 replies; 7+ messages in thread
From: Suzuki K Poulose @ 2016-06-22 9:10 UTC (permalink / raw)
To: Mathieu Poirier, robh+dt, mark.rutland
Cc: linux-arm-kernel, devicetree, linux-kernel, sudeep.holla, olof
On 21/06/16 19:41, Mathieu Poirier wrote:
> It can be hard for people not familiar with the CoreSight IP blocks
> to make sense of the acronyms found in the current bindings. As such
> this patch expands each acronym in the hope of providing a better
> description of the IP block they represent.
>
> Signed-off-by: Mathieu Poirier <mathieu.poirier@linaro.org>
Thanks for the update. One minor comment below.
> ---
> .../devicetree/bindings/arm/coresight.txt | 32 ++++++++++++++++------
> 1 file changed, 24 insertions(+), 8 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/arm/coresight.txt b/Documentation/devicetree/bindings/arm/coresight.txt
> index 93147c0c8a0e..c73a7f773998 100644
> --- a/Documentation/devicetree/bindings/arm/coresight.txt
> +++ b/Documentation/devicetree/bindings/arm/coresight.txt
> @@ -12,14 +12,30 @@ its hardware characteristcs.
>
> * compatible: These have to be supplemented with "arm,primecell" as
> drivers are using the AMBA bus interface. Possible values include:
> - - "arm,coresight-etb10", "arm,primecell";
> - - "arm,coresight-tpiu", "arm,primecell";
> - - "arm,coresight-tmc", "arm,primecell";
> - - "arm,coresight-funnel", "arm,primecell";
> - - "arm,coresight-etm3x", "arm,primecell";
> - - "arm,coresight-etm4x", "arm,primecell";
> - - "qcom,coresight-replicator1x", "arm,primecell";
> - - "arm,coresight-stm", "arm,primecell"; [1]
> + - Embedded Trace Buffer (version 1.0):
> + "arm,coresight-etb10", "arm,primecell";
> +
> + - Trace Port Interface Unit:
> + "arm,coresight-tpiu", "arm,primecell";
> +
> + - Trace Memory Controller (ETB, ETF, ETR):
> + "arm,coresight-tmc", "arm,primecell";
Is it worth an explicit mention about this, something like :
"We don't need special bindings for the mode (e.g, ETB, ETF or ETR) in
which the Coresight TMC is configured".
Either way, looks good to me.
Suzuki
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH] coresight: document binding acronyms
2016-06-21 18:41 ` Mathieu Poirier
(?)
@ 2016-06-22 9:18 ` Sudeep Holla
-1 siblings, 0 replies; 7+ messages in thread
From: Sudeep Holla @ 2016-06-22 9:18 UTC (permalink / raw)
To: linux-arm-kernel
On 21/06/16 19:41, Mathieu Poirier wrote:
> It can be hard for people not familiar with the CoreSight IP blocks
> to make sense of the acronyms found in the current bindings. As such
> this patch expands each acronym in the hope of providing a better
> description of the IP block they represent.
>
Thanks for adding these info so quickly. Just a minor nit below.
> Signed-off-by: Mathieu Poirier <mathieu.poirier@linaro.org>
> ---
> .../devicetree/bindings/arm/coresight.txt | 32 ++++++++++++++++------
> 1 file changed, 24 insertions(+), 8 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/arm/coresight.txt b/Documentation/devicetree/bindings/arm/coresight.txt
> index 93147c0c8a0e..c73a7f773998 100644
> --- a/Documentation/devicetree/bindings/arm/coresight.txt
> +++ b/Documentation/devicetree/bindings/arm/coresight.txt
> @@ -12,14 +12,30 @@ its hardware characteristcs.
>
> * compatible: These have to be supplemented with "arm,primecell" as
> drivers are using the AMBA bus interface. Possible values include:
> - - "arm,coresight-etb10", "arm,primecell";
> - - "arm,coresight-tpiu", "arm,primecell";
> - - "arm,coresight-tmc", "arm,primecell";
> - - "arm,coresight-funnel", "arm,primecell";
> - - "arm,coresight-etm3x", "arm,primecell";
> - - "arm,coresight-etm4x", "arm,primecell";
> - - "qcom,coresight-replicator1x", "arm,primecell";
> - - "arm,coresight-stm", "arm,primecell"; [1]
> + - Embedded Trace Buffer (version 1.0):
> + "arm,coresight-etb10", "arm,primecell";
> +
> + - Trace Port Interface Unit:
> + "arm,coresight-tpiu", "arm,primecell";
> +
> + - Trace Memory Controller (ETB, ETF, ETR):
Only ETB is expanded in the list, does it make sense to expand ETF and
ETR too ?
--
Regards,
Sudeep
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] coresight: document binding acronyms
@ 2016-06-22 9:18 ` Sudeep Holla
0 siblings, 0 replies; 7+ messages in thread
From: Sudeep Holla @ 2016-06-22 9:18 UTC (permalink / raw)
To: Mathieu Poirier, robh+dt, mark.rutland
Cc: Sudeep Holla, linux-arm-kernel, devicetree, linux-kernel,
suzuki.poulose, olof
On 21/06/16 19:41, Mathieu Poirier wrote:
> It can be hard for people not familiar with the CoreSight IP blocks
> to make sense of the acronyms found in the current bindings. As such
> this patch expands each acronym in the hope of providing a better
> description of the IP block they represent.
>
Thanks for adding these info so quickly. Just a minor nit below.
> Signed-off-by: Mathieu Poirier <mathieu.poirier@linaro.org>
> ---
> .../devicetree/bindings/arm/coresight.txt | 32 ++++++++++++++++------
> 1 file changed, 24 insertions(+), 8 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/arm/coresight.txt b/Documentation/devicetree/bindings/arm/coresight.txt
> index 93147c0c8a0e..c73a7f773998 100644
> --- a/Documentation/devicetree/bindings/arm/coresight.txt
> +++ b/Documentation/devicetree/bindings/arm/coresight.txt
> @@ -12,14 +12,30 @@ its hardware characteristcs.
>
> * compatible: These have to be supplemented with "arm,primecell" as
> drivers are using the AMBA bus interface. Possible values include:
> - - "arm,coresight-etb10", "arm,primecell";
> - - "arm,coresight-tpiu", "arm,primecell";
> - - "arm,coresight-tmc", "arm,primecell";
> - - "arm,coresight-funnel", "arm,primecell";
> - - "arm,coresight-etm3x", "arm,primecell";
> - - "arm,coresight-etm4x", "arm,primecell";
> - - "qcom,coresight-replicator1x", "arm,primecell";
> - - "arm,coresight-stm", "arm,primecell"; [1]
> + - Embedded Trace Buffer (version 1.0):
> + "arm,coresight-etb10", "arm,primecell";
> +
> + - Trace Port Interface Unit:
> + "arm,coresight-tpiu", "arm,primecell";
> +
> + - Trace Memory Controller (ETB, ETF, ETR):
Only ETB is expanded in the list, does it make sense to expand ETF and
ETR too ?
--
Regards,
Sudeep
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] coresight: document binding acronyms
@ 2016-06-22 9:18 ` Sudeep Holla
0 siblings, 0 replies; 7+ messages in thread
From: Sudeep Holla @ 2016-06-22 9:18 UTC (permalink / raw)
To: Mathieu Poirier, robh+dt, mark.rutland
Cc: devicetree, suzuki.poulose, linux-kernel, Sudeep Holla, olof,
linux-arm-kernel
On 21/06/16 19:41, Mathieu Poirier wrote:
> It can be hard for people not familiar with the CoreSight IP blocks
> to make sense of the acronyms found in the current bindings. As such
> this patch expands each acronym in the hope of providing a better
> description of the IP block they represent.
>
Thanks for adding these info so quickly. Just a minor nit below.
> Signed-off-by: Mathieu Poirier <mathieu.poirier@linaro.org>
> ---
> .../devicetree/bindings/arm/coresight.txt | 32 ++++++++++++++++------
> 1 file changed, 24 insertions(+), 8 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/arm/coresight.txt b/Documentation/devicetree/bindings/arm/coresight.txt
> index 93147c0c8a0e..c73a7f773998 100644
> --- a/Documentation/devicetree/bindings/arm/coresight.txt
> +++ b/Documentation/devicetree/bindings/arm/coresight.txt
> @@ -12,14 +12,30 @@ its hardware characteristcs.
>
> * compatible: These have to be supplemented with "arm,primecell" as
> drivers are using the AMBA bus interface. Possible values include:
> - - "arm,coresight-etb10", "arm,primecell";
> - - "arm,coresight-tpiu", "arm,primecell";
> - - "arm,coresight-tmc", "arm,primecell";
> - - "arm,coresight-funnel", "arm,primecell";
> - - "arm,coresight-etm3x", "arm,primecell";
> - - "arm,coresight-etm4x", "arm,primecell";
> - - "qcom,coresight-replicator1x", "arm,primecell";
> - - "arm,coresight-stm", "arm,primecell"; [1]
> + - Embedded Trace Buffer (version 1.0):
> + "arm,coresight-etb10", "arm,primecell";
> +
> + - Trace Port Interface Unit:
> + "arm,coresight-tpiu", "arm,primecell";
> +
> + - Trace Memory Controller (ETB, ETF, ETR):
Only ETB is expanded in the list, does it make sense to expand ETF and
ETR too ?
--
Regards,
Sudeep
^ permalink raw reply [flat|nested] 7+ messages in thread