From: Keerthy <a0393675@ti.com>
To: Mark Brown <broonie@kernel.org>
Cc: Keerthy <j-keerthy@ti.com>,
tony@atomide.com, devicetree@vger.kernel.org,
linux-omap@vger.kernel.org, linux-kernel@vger.kernel.org,
t-kristo@ti.com, russ.dill@ti.com, robh+dt@kernel.org,
mark.rutland@arm.com, linux@armlinux.org.uk
Subject: Re: [PATCH 1/9] regulator: tps65217: Enable suspend configuration
Date: Wed, 22 Jun 2016 15:56:33 +0530 [thread overview]
Message-ID: <576A67D9.6080707@ti.com> (raw)
In-Reply-To: <20160622101611.GI28202@sirena.org.uk>
On Wednesday 22 June 2016 03:46 PM, Mark Brown wrote:
> On Wed, Jun 22, 2016 at 03:44:02PM +0530, Keerthy wrote:
>
>> Hence saving it in a static array and using it later in the ops functions to
>> disable or enable regulator during suspend.
>
> Why a static array and not part of the dynamically allocated driver
> data?
Okay. That can be done.
I can introduce another integer pointer to struct tps65217 which
currently holds the driver data.
I will allocate memory for TPS65217_NUM_REGULATOR strobes during
regulator probe. Is this approach okay?
>
WARNING: multiple messages have this Message-ID (diff)
From: Keerthy <a0393675@ti.com>
To: Mark Brown <broonie@kernel.org>
Cc: Keerthy <j-keerthy@ti.com>, <tony@atomide.com>,
<devicetree@vger.kernel.org>, <linux-omap@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, <t-kristo@ti.com>,
<russ.dill@ti.com>, <robh+dt@kernel.org>, <mark.rutland@arm.com>,
<linux@armlinux.org.uk>
Subject: Re: [PATCH 1/9] regulator: tps65217: Enable suspend configuration
Date: Wed, 22 Jun 2016 15:56:33 +0530 [thread overview]
Message-ID: <576A67D9.6080707@ti.com> (raw)
In-Reply-To: <20160622101611.GI28202@sirena.org.uk>
On Wednesday 22 June 2016 03:46 PM, Mark Brown wrote:
> On Wed, Jun 22, 2016 at 03:44:02PM +0530, Keerthy wrote:
>
>> Hence saving it in a static array and using it later in the ops functions to
>> disable or enable regulator during suspend.
>
> Why a static array and not part of the dynamically allocated driver
> data?
Okay. That can be done.
I can introduce another integer pointer to struct tps65217 which
currently holds the driver data.
I will allocate memory for TPS65217_NUM_REGULATOR strobes during
regulator probe. Is this approach okay?
>
next prev parent reply other threads:[~2016-06-22 10:26 UTC|newest]
Thread overview: 69+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-20 8:43 [PATCH 0/9] regulator: Enable suspend configuration Keerthy
2016-06-20 8:43 ` Keerthy
2016-06-20 8:43 ` [PATCH 1/9] regulator: tps65217: " Keerthy
2016-06-20 8:43 ` Keerthy
2016-06-21 19:08 ` Mark Brown
2016-06-22 10:14 ` Keerthy
2016-06-22 10:14 ` Keerthy
[not found] ` <576A64EA.4000607-l0cyMroinI0@public.gmane.org>
2016-06-22 10:16 ` Mark Brown
2016-06-22 10:16 ` Mark Brown
2016-06-22 10:26 ` Keerthy [this message]
2016-06-22 10:26 ` Keerthy
[not found] ` <576A67D9.6080707-l0cyMroinI0@public.gmane.org>
2016-06-23 10:26 ` Mark Brown
2016-06-23 10:26 ` Mark Brown
[not found] ` <20160623102634.GX28202-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2016-06-23 10:32 ` Keerthy
2016-06-23 10:32 ` Keerthy
2016-06-20 8:43 ` [PATCH 2/9] regulator: of: setup initial suspend state Keerthy
2016-06-20 8:43 ` Keerthy
[not found] ` <1466412218-5906-3-git-send-email-j-keerthy-l0cyMroinI0@public.gmane.org>
2016-06-22 15:29 ` Applied "regulator: of: setup initial suspend state" to the regulator tree Mark Brown
2016-06-22 15:29 ` Mark Brown
2016-06-20 8:43 ` [PATCH 3/9] regulator: tps65218: Enable suspend configuration Keerthy
2016-06-20 8:43 ` Keerthy
2016-06-27 17:00 ` Applied "regulator: tps65218: Enable suspend configuration" to the regulator tree Mark Brown
2016-06-27 17:00 ` Mark Brown
2016-06-20 8:43 ` [PATCH 4/9] ARM: dts: AM437X-GP-EVM: AM437X-SK-EVM: Make dcdc3 dcdc5 and dcdc6 enable during suspend Keerthy
2016-06-20 8:43 ` Keerthy
[not found] ` <1466412218-5906-5-git-send-email-j-keerthy-l0cyMroinI0@public.gmane.org>
2016-06-21 11:43 ` Tony Lindgren
2016-06-21 11:43 ` Tony Lindgren
2016-06-21 11:46 ` Tony Lindgren
2016-06-20 8:43 ` [PATCH 5/9] regulator: tps65218: force set power-up/down strobe to 3 for dcdc3 Keerthy
2016-06-20 8:43 ` Keerthy
2016-06-27 17:00 ` Applied "regulator: tps65218: force set power-up/down strobe to 3 for dcdc3" to the regulator tree Mark Brown
2016-06-27 17:00 ` Mark Brown
2016-06-20 8:43 ` [PATCH 6/9] ARM: dts: am437x-gp-evm: disable DDR regulator in rtc-only/poweroff mode Keerthy
2016-06-20 8:43 ` Keerthy
2016-06-20 8:43 ` [PATCH 7/9] mfd: tps65218: add version check to the PMIC probe Keerthy
2016-06-20 8:43 ` Keerthy
2016-06-20 8:45 ` Keerthy
2016-06-20 8:45 ` Keerthy
2016-08-10 20:04 ` Applied "mfd: tps65218: add version check to the PMIC probe" to the regulator tree Mark Brown
2016-08-10 20:04 ` Mark Brown
2016-08-31 8:31 ` Lee Jones
2016-08-31 11:41 ` Mark Brown
2016-08-31 11:41 ` Mark Brown
[not found] ` <20160831114105.GH3950-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2016-08-31 14:50 ` Lee Jones
2016-08-31 14:50 ` Lee Jones
2016-08-31 16:02 ` Mark Brown
2016-08-31 16:02 ` Mark Brown
[not found] ` <20160831160227.GC5967-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2016-09-01 8:23 ` Lee Jones
2016-09-01 8:23 ` Lee Jones
2016-09-01 8:54 ` Mark Brown
2016-09-01 9:34 ` Lee Jones
2016-08-31 17:57 ` Russell King - ARM Linux
2016-08-31 17:57 ` Russell King - ARM Linux
2016-09-01 8:18 ` Lee Jones
2016-09-01 10:17 ` Russell King - ARM Linux
2016-09-01 10:17 ` Russell King - ARM Linux
[not found] ` <20160901101743.GB5783-l+eeeJia6m9vn6HldHNs0ANdhmdF6hFW@public.gmane.org>
2016-09-01 11:19 ` Lee Jones
2016-09-01 11:19 ` Lee Jones
2016-09-01 14:23 ` Russell King - ARM Linux
2016-09-01 14:53 ` Lee Jones
2016-06-20 8:43 ` [PATCH 8/9] regulator: tps65218: do not disable DCDC3 during poweroff on broken PMICs Keerthy
2016-06-20 8:43 ` Keerthy
2016-08-10 20:04 ` Applied "regulator: tps65218: do not disable DCDC3 during poweroff on broken PMICs" to the regulator tree Mark Brown
2016-08-10 20:04 ` Mark Brown
2016-08-31 15:01 ` Lee Jones
2016-08-31 15:01 ` Lee Jones
2016-09-01 10:06 ` Mark Brown
2016-06-20 8:43 ` [PATCH 9/9] ARM: dts: am437x-sk-evm: disable DDR regulator in rtc-only/poweroff mode Keerthy
2016-06-20 8:43 ` Keerthy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=576A67D9.6080707@ti.com \
--to=a0393675@ti.com \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=j-keerthy@ti.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
--cc=russ.dill@ti.com \
--cc=t-kristo@ti.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.