From: Krzysztof Kozlowski <k.kozlowski@samsung.com>
To: Ben Dooks <ben.dooks@codethink.co.uk>,
linux-kernel@lists.codethink.co.uk
Cc: linux-samsung-soc@vger.kernel.org, Kukjin Kim <kgene@kernel.org>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] ARM: Samsung: fix missing s5p_init_cpu() declaration
Date: Wed, 22 Jun 2016 12:33:31 +0200 [thread overview]
Message-ID: <576A697B.10204@samsung.com> (raw)
In-Reply-To: <1466511653-9295-1-git-send-email-ben.dooks@codethink.co.uk>
On 06/21/2016 02:20 PM, Ben Dooks wrote:
> The declaration of s5p_init_cpu() in arch/arm/mach-exynos/common.h
> is not included in the platform file arch/arm/plat-samsung/cpu.c
> which generates a warning.
>
> Fix the following warning by moving the declaration to somewhere
> both the machine and platform code can get to it, and including
> the right files as necessary:
>
> arch/arm/plat-samsung/cpu.c:47:13: warning: symbol 's5p_init_cpu' was not declared. Should it be static?
>
> Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk>
> ---
> Cc: Kukjin Kim <kgene@kernel.org>
> Cc: Krzysztof Kozlowski <k.kozlowski@samsung.com>
> Cc: linux-samsung-soc@vger.kernel.org
> Cc: linux-arm-kernel@lists.infradead.org
> ---
> arch/arm/mach-exynos/common.h | 1 -
> arch/arm/mach-exynos/exynos.c | 1 +
> arch/arm/plat-samsung/include/plat/cpu.h | 1 +
> 3 files changed, 2 insertions(+), 1 deletion(-)
Thanks, applied for v4.8.
Best regards,
Krzysztof
WARNING: multiple messages have this Message-ID (diff)
From: k.kozlowski@samsung.com (Krzysztof Kozlowski)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: Samsung: fix missing s5p_init_cpu() declaration
Date: Wed, 22 Jun 2016 12:33:31 +0200 [thread overview]
Message-ID: <576A697B.10204@samsung.com> (raw)
In-Reply-To: <1466511653-9295-1-git-send-email-ben.dooks@codethink.co.uk>
On 06/21/2016 02:20 PM, Ben Dooks wrote:
> The declaration of s5p_init_cpu() in arch/arm/mach-exynos/common.h
> is not included in the platform file arch/arm/plat-samsung/cpu.c
> which generates a warning.
>
> Fix the following warning by moving the declaration to somewhere
> both the machine and platform code can get to it, and including
> the right files as necessary:
>
> arch/arm/plat-samsung/cpu.c:47:13: warning: symbol 's5p_init_cpu' was not declared. Should it be static?
>
> Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk>
> ---
> Cc: Kukjin Kim <kgene@kernel.org>
> Cc: Krzysztof Kozlowski <k.kozlowski@samsung.com>
> Cc: linux-samsung-soc at vger.kernel.org
> Cc: linux-arm-kernel at lists.infradead.org
> ---
> arch/arm/mach-exynos/common.h | 1 -
> arch/arm/mach-exynos/exynos.c | 1 +
> arch/arm/plat-samsung/include/plat/cpu.h | 1 +
> 3 files changed, 2 insertions(+), 1 deletion(-)
Thanks, applied for v4.8.
Best regards,
Krzysztof
next prev parent reply other threads:[~2016-06-22 10:33 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-21 12:20 [PATCH] ARM: Samsung: fix missing s5p_init_cpu() declaration Ben Dooks
2016-06-21 12:20 ` Ben Dooks
2016-06-22 10:33 ` Krzysztof Kozlowski [this message]
2016-06-22 10:33 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=576A697B.10204@samsung.com \
--to=k.kozlowski@samsung.com \
--cc=ben.dooks@codethink.co.uk \
--cc=kgene@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@lists.codethink.co.uk \
--cc=linux-samsung-soc@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.