Re: [Qemu-devel] [PATCH 1/3] ich9: call ich9_lpc_update_pic for disabled pirqs

["Ефимов Василий" <real@ispras.ru>]

20.06.2016 17:39, Paolo Bonzini wrote:
> An asserted pirq can be disabled and the corresponding GSIs
> should then go down to 0.  However, because of the conditional in
> ich9_lpc_update_by_pirq, the legacy 8259 pin could remain stuck to 1.
>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
>   hw/isa/lpc_ich9.c | 3 ---
>   1 file changed, 3 deletions(-)
>
> diff --git a/hw/isa/lpc_ich9.c b/hw/isa/lpc_ich9.c
> index 213741b..b116e1b 100644
> --- a/hw/isa/lpc_ich9.c
> +++ b/hw/isa/lpc_ich9.c
> @@ -234,9 +234,6 @@ static void ich9_lpc_update_by_pirq(ICH9LPCState *lpc, int pirq)
>
>       ich9_lpc_pic_irq(lpc, pirq, &pic_irq, &pic_dis);
>       assert(pic_irq < ICH9_LPC_PIC_NUM_PINS);
> -    if (pic_dis) {
> -        return;
> -    }
>
>       ich9_lpc_update_pic(lpc, pic_irq);
>   }
>
Reviewed-by: Efimov Vasily <real@ispras.ru>