All of lore.kernel.org
 help / color / mirror / Atom feed
From: Richard Weinberger <richard@nod.at>
To: "Jörg Pfähler" <pfaehler@isse.de>
Cc: linux-mtd@lists.infradead.org, dedekind1@gmail.com,
	stable@vger.kernel.org
Subject: Re: [PATCH v2] ubi: Make recover_peb power cut aware
Date: Wed, 22 Jun 2016 22:04:32 +0200	[thread overview]
Message-ID: <576AEF50.2090704@nod.at> (raw)
In-Reply-To: <2124396.xJgUrQUc0H@pfaehler-pc>

Am 22.06.2016 um 16:44 schrieb Jörg Pfähler:
> Reviewed-by: Jörg Pfähler <pfaehler@isse.de>
> 
> Am Dienstag, 21. Juni 2016, 00:31:50 CEST schrieb Richard Weinberger:
>> recover_peb() was never power cut aware,
>> if a power cut happened right after writing the VID header
>> upon next attach UBI would blindly use the new partial written
>> PEB and all data from the old PEB is lost.
>>
>> In order to make recover_peb() power cut aware, write the new
>> VID with a proper crc and copy_flag set such that the UBI attach
>> process will detect whether the new PEB is completely written
>> or not.
>> We cannot directly use ubi_eba_atomic_leb_change() since we'd
>> have to unlock the LEB which is facing a write error.
>>
>> Cc: stable@vger.kernel.org
>> Reported-by: Jörg Pfähler <pfaehler@isse.de>
>> Signed-off-by: Richard Weinberger <richard@nod.at>

Applied and pushed into linux-next.

Thanks,
//richard

WARNING: multiple messages have this Message-ID (diff)
From: Richard Weinberger <richard@nod.at>
To: "Jörg Pfähler" <pfaehler@isse.de>
Cc: linux-mtd@lists.infradead.org, dedekind1@gmail.com,
	stable@vger.kernel.org
Subject: Re: [PATCH v2] ubi: Make recover_peb power cut aware
Date: Wed, 22 Jun 2016 22:04:32 +0200	[thread overview]
Message-ID: <576AEF50.2090704@nod.at> (raw)
In-Reply-To: <2124396.xJgUrQUc0H@pfaehler-pc>

Am 22.06.2016 um 16:44 schrieb J�rg Pf�hler:
> Reviewed-by: J�rg Pf�hler <pfaehler@isse.de>
> 
> Am Dienstag, 21. Juni 2016, 00:31:50 CEST schrieb Richard Weinberger:
>> recover_peb() was never power cut aware,
>> if a power cut happened right after writing the VID header
>> upon next attach UBI would blindly use the new partial written
>> PEB and all data from the old PEB is lost.
>>
>> In order to make recover_peb() power cut aware, write the new
>> VID with a proper crc and copy_flag set such that the UBI attach
>> process will detect whether the new PEB is completely written
>> or not.
>> We cannot directly use ubi_eba_atomic_leb_change() since we'd
>> have to unlock the LEB which is facing a write error.
>>
>> Cc: stable@vger.kernel.org
>> Reported-by: J�rg Pf�hler <pfaehler@isse.de>
>> Signed-off-by: Richard Weinberger <richard@nod.at>

Applied and pushed into linux-next.

Thanks,
//richard

  reply	other threads:[~2016-06-22 20:04 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-06-20 22:31 [PATCH v2] ubi: Make recover_peb power cut aware Richard Weinberger
2016-06-22 14:44 ` Jörg Pfähler
2016-06-22 14:44   ` Jörg Pfähler
2016-06-22 20:04   ` Richard Weinberger [this message]
2016-06-22 20:04     ` Richard Weinberger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=576AEF50.2090704@nod.at \
    --to=richard@nod.at \
    --cc=dedekind1@gmail.com \
    --cc=linux-mtd@lists.infradead.org \
    --cc=pfaehler@isse.de \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.