All of lore.kernel.org
 help / color / mirror / Atom feed
From: sagi@grimberg.me (Sagi Grimberg)
Subject: [PATCH 0/2] Get rid of transport layer retry count config parameter
Date: Thu, 23 Jun 2016 10:09:36 +0300	[thread overview]
Message-ID: <576B8B30.8080402@grimberg.me> (raw)
In-Reply-To: <20160622203110.GA20838@obsidianresearch.com>


>>> This parameter was added in order to support a proper timeout for
>>> error recovery before the spec defined a periodic keep-alive.
>>>
>>> Now that we have periodic keep-alive, we don't need a user configurable
>>> transport layer retry count, the keep-alive timeout is sufficient,
>>> transports can retry for as long as they see fit.
>>
>> Isn't there some IB protocol level rationale for a low retry count
>> in various fabric setups?
>
> IIRC the retry count is part of what drives the APM switch over, so
> APM configuration should use a lower value.

Completely agree Jason. Lowering the retry_count is very useful
for APM (Automatic Path Migration).

WARNING: multiple messages have this Message-ID (diff)
From: Sagi Grimberg <sagi-NQWnxTmZq1alnMjI0IkVqw@public.gmane.org>
To: Jason Gunthorpe
	<jgunthorpe-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>,
	Christoph Hellwig <hch-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>
Cc: linux-nvme-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
	linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH 0/2] Get rid of transport layer retry count config parameter
Date: Thu, 23 Jun 2016 10:09:36 +0300	[thread overview]
Message-ID: <576B8B30.8080402@grimberg.me> (raw)
In-Reply-To: <20160622203110.GA20838-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>


>>> This parameter was added in order to support a proper timeout for
>>> error recovery before the spec defined a periodic keep-alive.
>>>
>>> Now that we have periodic keep-alive, we don't need a user configurable
>>> transport layer retry count, the keep-alive timeout is sufficient,
>>> transports can retry for as long as they see fit.
>>
>> Isn't there some IB protocol level rationale for a low retry count
>> in various fabric setups?
>
> IIRC the retry count is part of what drives the APM switch over, so
> APM configuration should use a lower value.

Completely agree Jason. Lowering the retry_count is very useful
for APM (Automatic Path Migration).
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

  reply	other threads:[~2016-06-23  7:09 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-06-22 12:05 [PATCH 0/2] Get rid of transport layer retry count config parameter Sagi Grimberg
2016-06-22 12:06 ` [PATCH 1/2] nvme-rdma: Don't use tl_retry_count Sagi Grimberg
2016-06-22 12:06 ` [PATCH 2/2] nvme-fabrics: Remove tl_retry_count Sagi Grimberg
2016-06-22 16:15 ` [PATCH 0/2] Get rid of transport layer retry count config parameter Christoph Hellwig
2016-06-22 16:15   ` Christoph Hellwig
2016-06-22 16:31   ` Sagi Grimberg
2016-06-22 16:31     ` Sagi Grimberg
2016-06-22 20:31   ` Jason Gunthorpe
2016-06-22 20:31     ` Jason Gunthorpe
2016-06-23  7:09     ` Sagi Grimberg [this message]
2016-06-23  7:09       ` Sagi Grimberg
2016-06-24  7:13       ` Christoph Hellwig
2016-06-24  7:13         ` Christoph Hellwig
2016-06-26 15:48         ` Sagi Grimberg
2016-06-26 15:48           ` Sagi Grimberg
2016-07-17 11:52         ` Sagi Grimberg
2016-07-17 11:52           ` Sagi Grimberg
2016-07-18  4:09           ` Christoph Hellwig
2016-07-18  4:09             ` Christoph Hellwig
2016-07-18  4:09             ` Christoph Hellwig
2016-07-18  4:09               ` Christoph Hellwig
2016-07-18  8:01               ` Sagi Grimberg
2016-07-18  8:01                 ` Sagi Grimberg
2016-07-18 15:20   ` Bart Van Assche
2016-07-18 15:20     ` Bart Van Assche
2016-07-20  8:42     ` Sagi Grimberg
2016-07-20  8:42       ` Sagi Grimberg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=576B8B30.8080402@grimberg.me \
    --to=sagi@grimberg.me \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.