From: David Vrabel <david.vrabel@citrix.com>
To: Andrey Grodzovsky <andrey2805@gmail.com>,
<xen-devel@lists.xenproject.org>
Cc: <jw@quattru.com>, <stable@vger.kernel.org>,
<david.vrabel@citrix.com>, "Jan Beulich" <JBeulich@suse.com>,
Boris Ostrovsky <boris.ostrovsky@oracle.com>
Subject: Re: [Xen-devel] [PATCH] xen/pciback: Fix conf_space read/write overlap check.
Date: Thu, 23 Jun 2016 10:56:09 +0100 [thread overview]
Message-ID: <576BB239.2010008@citrix.com> (raw)
In-Reply-To: <1466533596-15122-1-git-send-email-andrey2805@gmail.com>
On 21/06/16 19:26, Andrey Grodzovsky wrote:
> Current overlap check is evaluating to false a case where a filter field
> is fully contained (proper subset) of a r/w request.
> This change applies classical overlap check instead to include
> all the scenarios.
>
> More specifically, for (Hilscher GmbH CIFX 50E-DP(M/S)) device
> driver the logic is such that the entire confspace is read and
> written in 4 byte chunks.In this case as an example, CACHE_LINE_SIZE,
> LATENCY_TIMER and PCI_BIST are arriving together in one call to
> xen_pcibk_config_write with offset == 0xc and size == 4.
> With the exsisting overlap check LATENCY_TIMER field
> (offset == 0xd, length == 1) is fully contained in the write request
> and hence is excluded from write, which is incorrect.
Applied to for-linus-4.7b, thanks.
David
next prev parent reply other threads:[~2016-06-23 9:56 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-21 18:26 [PATCH] xen/pciback: Fix conf_space read/write overlap check Andrey Grodzovsky
2016-06-22 6:49 ` Jan Beulich
2016-06-22 6:49 ` Jan Beulich
2016-06-23 9:56 ` David Vrabel [this message]
2016-06-23 9:56 ` David Vrabel
-- strict thread matches above, loose matches on Subject: below --
2016-06-21 14:37 Andrey Grodzovsky
2016-06-21 17:15 ` [Xen-devel] " David Vrabel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=576BB239.2010008@citrix.com \
--to=david.vrabel@citrix.com \
--cc=JBeulich@suse.com \
--cc=andrey2805@gmail.com \
--cc=boris.ostrovsky@oracle.com \
--cc=jw@quattru.com \
--cc=stable@vger.kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.