[PATCH] aspeed/ast-g5: Simplify default bootargs

[PATCH] aspeed/ast-g5: Simplify default bootargs

[Rick Altherr]

From: Xo Wang <xow@google.com>

New arguments set default console for DEBUG_UART on the EVB and allow
the kernel to choose init path, root/overlay, and memory size.

Change-Id: I919f7e4027968ad000c4283f8bd80cca1b17e2eb
Signed-off-by: Xo Wang <xow@google.com>
Signed-off-by: Rick Altherr <raltherr@google.com>
---
 include/configs/ast-g5.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/include/configs/ast-g5.h b/include/configs/ast-g5.h
index 6c05e6d..149cac8 100644
--- a/include/configs/ast-g5.h
+++ b/include/configs/ast-g5.h
@@ -139,7 +139,7 @@
 
 #define CONFIG_SYS_LOAD_ADDR		0x83000000	/* default load address */
 
-#define CONFIG_BOOTARGS		"console=ttyS0,115200n8 ramdisk_size=16384 root=/dev/ram rw init=/linuxrc mem=80M"
+#define CONFIG_BOOTARGS		"console=ttyS4,115200 earlyprintk"
 
 /* ------------------------------------------------------------------------- */
 
-- 
2.8.0.rc3.226.g39d4020

Re: [PATCH] aspeed/ast-g5: Simplify default bootargs

[Joel Stanley]

On Wed, Jun 15, 2016 at 5:20 AM, Rick Altherr <raltherr@google.com> wrote:
> From: Xo Wang <xow@google.com>
>
> New arguments set default console for DEBUG_UART on the EVB and allow
> the kernel to choose init path, root/overlay, and memory size.
>
> Change-Id: I919f7e4027968ad000c4283f8bd80cca1b17e2eb

I normally ask submissions to not include links to internal bugzillas
when submitting patches. Do you think that's a reasonable rule for
gerrit tags as well?

> Signed-off-by: Xo Wang <xow@google.com>
> Signed-off-by: Rick Altherr <raltherr@google.com>
> ---
>  include/configs/ast-g5.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/configs/ast-g5.h b/include/configs/ast-g5.h
> index 6c05e6d..149cac8 100644
> --- a/include/configs/ast-g5.h
> +++ b/include/configs/ast-g5.h
> @@ -139,7 +139,7 @@
>
>  #define CONFIG_SYS_LOAD_ADDR           0x83000000      /* default load address */
>
> -#define CONFIG_BOOTARGS                "console=ttyS0,115200n8 ramdisk_size=16384 root=/dev/ram rw init=/linuxrc mem=80M"
> +#define CONFIG_BOOTARGS                "console=ttyS4,115200 earlyprintk"

The change looks good.

As you mentioned on IRC, we should create an ast2500-evb configuration
in the future.

Cheers,

Joel

Re: [PATCH] aspeed/ast-g5: Simplify default bootargs

[Patrick Williams]

[-- Attachment #1: Type: text/plain, Size: 621 bytes --]

On Wed, Jun 15, 2016 at 01:49:12PM +1000, Joel Stanley wrote:
> > New arguments set default console for DEBUG_UART on the EVB and allow
> > the kernel to choose init path, root/overlay, and memory size.
> >
> > Change-Id: I919f7e4027968ad000c4283f8bd80cca1b17e2eb
> 
> I normally ask submissions to not include links to internal bugzillas
> when submitting patches. Do you think that's a reasonable rule for
> gerrit tags as well?
> 

I don't have a preference personally, but...

Neither upstream Linux kernel nor u-boot trees seem to require Gerrit
Change-Id tags to be removed.

-- 
Patrick Williams

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

Re: [PATCH] aspeed/ast-g5: Simplify default bootargs

[Milton Miller II]

[-- Attachment #1: Type: text/html, Size: 1778 bytes --]

Re: [PATCH] aspeed/ast-g5: Simplify default bootargs

[Rick Altherr]

[-- Attachment #1: Type: text/plain, Size: 1592 bytes --]

I had intended to remove the Change-Id tag but the gerrit hooks in a git
repo seem to run deep.  I believe Xo sent a PR with the same patch.  I
prefer to drop my patch and follow up on his.

On Tue, Jun 14, 2016 at 8:49 PM, Joel Stanley <joel@jms.id.au> wrote:

> On Wed, Jun 15, 2016 at 5:20 AM, Rick Altherr <raltherr@google.com> wrote:
> > From: Xo Wang <xow@google.com>
> >
> > New arguments set default console for DEBUG_UART on the EVB and allow
> > the kernel to choose init path, root/overlay, and memory size.
> >
> > Change-Id: I919f7e4027968ad000c4283f8bd80cca1b17e2eb
>
> I normally ask submissions to not include links to internal bugzillas
> when submitting patches. Do you think that's a reasonable rule for
> gerrit tags as well?
>
> > Signed-off-by: Xo Wang <xow@google.com>
> > Signed-off-by: Rick Altherr <raltherr@google.com>
> > ---
> >  include/configs/ast-g5.h | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/include/configs/ast-g5.h b/include/configs/ast-g5.h
> > index 6c05e6d..149cac8 100644
> > --- a/include/configs/ast-g5.h
> > +++ b/include/configs/ast-g5.h
> > @@ -139,7 +139,7 @@
> >
> >  #define CONFIG_SYS_LOAD_ADDR           0x83000000      /* default load
> address */
> >
> > -#define CONFIG_BOOTARGS                "console=ttyS0,115200n8
> ramdisk_size=16384 root=/dev/ram rw init=/linuxrc mem=80M"
> > +#define CONFIG_BOOTARGS                "console=ttyS4,115200
> earlyprintk"
>
> The change looks good.
>
> As you mentioned on IRC, we should create an ast2500-evb configuration
> in the future.
>
> Cheers,
>
> Joel
>

[-- Attachment #2: Type: text/html, Size: 2332 bytes --]

Re: [PATCH] aspeed/ast-g5: Simplify default bootargs

[Xo Wang]

 > I believe Xo sent a PR with the same patch.  I
 > prefer to drop my patch and follow up on his.

Joel et al had included a bootargs change in their new unified U-Boot 
branch so I dropped my PR too.

cheers
//xo

Re: [PATCH] aspeed/ast-g5: Simplify default bootargs

[Joel Stanley]

Hey Xo and Rick,

On Fri, Jun 24, 2016 at 3:33 AM, Xo Wang <xow@google.com> wrote:
>> I believe Xo sent a PR with the same patch.  I
>> prefer to drop my patch and follow up on his.
>
> Joel et al had included a bootargs change in their new unified U-Boot branch
> so I dropped my PR too.

I applied your patch and then I think it got squished into a larger commit.

Thanks for sending it in. We should have sane bootargs for all of our
systems now.

Cheers,

Joel