* [Cocci] [PATCH] Coccinelle: Add misc/boolconv.cocci
@ 2016-06-23 18:53 ` Andrew F. Davis
0 siblings, 0 replies; 8+ messages in thread
From: Andrew F. Davis @ 2016-06-23 18:53 UTC (permalink / raw)
To: cocci
Add a script to check for unneeded conversions to bool.
Signed-off-by: Andrew F. Davis <afd@ti.com>
---
scripts/coccinelle/misc/boolconv.cocci | 90 ++++++++++++++++++++++++++++++++++
1 file changed, 90 insertions(+)
create mode 100644 scripts/coccinelle/misc/boolconv.cocci
diff --git a/scripts/coccinelle/misc/boolconv.cocci b/scripts/coccinelle/misc/boolconv.cocci
new file mode 100644
index 0000000..33c464d
--- /dev/null
+++ b/scripts/coccinelle/misc/boolconv.cocci
@@ -0,0 +1,90 @@
+/// Remove unneeded conversion to bool
+///
+//# Relational and logical operators evaluate to bool,
+//# explicit conversion is overly verbose and unneeded.
+//
+// Copyright: (C) 2016 Andrew F. Davis <afd@ti.com> GPLv2.
+
+virtual patch
+virtual context
+virtual org
+virtual report
+
+//----------------------------------------------------------
+// For patch mode
+//----------------------------------------------------------
+
+ at depends on patch@
+expression A, B;
+symbol true, false;
+@@
+
+(
+ A == B
+|
+ A != B
+|
+ A > B
+|
+ A < B
+|
+ A >= B
+|
+ A <= B
+|
+ A && B
+|
+ A || B
+)
+- ? true : false
+
+//----------------------------------------------------------
+// For context mode
+//----------------------------------------------------------
+
+@r depends on !patch@
+expression A, B;
+symbol true, false;
+position p;
+@@
+
+(
+ A == B
+|
+ A != B
+|
+ A > B
+|
+ A < B
+|
+ A >= B
+|
+ A <= B
+|
+ A && B
+|
+ A || B
+)
+* ? true : false at p
+
+//----------------------------------------------------------
+// For org mode
+//----------------------------------------------------------
+
+ at script:python depends on r&&org@
+p << r.p;
+@@
+
+msg = "WARNING: conversion to bool not needed here"
+coccilib.org.print_todo(p[0], msg)
+
+//----------------------------------------------------------
+// For report mode
+//----------------------------------------------------------
+
+@script:python depends on r&&report@
+p << r.p;
+@@
+
+msg = "WARNING: conversion to bool not needed here"
+coccilib.report.print_report(p[0], msg)
--
2.9.0
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [PATCH] Coccinelle: Add misc/boolconv.cocci
@ 2016-06-23 18:53 ` Andrew F. Davis
0 siblings, 0 replies; 8+ messages in thread
From: Andrew F. Davis @ 2016-06-23 18:53 UTC (permalink / raw)
To: Julia Lawall, Gilles Muller, Nicolas Palix, Michal Marek
Cc: cocci, linux-kernel, Andrew F . Davis
Add a script to check for unneeded conversions to bool.
Signed-off-by: Andrew F. Davis <afd@ti.com>
---
scripts/coccinelle/misc/boolconv.cocci | 90 ++++++++++++++++++++++++++++++++++
1 file changed, 90 insertions(+)
create mode 100644 scripts/coccinelle/misc/boolconv.cocci
diff --git a/scripts/coccinelle/misc/boolconv.cocci b/scripts/coccinelle/misc/boolconv.cocci
new file mode 100644
index 0000000..33c464d
--- /dev/null
+++ b/scripts/coccinelle/misc/boolconv.cocci
@@ -0,0 +1,90 @@
+/// Remove unneeded conversion to bool
+///
+//# Relational and logical operators evaluate to bool,
+//# explicit conversion is overly verbose and unneeded.
+//
+// Copyright: (C) 2016 Andrew F. Davis <afd@ti.com> GPLv2.
+
+virtual patch
+virtual context
+virtual org
+virtual report
+
+//----------------------------------------------------------
+// For patch mode
+//----------------------------------------------------------
+
+@depends on patch@
+expression A, B;
+symbol true, false;
+@@
+
+(
+ A == B
+|
+ A != B
+|
+ A > B
+|
+ A < B
+|
+ A >= B
+|
+ A <= B
+|
+ A && B
+|
+ A || B
+)
+- ? true : false
+
+//----------------------------------------------------------
+// For context mode
+//----------------------------------------------------------
+
+@r depends on !patch@
+expression A, B;
+symbol true, false;
+position p;
+@@
+
+(
+ A == B
+|
+ A != B
+|
+ A > B
+|
+ A < B
+|
+ A >= B
+|
+ A <= B
+|
+ A && B
+|
+ A || B
+)
+* ? true : false@p
+
+//----------------------------------------------------------
+// For org mode
+//----------------------------------------------------------
+
+@script:python depends on r&&org@
+p << r.p;
+@@
+
+msg = "WARNING: conversion to bool not needed here"
+coccilib.org.print_todo(p[0], msg)
+
+//----------------------------------------------------------
+// For report mode
+//----------------------------------------------------------
+
+@script:python depends on r&&report@
+p << r.p;
+@@
+
+msg = "WARNING: conversion to bool not needed here"
+coccilib.report.print_report(p[0], msg)
--
2.9.0
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [Cocci] [PATCH] Coccinelle: Add misc/boolconv.cocci
2016-06-23 18:53 ` Andrew F. Davis
@ 2016-06-23 19:12 ` Joe Perches
-1 siblings, 0 replies; 8+ messages in thread
From: Joe Perches @ 2016-06-23 19:12 UTC (permalink / raw)
To: cocci
On Thu, 2016-06-23 at 13:53 -0500, Andrew F. Davis wrote:
> Add a script to check for unneeded conversions to bool.
this could also be extended for bool functions that:
return !!expression;
and
return expression != 0;
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] Coccinelle: Add misc/boolconv.cocci
@ 2016-06-23 19:12 ` Joe Perches
0 siblings, 0 replies; 8+ messages in thread
From: Joe Perches @ 2016-06-23 19:12 UTC (permalink / raw)
To: Andrew F. Davis, Julia Lawall, Gilles Muller, Nicolas Palix,
Michal Marek
Cc: cocci, linux-kernel
On Thu, 2016-06-23 at 13:53 -0500, Andrew F. Davis wrote:
> Add a script to check for unneeded conversions to bool.
this could also be extended for bool functions that:
return !!expression;
and
return expression != 0;
^ permalink raw reply [flat|nested] 8+ messages in thread
* [Cocci] [PATCH] Coccinelle: Add misc/boolconv.cocci
2016-06-23 19:12 ` Joe Perches
@ 2016-06-23 19:22 ` Andrew F. Davis
-1 siblings, 0 replies; 8+ messages in thread
From: Andrew F. Davis @ 2016-06-23 19:22 UTC (permalink / raw)
To: cocci
On 06/23/2016 02:12 PM, Joe Perches wrote:
> On Thu, 2016-06-23 at 13:53 -0500, Andrew F. Davis wrote:
>> Add a script to check for unneeded conversions to bool.
>
> this could also be extended for bool functions that:
>
> return !!expression;
> and
> return expression != 0;
>
Agreed, it's in the works, I was going to post this current set with
some patches to the kernel that is detects, then add additional checks
and their kernel fixes incrementally.
For the second suggestion I think we could have additions to
boolinit.cocci that include the results of comparison/logical operations.
Thanks,
Andrew
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] Coccinelle: Add misc/boolconv.cocci
@ 2016-06-23 19:22 ` Andrew F. Davis
0 siblings, 0 replies; 8+ messages in thread
From: Andrew F. Davis @ 2016-06-23 19:22 UTC (permalink / raw)
To: Joe Perches, Julia Lawall, Gilles Muller, Nicolas Palix,
Michal Marek
Cc: cocci, linux-kernel
On 06/23/2016 02:12 PM, Joe Perches wrote:
> On Thu, 2016-06-23 at 13:53 -0500, Andrew F. Davis wrote:
>> Add a script to check for unneeded conversions to bool.
>
> this could also be extended for bool functions that:
>
> return !!expression;
> and
> return expression != 0;
>
Agreed, it's in the works, I was going to post this current set with
some patches to the kernel that is detects, then add additional checks
and their kernel fixes incrementally.
For the second suggestion I think we could have additions to
boolinit.cocci that include the results of comparison/logical operations.
Thanks,
Andrew
^ permalink raw reply [flat|nested] 8+ messages in thread
* [Cocci] [PATCH] Coccinelle: Add misc/boolconv.cocci
2016-06-23 18:53 ` Andrew F. Davis
@ 2016-06-26 22:01 ` Julia Lawall
-1 siblings, 0 replies; 8+ messages in thread
From: Julia Lawall @ 2016-06-26 22:01 UTC (permalink / raw)
To: cocci
On Thu, 23 Jun 2016, Andrew F. Davis wrote:
> Add a script to check for unneeded conversions to bool.
>
> Signed-off-by: Andrew F. Davis <afd@ti.com>
Acked-by: Julia Lawall <julia.lawall@lip6.fr>
> ---
> scripts/coccinelle/misc/boolconv.cocci | 90 ++++++++++++++++++++++++++++++++++
> 1 file changed, 90 insertions(+)
> create mode 100644 scripts/coccinelle/misc/boolconv.cocci
>
> diff --git a/scripts/coccinelle/misc/boolconv.cocci b/scripts/coccinelle/misc/boolconv.cocci
> new file mode 100644
> index 0000000..33c464d
> --- /dev/null
> +++ b/scripts/coccinelle/misc/boolconv.cocci
> @@ -0,0 +1,90 @@
> +/// Remove unneeded conversion to bool
> +///
> +//# Relational and logical operators evaluate to bool,
> +//# explicit conversion is overly verbose and unneeded.
> +//
> +// Copyright: (C) 2016 Andrew F. Davis <afd@ti.com> GPLv2.
> +
> +virtual patch
> +virtual context
> +virtual org
> +virtual report
> +
> +//----------------------------------------------------------
> +// For patch mode
> +//----------------------------------------------------------
> +
> + at depends on patch@
> +expression A, B;
> +symbol true, false;
> +@@
> +
> +(
> + A == B
> +|
> + A != B
> +|
> + A > B
> +|
> + A < B
> +|
> + A >= B
> +|
> + A <= B
> +|
> + A && B
> +|
> + A || B
> +)
> +- ? true : false
> +
> +//----------------------------------------------------------
> +// For context mode
> +//----------------------------------------------------------
> +
> + at r depends on !patch@
> +expression A, B;
> +symbol true, false;
> +position p;
> +@@
> +
> +(
> + A == B
> +|
> + A != B
> +|
> + A > B
> +|
> + A < B
> +|
> + A >= B
> +|
> + A <= B
> +|
> + A && B
> +|
> + A || B
> +)
> +* ? true : false at p
> +
> +//----------------------------------------------------------
> +// For org mode
> +//----------------------------------------------------------
> +
> + at script:python depends on r&&org@
> +p << r.p;
> +@@
> +
> +msg = "WARNING: conversion to bool not needed here"
> +coccilib.org.print_todo(p[0], msg)
> +
> +//----------------------------------------------------------
> +// For report mode
> +//----------------------------------------------------------
> +
> + at script:python depends on r&&report@
> +p << r.p;
> +@@
> +
> +msg = "WARNING: conversion to bool not needed here"
> +coccilib.report.print_report(p[0], msg)
> --
> 2.9.0
>
>
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] Coccinelle: Add misc/boolconv.cocci
@ 2016-06-26 22:01 ` Julia Lawall
0 siblings, 0 replies; 8+ messages in thread
From: Julia Lawall @ 2016-06-26 22:01 UTC (permalink / raw)
To: Andrew F. Davis
Cc: Julia Lawall, Gilles Muller, Nicolas Palix, Michal Marek, cocci,
linux-kernel
On Thu, 23 Jun 2016, Andrew F. Davis wrote:
> Add a script to check for unneeded conversions to bool.
>
> Signed-off-by: Andrew F. Davis <afd@ti.com>
Acked-by: Julia Lawall <julia.lawall@lip6.fr>
> ---
> scripts/coccinelle/misc/boolconv.cocci | 90 ++++++++++++++++++++++++++++++++++
> 1 file changed, 90 insertions(+)
> create mode 100644 scripts/coccinelle/misc/boolconv.cocci
>
> diff --git a/scripts/coccinelle/misc/boolconv.cocci b/scripts/coccinelle/misc/boolconv.cocci
> new file mode 100644
> index 0000000..33c464d
> --- /dev/null
> +++ b/scripts/coccinelle/misc/boolconv.cocci
> @@ -0,0 +1,90 @@
> +/// Remove unneeded conversion to bool
> +///
> +//# Relational and logical operators evaluate to bool,
> +//# explicit conversion is overly verbose and unneeded.
> +//
> +// Copyright: (C) 2016 Andrew F. Davis <afd@ti.com> GPLv2.
> +
> +virtual patch
> +virtual context
> +virtual org
> +virtual report
> +
> +//----------------------------------------------------------
> +// For patch mode
> +//----------------------------------------------------------
> +
> +@depends on patch@
> +expression A, B;
> +symbol true, false;
> +@@
> +
> +(
> + A == B
> +|
> + A != B
> +|
> + A > B
> +|
> + A < B
> +|
> + A >= B
> +|
> + A <= B
> +|
> + A && B
> +|
> + A || B
> +)
> +- ? true : false
> +
> +//----------------------------------------------------------
> +// For context mode
> +//----------------------------------------------------------
> +
> +@r depends on !patch@
> +expression A, B;
> +symbol true, false;
> +position p;
> +@@
> +
> +(
> + A == B
> +|
> + A != B
> +|
> + A > B
> +|
> + A < B
> +|
> + A >= B
> +|
> + A <= B
> +|
> + A && B
> +|
> + A || B
> +)
> +* ? true : false@p
> +
> +//----------------------------------------------------------
> +// For org mode
> +//----------------------------------------------------------
> +
> +@script:python depends on r&&org@
> +p << r.p;
> +@@
> +
> +msg = "WARNING: conversion to bool not needed here"
> +coccilib.org.print_todo(p[0], msg)
> +
> +//----------------------------------------------------------
> +// For report mode
> +//----------------------------------------------------------
> +
> +@script:python depends on r&&report@
> +p << r.p;
> +@@
> +
> +msg = "WARNING: conversion to bool not needed here"
> +coccilib.report.print_report(p[0], msg)
> --
> 2.9.0
>
>
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2016-06-26 22:01 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-06-23 18:53 [Cocci] [PATCH] Coccinelle: Add misc/boolconv.cocci Andrew F. Davis
2016-06-23 18:53 ` Andrew F. Davis
2016-06-23 19:12 ` [Cocci] " Joe Perches
2016-06-23 19:12 ` Joe Perches
2016-06-23 19:22 ` [Cocci] " Andrew F. Davis
2016-06-23 19:22 ` Andrew F. Davis
2016-06-26 22:01 ` [Cocci] " Julia Lawall
2016-06-26 22:01 ` Julia Lawall
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.