From: Frank Rowand <frowand.list-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
To: Rob Herring <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
Cc: Gaurav Minocha
<gaurav.minocha.os-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
"devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: [PATCH] scripts/dtc: dt_to_config, use full path for dtx_diff
Date: Fri, 24 Jun 2016 17:56:25 -0700 [thread overview]
Message-ID: <576DD6B9.2040303@gmail.com> (raw)
From: Frank Rowand <frank.rowand-mEdOJwZ7QcZBDgjK7y7TUQ@public.gmane.org>
Do not require dtx_diff to be in $PATH.
dt_to_config already needs to be run from the root directory of a kernel
tree so use scripts/dtc/dtx_diff instead of dtx_diff.
Signed-off-by: Frank Rowand <frank.rowand-mEdOJwZ7QcZBDgjK7y7TUQ@public.gmane.org>
---
scripts/dtc/dt_to_config | 22 +++++++++++-----------
1 file changed, 11 insertions(+), 11 deletions(-)
Index: b/scripts/dtc/dt_to_config
===================================================================
--- a/scripts/dtc/dt_to_config
+++ b/scripts/dtc/dt_to_config
@@ -871,19 +871,10 @@ sub read_dts()
exit 3;
}
- if (! `which dtx_diff`) {
- print STDERR "\n";
- print STDERR "file 'dtx_diff' is not executable or does not exist\n";
- print STDERR " Is scripts/dtc/ in the shell \$PATH variable?\n";
- print STDERR " Are you in the root directory of a kernel tree?\n";
- print STDERR "\n";
- exit 3;
- }
-
- if (!open(DT_FILE, "-|", "dtx_diff $file")) {
+ if (!open(DT_FILE, "-|", "$dtx_diff $file")) {
print STDERR "\n";
print STDERR "shell command failed:\n";
- print STDERR " dtx_diff $file\n";
+ print STDERR " $dtx_diff $file\n";
print STDERR "\n";
exit 3;
}
@@ -1207,6 +1198,15 @@ if ($white_list_config) {
}
}
+if (-x "scripts/dtc/dtx_diff") {
+ $dtx_diff = "scripts/dtc/dtx_diff";
+} else {
+
+ print STDERR "\n";
+ print STDERR "$script_name must be run from the root directory of a Linux kernel tree\n";
+ print STDERR "\n";
+ exit 3;
+}
for $file (@ARGV) {
&read_dts($file);
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next reply other threads:[~2016-06-25 0:56 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-25 0:56 Frank Rowand [this message]
[not found] ` <576DD6B9.2040303-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2016-07-18 22:18 ` [PATCH] scripts/dtc: dt_to_config, use full path for dtx_diff Rob Herring
[not found] ` <CAL_JsqKUFR4uX24rV3hoYCEEZ-osDvycM12v1ome3-R3jNORZw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2016-07-18 23:12 ` Frank Rowand
[not found] ` <578D6279.9020004-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2016-07-19 2:40 ` Rob Herring
[not found] ` <CAL_JsqJO98NsoG2RSSa7osZEzaiC8RrYigiwt_nJBCtUU1a8HA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2016-07-19 3:00 ` Gaurav Minocha
[not found] ` <CA+rpMbKm8+S5yrbjAMg7K2J8ThBZhyyQ-iJ8_6+osxHUGqKwtQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2016-07-19 4:15 ` Gaurav Minocha
[not found] ` <CA+rpMbLeYdrC3RVBN2Yku+uAAwM23ABct+rH5_eZ3QonxjuFfw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2016-07-19 4:54 ` Gaurav Minocha
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=576DD6B9.2040303@gmail.com \
--to=frowand.list-re5jqeeqqe8avxtiumwx3w@public.gmane.org \
--cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=gaurav.minocha.os-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.