Re: [PATCH] scripts/dtc: dt_to_config, use full path for dtx_diff

[Frank Rowand <frowand.list-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>]

On 07/18/16 15:18, Rob Herring wrote:
> On Fri, Jun 24, 2016 at 7:56 PM, Frank Rowand <frowand.list-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> wrote:
>> From: Frank Rowand <frank.rowand-mEdOJwZ7QcZBDgjK7y7TUQ@public.gmane.org>
>>
>> Do not require dtx_diff to be in $PATH.
>>
>> dt_to_config already needs to be run from the root directory of a kernel
>> tree so use scripts/dtc/dtx_diff instead of dtx_diff.
> 
> Okay, now I get a bit further. I get this message even if I set my
> .config file on the command line:
> 
> grep: ./.config: No such file or directory

All of the following work for me:

  scripts/dtc/dt_to_config --config .config arch/arm/boot/dts/highbank.dts

  scripts/dtc/dt_to_config --config=.config arch/arm/boot/dts/highbank.dts

  scripts/dtc/dt_to_config --config ./.config arch/arm/boot/dts/highbank.dts

  scripts/dtc/dt_to_config --config=./.config arch/arm/boot/dts/highbank.dts

What is the exact command line you are using?

Just to confirm, you are in the root directory of the kernel source tree
and your .config is in the same directory (since you specified "./.config").

> 
> The config format still doesn't make sense to me. I'm running this on
> highbank.dts, and I get mostly options that are not relevant to
> highbank.

Yes.  dt_to_config is not smart enough to know that you want to configure
a highbank, so it offers you all of the choices that match the highbank
compatibles, even for other boards.  This is the same result that you
would get if you were searching manually, but dt_to_config gives you
those extraneous results much faster than if you were searching manually.

I did some proof of concept code to provide scores for the results, to
select which entries are likely to be correct and which are likely to
be wrong, but I did not want to add that complexity to the first version
of dt_to_config -- it is complex enough already.

I now have some slides that provide more examples of using dt_to_config at 

   http://elinux.org/images/5/50/Dt_debugging_part_2.pdf

You can skip forward to slide 27, then skim to slide 35, then it starts
talking in more detail about using dt_to_config.

I'm in Tokyo this week, so I may be somewhat slow responding.

-Frank
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html