All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] kernel-devsrc.bb: Remove extra System.map file
@ 2025-05-12 19:04 Erick Shepherd
  2025-05-12 19:42 ` [OE-core] " Khem Raj
  2025-05-13  6:53 ` Richard Purdie
  0 siblings, 2 replies; 3+ messages in thread
From: Erick Shepherd @ 2025-05-12 19:04 UTC (permalink / raw)
  To: openembedded-core; +Cc: Erick Shepherd

Currently there are two .map files being copied to $kerneldir/build.
One of the files is System.map and the other is
System.map-<kernel version>. Each .map file takes up about 5MB and
have identical sha256sum hashes. This change will make it so only
System.map is copied in order to save disk space.

Signed-off-by: Erick Shepherd <erick.shepherd@ni.com>
---
 meta/recipes-kernel/linux/kernel-devsrc.bb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/meta/recipes-kernel/linux/kernel-devsrc.bb b/meta/recipes-kernel/linux/kernel-devsrc.bb
index 1500aff2e2..9729a25440 100644
--- a/meta/recipes-kernel/linux/kernel-devsrc.bb
+++ b/meta/recipes-kernel/linux/kernel-devsrc.bb
@@ -75,7 +75,7 @@ do_install() {
         if [ -s Module.symvers ]; then
             cp Module.symvers $kerneldir/build
         fi
-        cp System.map* $kerneldir/build
+        cp System.map $kerneldir/build
         if [ -s Module.markers ]; then
             cp Module.markers $kerneldir/build
         fi
-- 
2.43.0



^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [OE-core] [PATCH] kernel-devsrc.bb: Remove extra System.map file
  2025-05-12 19:04 [PATCH] kernel-devsrc.bb: Remove extra System.map file Erick Shepherd
@ 2025-05-12 19:42 ` Khem Raj
  2025-05-13  6:53 ` Richard Purdie
  1 sibling, 0 replies; 3+ messages in thread
From: Khem Raj @ 2025-05-12 19:42 UTC (permalink / raw)
  To: erick.shepherd; +Cc: openembedded-core

On Mon, May 12, 2025 at 12:04 PM Erick Shepherd via
lists.openembedded.org <erick.shepherd=ni.com@lists.openembedded.org>
wrote:
>
> Currently there are two .map files being copied to $kerneldir/build.
> One of the files is System.map and the other is
> System.map-<kernel version>. Each .map file takes up about 5MB and
> have identical sha256sum hashes. This change will make it so only
> System.map is copied in order to save disk space.
>
> Signed-off-by: Erick Shepherd <erick.shepherd@ni.com>
> ---
>  meta/recipes-kernel/linux/kernel-devsrc.bb | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/meta/recipes-kernel/linux/kernel-devsrc.bb b/meta/recipes-kernel/linux/kernel-devsrc.bb
> index 1500aff2e2..9729a25440 100644
> --- a/meta/recipes-kernel/linux/kernel-devsrc.bb
> +++ b/meta/recipes-kernel/linux/kernel-devsrc.bb
> @@ -75,7 +75,7 @@ do_install() {
>          if [ -s Module.symvers ]; then
>              cp Module.symvers $kerneldir/build
>          fi
> -        cp System.map* $kerneldir/build
> +        cp System.map $kerneldir/build

I wonder if copying the versioned file and creating symlink System.map
pointing to it might
provide both the files and yet reduce the size duplication

>          if [ -s Module.markers ]; then
>              cp Module.markers $kerneldir/build
>          fi
> --
> 2.43.0
>
>
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#216385): https://lists.openembedded.org/g/openembedded-core/message/216385
> Mute This Topic: https://lists.openembedded.org/mt/113076831/1997914
> Group Owner: openembedded-core+owner@lists.openembedded.org
> Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [raj.khem@gmail.com]
> -=-=-=-=-=-=-=-=-=-=-=-
>


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [OE-core] [PATCH] kernel-devsrc.bb: Remove extra System.map file
  2025-05-12 19:04 [PATCH] kernel-devsrc.bb: Remove extra System.map file Erick Shepherd
  2025-05-12 19:42 ` [OE-core] " Khem Raj
@ 2025-05-13  6:53 ` Richard Purdie
  1 sibling, 0 replies; 3+ messages in thread
From: Richard Purdie @ 2025-05-13  6:53 UTC (permalink / raw)
  To: erick.shepherd, openembedded-core; +Cc: Bruce Ashfield

On Mon, 2025-05-12 at 14:04 -0500, Erick Shepherd via
lists.openembedded.org wrote:
> Currently there are two .map files being copied to $kerneldir/build.
> One of the files is System.map and the other is
> System.map-<kernel version>. Each .map file takes up about 5MB and
> have identical sha256sum hashes. This change will make it so only
> System.map is copied in order to save disk space.
> 
> Signed-off-by: Erick Shepherd <erick.shepherd@ni.com>
> ---
>  meta/recipes-kernel/linux/kernel-devsrc.bb | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/meta/recipes-kernel/linux/kernel-devsrc.bb
> b/meta/recipes-kernel/linux/kernel-devsrc.bb
> index 1500aff2e2..9729a25440 100644
> --- a/meta/recipes-kernel/linux/kernel-devsrc.bb
> +++ b/meta/recipes-kernel/linux/kernel-devsrc.bb
> @@ -75,7 +75,7 @@ do_install() {
>          if [ -s Module.symvers ]; then
>              cp Module.symvers $kerneldir/build
>          fi
> -        cp System.map* $kerneldir/build
> +        cp System.map $kerneldir/build
>          if [ -s Module.markers ]; then
>              cp Module.markers $kerneldir/build
>          fi
> 

This caused tons of failures in our automated testing, e.g.:

https://autobuilder.yoctoproject.org/valkyrie/#/builders/78/builds/1630
https://autobuilder.yoctoproject.org/valkyrie/#/builders/2/builds/1606
https://autobuilder.yoctoproject.org/valkyrie/#/builders/60/builds/1601
https://autobuilder.yoctoproject.org/valkyrie/#/builders/19/builds/1599

but many more in that build too.

Cheers,

Richard


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2025-05-13  6:54 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-05-12 19:04 [PATCH] kernel-devsrc.bb: Remove extra System.map file Erick Shepherd
2025-05-12 19:42 ` [OE-core] " Khem Raj
2025-05-13  6:53 ` Richard Purdie

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.