From: Larry Finger <Larry.Finger@lwfinger.net>
To: Joe Perches <joe@perches.com>, Chaoming Li <chaoming_li@realsil.com.cn>
Cc: Kalle Valo <kvalo@codeaurora.org>,
linux-wireless@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] rtlwifi: Add missing newlines to RT_TRACE calls
Date: Sun, 26 Jun 2016 19:18:33 -0500 [thread overview]
Message-ID: <577070D9.5080503@lwfinger.net> (raw)
In-Reply-To: <5677791872bfb47963780c198c825d882456720f.1466969647.git.joe@perches.com>
On 06/26/2016 02:34 PM, Joe Perches wrote:
> RT_TRACE does not add a newline to the end of a message and always
> emits at KERN_DEBUG so these are susceptible to message interleaving
> from other processes without the newline.
>
> Signed-off-by: Joe Perches <joe@perches.com>
> ---
This patch does not apply to the wireless-drivers-next repo. Which one did you use?
Larry
WARNING: multiple messages have this Message-ID (diff)
From: Larry Finger <Larry.Finger-tQ5ms3gMjBLk1uMJSBkQmQ@public.gmane.org>
To: Joe Perches <joe-6d6DIl74uiNBDgjK7y7TUQ@public.gmane.org>,
Chaoming Li <chaoming_li-kXabqFNEczNtrwSWzY7KCg@public.gmane.org>
Cc: Kalle Valo <kvalo-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>,
linux-wireless-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH] rtlwifi: Add missing newlines to RT_TRACE calls
Date: Sun, 26 Jun 2016 19:18:33 -0500 [thread overview]
Message-ID: <577070D9.5080503@lwfinger.net> (raw)
In-Reply-To: <5677791872bfb47963780c198c825d882456720f.1466969647.git.joe-6d6DIl74uiNBDgjK7y7TUQ@public.gmane.org>
On 06/26/2016 02:34 PM, Joe Perches wrote:
> RT_TRACE does not add a newline to the end of a message and always
> emits at KERN_DEBUG so these are susceptible to message interleaving
> from other processes without the newline.
>
> Signed-off-by: Joe Perches <joe-6d6DIl74uiNBDgjK7y7TUQ@public.gmane.org>
> ---
This patch does not apply to the wireless-drivers-next repo. Which one did you use?
Larry
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2016-06-27 0:18 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-26 19:34 [PATCH] rtlwifi: Add missing newlines to RT_TRACE calls Joe Perches
2016-06-27 0:18 ` Larry Finger [this message]
2016-06-27 0:18 ` Larry Finger
2016-06-27 1:13 ` Joe Perches
2016-06-27 1:26 ` Joe Perches
2016-06-27 1:49 ` Larry Finger
2016-06-27 1:49 ` Larry Finger
2016-07-08 9:59 ` Kalle Valo
2016-07-08 9:59 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=577070D9.5080503@lwfinger.net \
--to=larry.finger@lwfinger.net \
--cc=chaoming_li@realsil.com.cn \
--cc=joe@perches.com \
--cc=kvalo@codeaurora.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.