From: Jeff Liu <jeff.liu@easystack.cn>
To: "Yan, Zheng" <ukernel@gmail.com>
Cc: ceph-devel <ceph-devel@vger.kernel.org>
Subject: Re: [PATCH] mds/mdstypes.h: drop the unnecessary format string of snprintf
Date: Mon, 27 Jun 2016 14:45:58 +0800 [thread overview]
Message-ID: <5770CBA6.1050304@easystack.cn> (raw)
In-Reply-To: <CAAM7YAnCTyccFSVRDTh=mUAZ=5sA6ZSfma4UvE62W9Py2LzK+Q@mail.gmail.com>
Got it, thanks Zheng.
On 2016年06月27日 14:38, Yan, Zheng wrote:
Please open a pull request at https://github.com/ceph/ceph
Regards
Yan, Zheng
On Mon, Jun 27, 2016 at 2:26 PM, Jeff Liu <jeff.liu@easystack.cn> wrote:
> Drop the unnecessary format string of snprintf
>
> Signed-off-by: Jie Liu <jeff.liu@easystack.cn>
> ---
> src/mds/mdstypes.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/mds/mdstypes.h b/src/mds/mdstypes.h
> index c69a655..3414ecd 100644
> --- a/src/mds/mdstypes.h
> +++ b/src/mds/mdstypes.h
> @@ -741,7 +741,7 @@ struct dentry_key_t {
> uint64_t val(snapid);
> snprintf(b, sizeof(b), "%" PRIx64, val);
> } else {
> - snprintf(b, sizeof(b), "%s", "head");
> + snprintf(b, sizeof(b), "head");
> }
> ostringstream oss;
> oss << name << "_" << b;
> --
> 1.8.3.2
>
> --
> To unsubscribe from this list: send the line "unsubscribe ceph-devel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe ceph-devel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
--
Cheers,
Jeff Liu
--
To unsubscribe from this list: send the line "unsubscribe ceph-devel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
prev parent reply other threads:[~2016-06-27 6:46 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-27 6:26 [PATCH] mds/mdstypes.h: drop the unnecessary format string of snprintf Jeff Liu
2016-06-27 6:38 ` Yan, Zheng
2016-06-27 6:45 ` Jeff Liu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5770CBA6.1050304@easystack.cn \
--to=jeff.liu@easystack.cn \
--cc=ceph-devel@vger.kernel.org \
--cc=ukernel@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.