* [PATCH] mds/mdstypes.h: drop the unnecessary format string of snprintf
@ 2016-06-27 6:26 Jeff Liu
2016-06-27 6:38 ` Yan, Zheng
0 siblings, 1 reply; 3+ messages in thread
From: Jeff Liu @ 2016-06-27 6:26 UTC (permalink / raw)
To: ceph-devel
Drop the unnecessary format string of snprintf
Signed-off-by: Jie Liu <jeff.liu@easystack.cn>
---
src/mds/mdstypes.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/mds/mdstypes.h b/src/mds/mdstypes.h
index c69a655..3414ecd 100644
--- a/src/mds/mdstypes.h
+++ b/src/mds/mdstypes.h
@@ -741,7 +741,7 @@ struct dentry_key_t {
uint64_t val(snapid);
snprintf(b, sizeof(b), "%" PRIx64, val);
} else {
- snprintf(b, sizeof(b), "%s", "head");
+ snprintf(b, sizeof(b), "head");
}
ostringstream oss;
oss << name << "_" << b;
--
1.8.3.2
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] mds/mdstypes.h: drop the unnecessary format string of snprintf
2016-06-27 6:26 [PATCH] mds/mdstypes.h: drop the unnecessary format string of snprintf Jeff Liu
@ 2016-06-27 6:38 ` Yan, Zheng
2016-06-27 6:45 ` Jeff Liu
0 siblings, 1 reply; 3+ messages in thread
From: Yan, Zheng @ 2016-06-27 6:38 UTC (permalink / raw)
To: Jeff Liu; +Cc: ceph-devel
Please open a pull request at https://github.com/ceph/ceph
Regards
Yan, Zheng
On Mon, Jun 27, 2016 at 2:26 PM, Jeff Liu <jeff.liu@easystack.cn> wrote:
> Drop the unnecessary format string of snprintf
>
> Signed-off-by: Jie Liu <jeff.liu@easystack.cn>
> ---
> src/mds/mdstypes.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/mds/mdstypes.h b/src/mds/mdstypes.h
> index c69a655..3414ecd 100644
> --- a/src/mds/mdstypes.h
> +++ b/src/mds/mdstypes.h
> @@ -741,7 +741,7 @@ struct dentry_key_t {
> uint64_t val(snapid);
> snprintf(b, sizeof(b), "%" PRIx64, val);
> } else {
> - snprintf(b, sizeof(b), "%s", "head");
> + snprintf(b, sizeof(b), "head");
> }
> ostringstream oss;
> oss << name << "_" << b;
> --
> 1.8.3.2
>
> --
> To unsubscribe from this list: send the line "unsubscribe ceph-devel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] mds/mdstypes.h: drop the unnecessary format string of snprintf
2016-06-27 6:38 ` Yan, Zheng
@ 2016-06-27 6:45 ` Jeff Liu
0 siblings, 0 replies; 3+ messages in thread
From: Jeff Liu @ 2016-06-27 6:45 UTC (permalink / raw)
To: Yan, Zheng; +Cc: ceph-devel
Got it, thanks Zheng.
On 2016年06月27日 14:38, Yan, Zheng wrote:
Please open a pull request at https://github.com/ceph/ceph
Regards
Yan, Zheng
On Mon, Jun 27, 2016 at 2:26 PM, Jeff Liu <jeff.liu@easystack.cn> wrote:
> Drop the unnecessary format string of snprintf
>
> Signed-off-by: Jie Liu <jeff.liu@easystack.cn>
> ---
> src/mds/mdstypes.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/mds/mdstypes.h b/src/mds/mdstypes.h
> index c69a655..3414ecd 100644
> --- a/src/mds/mdstypes.h
> +++ b/src/mds/mdstypes.h
> @@ -741,7 +741,7 @@ struct dentry_key_t {
> uint64_t val(snapid);
> snprintf(b, sizeof(b), "%" PRIx64, val);
> } else {
> - snprintf(b, sizeof(b), "%s", "head");
> + snprintf(b, sizeof(b), "head");
> }
> ostringstream oss;
> oss << name << "_" << b;
> --
> 1.8.3.2
>
> --
> To unsubscribe from this list: send the line "unsubscribe ceph-devel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe ceph-devel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
--
Cheers,
Jeff Liu
--
To unsubscribe from this list: send the line "unsubscribe ceph-devel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-06-27 6:46 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-06-27 6:26 [PATCH] mds/mdstypes.h: drop the unnecessary format string of snprintf Jeff Liu
2016-06-27 6:38 ` Yan, Zheng
2016-06-27 6:45 ` Jeff Liu
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.