From: Krzysztof Kozlowski <k.kozlowski@samsung.com>
To: Arnd Bergmann <arnd@arndb.de>, Rob Herring <robh@kernel.org>
Cc: Kefeng Wang <wangkefeng.wang@huawei.com>,
Kukjin Kim <kgene@kernel.org>,
linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ARM: s3c64xx: avoid warning about 'struct device_node'
Date: Mon, 27 Jun 2016 13:33:51 +0200 [thread overview]
Message-ID: <57710F1F.8090304@samsung.com> (raw)
In-Reply-To: <20160627110303.3391769-1-arnd@arndb.de>
On 06/27/2016 01:02 PM, Arnd Bergmann wrote:
> The change to simplify of_platform_populate() had an unintended
> side-effect of introducing a build warning on s3c64xx:
>
> In file included from arch/arm/mach-s3c64xx/mach-s3c64xx-dt.c:18:0:
> arch/arm/mach-s3c64xx/common.h:27:30: error: 'struct device_node' declared inside parameter list will not be visible outside of this definition or declaration [-Werror]
>
> This adds a forward-declaration for the structure name in the
> header to avoid the warning.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Fixes: 850bea2335e4 ("arm: Remove unnecessary of_platform_populate with default match table")
> ---
> Rob, can you apply this on top of the devicetree git so we don't
> have to coordinate the merges?
Acked-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
BR,
Krzysztof
WARNING: multiple messages have this Message-ID (diff)
From: k.kozlowski@samsung.com (Krzysztof Kozlowski)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: s3c64xx: avoid warning about 'struct device_node'
Date: Mon, 27 Jun 2016 13:33:51 +0200 [thread overview]
Message-ID: <57710F1F.8090304@samsung.com> (raw)
In-Reply-To: <20160627110303.3391769-1-arnd@arndb.de>
On 06/27/2016 01:02 PM, Arnd Bergmann wrote:
> The change to simplify of_platform_populate() had an unintended
> side-effect of introducing a build warning on s3c64xx:
>
> In file included from arch/arm/mach-s3c64xx/mach-s3c64xx-dt.c:18:0:
> arch/arm/mach-s3c64xx/common.h:27:30: error: 'struct device_node' declared inside parameter list will not be visible outside of this definition or declaration [-Werror]
>
> This adds a forward-declaration for the structure name in the
> header to avoid the warning.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Fixes: 850bea2335e4 ("arm: Remove unnecessary of_platform_populate with default match table")
> ---
> Rob, can you apply this on top of the devicetree git so we don't
> have to coordinate the merges?
Acked-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
BR,
Krzysztof
next prev parent reply other threads:[~2016-06-27 11:33 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-27 11:02 [PATCH] ARM: s3c64xx: avoid warning about 'struct device_node' Arnd Bergmann
2016-06-27 11:02 ` Arnd Bergmann
2016-06-27 11:33 ` Krzysztof Kozlowski [this message]
2016-06-27 11:33 ` Krzysztof Kozlowski
2016-07-11 11:15 ` Arnd Bergmann
2016-07-11 11:15 ` Arnd Bergmann
2016-07-11 11:40 ` Arnd Bergmann
2016-07-11 11:40 ` Arnd Bergmann
2016-07-14 12:47 ` Arnd Bergmann
2016-07-14 12:47 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=57710F1F.8090304@samsung.com \
--to=k.kozlowski@samsung.com \
--cc=arnd@arndb.de \
--cc=kgene@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=robh@kernel.org \
--cc=wangkefeng.wang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.