From: funkybomber <funkybomber@gmail.com>
To: linux-wireless@vger.kernel.org
Subject: Possible issue with commit "baa1702290953295e421f0f433e2b1ff4815827c"
Date: Tue, 28 Jun 2016 11:47:20 +0930 [thread overview]
Message-ID: <5771DE30.3060407@gmail.com> (raw)
In-Reply-To: <878txqevho.fsf@kamboji.qca.qualcomm.com>
Hello,
Sorry if this is not the proper way to report this but I noticed
something that has to be an error in commit
"baa1702290953295e421f0f433e2b1ff4815827c"
https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=baa1702290953295e421f0f433e2b1ff4815827c
in the file "halbtcoutsrc.c"
there is:
+ if ((gl_bt_coexist.board_info.pg_ant_num == 2) &&
+ (gl_bt_coexist.board_info.btdm_ant_num == 1))
+ gl_bt_coexist.board_info.btdm_ant_pos =
+ BTC_ANTENNA_AT_MAIN_PORT;
+ else
+ gl_bt_coexist.board_info.btdm_ant_pos =
+ BTC_ANTENNA_AT_MAIN_PORT;
The action performed under the IF condition is the same as the one under
the ELSE condition, so either there is a bug here or there simply is no
need for the IF/ELSE clause.
Sorry if I'm all wrong on this, I was just casually looking through code
and this striked weird to me!
Take care!
parent reply other threads:[~2016-06-28 2:18 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <878txqevho.fsf@kamboji.qca.qualcomm.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5771DE30.3060407@gmail.com \
--to=funkybomber@gmail.com \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.