All of lore.kernel.org
 help / color / mirror / Atom feed
* Possible issue with commit "baa1702290953295e421f0f433e2b1ff4815827c"
       [not found] <878txqevho.fsf@kamboji.qca.qualcomm.com>
@ 2016-06-28  2:17 ` funkybomber
  0 siblings, 0 replies; only message in thread
From: funkybomber @ 2016-06-28  2:17 UTC (permalink / raw)
  To: linux-wireless

Hello,

Sorry if this is not the proper way to report this but I noticed 
something that has to be an error in commit 
"baa1702290953295e421f0f433e2b1ff4815827c"

https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=baa1702290953295e421f0f433e2b1ff4815827c 



in the file "halbtcoutsrc.c"

there is:

+ if ((gl_bt_coexist.board_info.pg_ant_num == 2) &&
+     (gl_bt_coexist.board_info.btdm_ant_num == 1))
+         gl_bt_coexist.board_info.btdm_ant_pos =
+                         BTC_ANTENNA_AT_MAIN_PORT;
+ else
+         gl_bt_coexist.board_info.btdm_ant_pos =
+                         BTC_ANTENNA_AT_MAIN_PORT;


The action performed under the IF condition is the same as the one under 
the ELSE condition, so either there is a bug here or there simply is no 
need for the IF/ELSE clause.

Sorry if I'm all wrong on this, I was just casually looking through code 
and this striked weird to me!

Take care!

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2016-06-28  2:18 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
     [not found] <878txqevho.fsf@kamboji.qca.qualcomm.com>
2016-06-28  2:17 ` Possible issue with commit "baa1702290953295e421f0f433e2b1ff4815827c" funkybomber

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.