All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Heiko Stübner" <heiko@sntech.de>
To: Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Jonas Karlman <jonas@kwiboo.se>
Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 2/2] arm64: dts: rockchip: Add Radxa ZERO 3W/3E
Date: Tue, 16 Apr 2024 10:23:14 +0200	[thread overview]
Message-ID: <5772116.DvuYhMxLoT@diego> (raw)
In-Reply-To: <f5a9e7c0-1d8c-462b-bf7a-d6aa73f63afa@kwiboo.se>

Am Dienstag, 16. April 2024, 10:05:09 CEST schrieb Jonas Karlman:
> On 2024-04-15 17:03, Jonas Karlman wrote:
> > The Radxa ZERO 3W/3E is an ultra-small, high-performance single board
> > computer based on the Rockchip RK3566, with a compact form factor and
> > rich interfaces.
> > 
> > The ZERO 3W and ZERO 3E are basically the same size and model, but
> > differ only in storage and network interfaces.
> > 
> > - eMMC (3W)
> > - SD-card (both)
> > - Ethernet (3E)
> > - WiFi/BT (3W)
> > 
> > This adds initial support for eMMC, SD-card, Ethernet, HDMI and USB.
> > 
> > Signed-off-by: Jonas Karlman <jonas@kwiboo.se>
> > ---
> > v2: Add to Makefile
> > v3: Sort hdmi-con and leds nodes alphabetically
> > v3: Sort pmic@20 and regulator@40 nodes by reg
> > v3: Change to regulator-off-in-suspend for vdd_logic
> > 
> > Following issue is reported by dtbs_check and is fixed by patch at [1]:
> > 
> >   hdmi@fe0a0000: Unevaluated properties are not allowed ('#sound-dai-cells' was unexpected)
> >   from schema $id: http://devicetree.org/schemas/display/rockchip/rockchip,dw-hdmi.yaml#
> > 
> > [1] https://lore.kernel.org/linux-rockchip/3a035c16-75b5-471d-aa9d-e91c2bb9f8d0@gmail.com/
> > ---
> >  arch/arm64/boot/dts/rockchip/Makefile         |   2 +
> >  .../dts/rockchip/rk3566-radxa-zero-3e.dts     |  41 ++
> >  .../dts/rockchip/rk3566-radxa-zero-3w.dts     |  26 +
> >  .../boot/dts/rockchip/rk3566-radxa-zero3.dtsi | 443 ++++++++++++++++++
> >  4 files changed, 512 insertions(+)
> >  create mode 100644 arch/arm64/boot/dts/rockchip/rk3566-radxa-zero-3e.dts
> >  create mode 100644 arch/arm64/boot/dts/rockchip/rk3566-radxa-zero-3w.dts
> >  create mode 100644 arch/arm64/boot/dts/rockchip/rk3566-radxa-zero3.dtsi
> > 
> 
> [snip]
> 
> > diff --git a/arch/arm64/boot/dts/rockchip/rk3566-radxa-zero3.dtsi b/arch/arm64/boot/dts/rockchip/rk3566-radxa-zero3.dtsi
> > new file mode 100644
> > index 000000000000..ea8ade3a4c99
> > --- /dev/null
> > +++ b/arch/arm64/boot/dts/rockchip/rk3566-radxa-zero3.dtsi
> 
> [snip]
> 
> > +
> > +&i2c0 {
> > +	status = "okay";
> > +
> 
> [snip]
> 
> > +	vdd_cpu: regulator@40 {
> > +		compatible = "silergy,syr827";
> 
> After checking once more on schematic and inspecting the board this is
> actually a RK860-0 regulator and should use following:
> 
>   compatible = "rockchip,rk8600";
> 
> Will send a v4 with this change later this week.

ok, will wait for that then.

Heiko



_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip

WARNING: multiple messages have this Message-ID (diff)
From: "Heiko Stübner" <heiko@sntech.de>
To: Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Jonas Karlman <jonas@kwiboo.se>
Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 2/2] arm64: dts: rockchip: Add Radxa ZERO 3W/3E
Date: Tue, 16 Apr 2024 10:23:14 +0200	[thread overview]
Message-ID: <5772116.DvuYhMxLoT@diego> (raw)
In-Reply-To: <f5a9e7c0-1d8c-462b-bf7a-d6aa73f63afa@kwiboo.se>

Am Dienstag, 16. April 2024, 10:05:09 CEST schrieb Jonas Karlman:
> On 2024-04-15 17:03, Jonas Karlman wrote:
> > The Radxa ZERO 3W/3E is an ultra-small, high-performance single board
> > computer based on the Rockchip RK3566, with a compact form factor and
> > rich interfaces.
> > 
> > The ZERO 3W and ZERO 3E are basically the same size and model, but
> > differ only in storage and network interfaces.
> > 
> > - eMMC (3W)
> > - SD-card (both)
> > - Ethernet (3E)
> > - WiFi/BT (3W)
> > 
> > This adds initial support for eMMC, SD-card, Ethernet, HDMI and USB.
> > 
> > Signed-off-by: Jonas Karlman <jonas@kwiboo.se>
> > ---
> > v2: Add to Makefile
> > v3: Sort hdmi-con and leds nodes alphabetically
> > v3: Sort pmic@20 and regulator@40 nodes by reg
> > v3: Change to regulator-off-in-suspend for vdd_logic
> > 
> > Following issue is reported by dtbs_check and is fixed by patch at [1]:
> > 
> >   hdmi@fe0a0000: Unevaluated properties are not allowed ('#sound-dai-cells' was unexpected)
> >   from schema $id: http://devicetree.org/schemas/display/rockchip/rockchip,dw-hdmi.yaml#
> > 
> > [1] https://lore.kernel.org/linux-rockchip/3a035c16-75b5-471d-aa9d-e91c2bb9f8d0@gmail.com/
> > ---
> >  arch/arm64/boot/dts/rockchip/Makefile         |   2 +
> >  .../dts/rockchip/rk3566-radxa-zero-3e.dts     |  41 ++
> >  .../dts/rockchip/rk3566-radxa-zero-3w.dts     |  26 +
> >  .../boot/dts/rockchip/rk3566-radxa-zero3.dtsi | 443 ++++++++++++++++++
> >  4 files changed, 512 insertions(+)
> >  create mode 100644 arch/arm64/boot/dts/rockchip/rk3566-radxa-zero-3e.dts
> >  create mode 100644 arch/arm64/boot/dts/rockchip/rk3566-radxa-zero-3w.dts
> >  create mode 100644 arch/arm64/boot/dts/rockchip/rk3566-radxa-zero3.dtsi
> > 
> 
> [snip]
> 
> > diff --git a/arch/arm64/boot/dts/rockchip/rk3566-radxa-zero3.dtsi b/arch/arm64/boot/dts/rockchip/rk3566-radxa-zero3.dtsi
> > new file mode 100644
> > index 000000000000..ea8ade3a4c99
> > --- /dev/null
> > +++ b/arch/arm64/boot/dts/rockchip/rk3566-radxa-zero3.dtsi
> 
> [snip]
> 
> > +
> > +&i2c0 {
> > +	status = "okay";
> > +
> 
> [snip]
> 
> > +	vdd_cpu: regulator@40 {
> > +		compatible = "silergy,syr827";
> 
> After checking once more on schematic and inspecting the board this is
> actually a RK860-0 regulator and should use following:
> 
>   compatible = "rockchip,rk8600";
> 
> Will send a v4 with this change later this week.

ok, will wait for that then.

Heiko



_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

WARNING: multiple messages have this Message-ID (diff)
From: "Heiko Stübner" <heiko@sntech.de>
To: Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Jonas Karlman <jonas@kwiboo.se>
Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 2/2] arm64: dts: rockchip: Add Radxa ZERO 3W/3E
Date: Tue, 16 Apr 2024 10:23:14 +0200	[thread overview]
Message-ID: <5772116.DvuYhMxLoT@diego> (raw)
In-Reply-To: <f5a9e7c0-1d8c-462b-bf7a-d6aa73f63afa@kwiboo.se>

Am Dienstag, 16. April 2024, 10:05:09 CEST schrieb Jonas Karlman:
> On 2024-04-15 17:03, Jonas Karlman wrote:
> > The Radxa ZERO 3W/3E is an ultra-small, high-performance single board
> > computer based on the Rockchip RK3566, with a compact form factor and
> > rich interfaces.
> > 
> > The ZERO 3W and ZERO 3E are basically the same size and model, but
> > differ only in storage and network interfaces.
> > 
> > - eMMC (3W)
> > - SD-card (both)
> > - Ethernet (3E)
> > - WiFi/BT (3W)
> > 
> > This adds initial support for eMMC, SD-card, Ethernet, HDMI and USB.
> > 
> > Signed-off-by: Jonas Karlman <jonas@kwiboo.se>
> > ---
> > v2: Add to Makefile
> > v3: Sort hdmi-con and leds nodes alphabetically
> > v3: Sort pmic@20 and regulator@40 nodes by reg
> > v3: Change to regulator-off-in-suspend for vdd_logic
> > 
> > Following issue is reported by dtbs_check and is fixed by patch at [1]:
> > 
> >   hdmi@fe0a0000: Unevaluated properties are not allowed ('#sound-dai-cells' was unexpected)
> >   from schema $id: http://devicetree.org/schemas/display/rockchip/rockchip,dw-hdmi.yaml#
> > 
> > [1] https://lore.kernel.org/linux-rockchip/3a035c16-75b5-471d-aa9d-e91c2bb9f8d0@gmail.com/
> > ---
> >  arch/arm64/boot/dts/rockchip/Makefile         |   2 +
> >  .../dts/rockchip/rk3566-radxa-zero-3e.dts     |  41 ++
> >  .../dts/rockchip/rk3566-radxa-zero-3w.dts     |  26 +
> >  .../boot/dts/rockchip/rk3566-radxa-zero3.dtsi | 443 ++++++++++++++++++
> >  4 files changed, 512 insertions(+)
> >  create mode 100644 arch/arm64/boot/dts/rockchip/rk3566-radxa-zero-3e.dts
> >  create mode 100644 arch/arm64/boot/dts/rockchip/rk3566-radxa-zero-3w.dts
> >  create mode 100644 arch/arm64/boot/dts/rockchip/rk3566-radxa-zero3.dtsi
> > 
> 
> [snip]
> 
> > diff --git a/arch/arm64/boot/dts/rockchip/rk3566-radxa-zero3.dtsi b/arch/arm64/boot/dts/rockchip/rk3566-radxa-zero3.dtsi
> > new file mode 100644
> > index 000000000000..ea8ade3a4c99
> > --- /dev/null
> > +++ b/arch/arm64/boot/dts/rockchip/rk3566-radxa-zero3.dtsi
> 
> [snip]
> 
> > +
> > +&i2c0 {
> > +	status = "okay";
> > +
> 
> [snip]
> 
> > +	vdd_cpu: regulator@40 {
> > +		compatible = "silergy,syr827";
> 
> After checking once more on schematic and inspecting the board this is
> actually a RK860-0 regulator and should use following:
> 
>   compatible = "rockchip,rk8600";
> 
> Will send a v4 with this change later this week.

ok, will wait for that then.

Heiko



  reply	other threads:[~2024-04-16  8:23 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-04-15 15:03 [PATCH v3 0/2] arm64: dts: rockchip: Add Radxa ZERO 3W/3E Jonas Karlman
2024-04-15 15:03 ` Jonas Karlman
2024-04-15 15:03 ` Jonas Karlman
2024-04-15 15:03 ` [PATCH v3 1/2] dt-bindings: arm: " Jonas Karlman
2024-04-15 15:03   ` Jonas Karlman
2024-04-15 15:03   ` Jonas Karlman
2024-04-15 15:03 ` [PATCH v3 2/2] arm64: dts: " Jonas Karlman
2024-04-15 15:03   ` Jonas Karlman
2024-04-15 15:03   ` Jonas Karlman
2024-04-16  8:05   ` Jonas Karlman
2024-04-16  8:05     ` Jonas Karlman
2024-04-16  8:05     ` Jonas Karlman
2024-04-16  8:23     ` Heiko Stübner [this message]
2024-04-16  8:23       ` Heiko Stübner
2024-04-16  8:23       ` Heiko Stübner
2024-04-15 18:47 ` [PATCH v3 0/2] " Rob Herring
2024-04-15 18:47   ` Rob Herring
2024-04-15 18:47   ` Rob Herring

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5772116.DvuYhMxLoT@diego \
    --to=heiko@sntech.de \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=jonas@kwiboo.se \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rockchip@lists.infradead.org \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.