All of lore.kernel.org
 help / color / mirror / Atom feed
From: Roger Quadros <rogerq@ti.com>
To: Stephen Boyd <stephen.boyd@linaro.org>,
	Chanwoo Choi <cw00.choi@samsung.com>
Cc: linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org
Subject: Re: [PATCH] extcon: Add support for qcom SPMI PMIC USB id detection hardware
Date: Tue, 28 Jun 2016 12:13:57 +0300	[thread overview]
Message-ID: <57723FD5.8050305@ti.com> (raw)
In-Reply-To: <146710362771.3879.13924434427129313640@sboyd-linaro>

On 28/06/16 11:47, Stephen Boyd wrote:
> Quoting Roger Quadros (2016-06-27 23:36:26)
>> On 27/06/16 22:30, Stephen Boyd wrote:
>>>
>>> The VBUS notification is done through another piece of hardware. In this
>>> case it's done by the charger module. I've sent a patch for that[1].
>>
>> Isn't it better if ID event is handled as well in that PMIC driver instead of
>> creating a separate one here?
>>
>> Why do you need ID to be handled outside of the PMIC driver?
>> You mentioned earlier that some Qualcomm PMICs have ID detection.
>
> Sorry I must have confused you. There are two modules in the PMIC that
> are doing detection here. The charger module is detecting the VBUS event
> and this misc module is detecting the ID pin. I'm not sure why they're
> two different blocks, but it is what it is in the hardware.
> 
OK. Can the MISC block do anything else other than USB ID?
Does the USB ID interrupt come on a different line than the charger interrupt?

It would be more like MISC block interrupt than USB ID interrupt right?

cheers,
-roger

WARNING: multiple messages have this Message-ID (diff)
From: rogerq@ti.com (Roger Quadros)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] extcon: Add support for qcom SPMI PMIC USB id detection hardware
Date: Tue, 28 Jun 2016 12:13:57 +0300	[thread overview]
Message-ID: <57723FD5.8050305@ti.com> (raw)
In-Reply-To: <146710362771.3879.13924434427129313640@sboyd-linaro>

On 28/06/16 11:47, Stephen Boyd wrote:
> Quoting Roger Quadros (2016-06-27 23:36:26)
>> On 27/06/16 22:30, Stephen Boyd wrote:
>>>
>>> The VBUS notification is done through another piece of hardware. In this
>>> case it's done by the charger module. I've sent a patch for that[1].
>>
>> Isn't it better if ID event is handled as well in that PMIC driver instead of
>> creating a separate one here?
>>
>> Why do you need ID to be handled outside of the PMIC driver?
>> You mentioned earlier that some Qualcomm PMICs have ID detection.
>
> Sorry I must have confused you. There are two modules in the PMIC that
> are doing detection here. The charger module is detecting the VBUS event
> and this misc module is detecting the ID pin. I'm not sure why they're
> two different blocks, but it is what it is in the hardware.
> 
OK. Can the MISC block do anything else other than USB ID?
Does the USB ID interrupt come on a different line than the charger interrupt?

It would be more like MISC block interrupt than USB ID interrupt right?

cheers,
-roger

WARNING: multiple messages have this Message-ID (diff)
From: Roger Quadros <rogerq@ti.com>
To: Stephen Boyd <stephen.boyd@linaro.org>,
	Chanwoo Choi <cw00.choi@samsung.com>
Cc: <linux-arm-kernel@lists.infradead.org>,
	<linux-kernel@vger.kernel.org>, <linux-arm-msm@vger.kernel.org>
Subject: Re: [PATCH] extcon: Add support for qcom SPMI PMIC USB id detection hardware
Date: Tue, 28 Jun 2016 12:13:57 +0300	[thread overview]
Message-ID: <57723FD5.8050305@ti.com> (raw)
In-Reply-To: <146710362771.3879.13924434427129313640@sboyd-linaro>

On 28/06/16 11:47, Stephen Boyd wrote:
> Quoting Roger Quadros (2016-06-27 23:36:26)
>> On 27/06/16 22:30, Stephen Boyd wrote:
>>>
>>> The VBUS notification is done through another piece of hardware. In this
>>> case it's done by the charger module. I've sent a patch for that[1].
>>
>> Isn't it better if ID event is handled as well in that PMIC driver instead of
>> creating a separate one here?
>>
>> Why do you need ID to be handled outside of the PMIC driver?
>> You mentioned earlier that some Qualcomm PMICs have ID detection.
>
> Sorry I must have confused you. There are two modules in the PMIC that
> are doing detection here. The charger module is detecting the VBUS event
> and this misc module is detecting the ID pin. I'm not sure why they're
> two different blocks, but it is what it is in the hardware.
> 
OK. Can the MISC block do anything else other than USB ID?
Does the USB ID interrupt come on a different line than the charger interrupt?

It would be more like MISC block interrupt than USB ID interrupt right?

cheers,
-roger

  reply	other threads:[~2016-06-28  9:14 UTC|newest]

Thread overview: 43+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-06-26  5:56 [PATCH] extcon: Add support for qcom SPMI PMIC USB id detection hardware Stephen Boyd
2016-06-26  5:56 ` Stephen Boyd
2016-06-26 11:20 ` Chanwoo Choi
2016-06-26 11:20   ` Chanwoo Choi
2016-06-26 11:22   ` Chanwoo Choi
2016-06-26 11:22     ` Chanwoo Choi
2016-06-26 11:22     ` Chanwoo Choi
2016-06-27 19:11   ` Stephen Boyd
2016-06-27 19:11     ` Stephen Boyd
2016-06-28 12:06     ` Chanwoo Choi
2016-06-28 12:06       ` Chanwoo Choi
2016-06-28 21:59       ` Stephen Boyd
2016-06-28 21:59         ` Stephen Boyd
2016-06-29  6:25         ` Chanwoo Choi
2016-06-29  6:25           ` Chanwoo Choi
2016-06-29 18:48           ` Stephen Boyd
2016-06-29 18:48             ` Stephen Boyd
2016-06-29 18:48             ` Stephen Boyd
2016-06-30  0:35             ` Chanwoo Choi
2016-06-30  0:35               ` Chanwoo Choi
2016-06-30  1:04               ` Stephen Boyd
2016-06-30  1:04                 ` Stephen Boyd
2016-06-27  7:39 ` Roger Quadros
2016-06-27  7:39   ` Roger Quadros
2016-06-27  7:39   ` Roger Quadros
2016-06-27 19:30   ` Stephen Boyd
2016-06-27 19:30     ` Stephen Boyd
2016-06-27 19:30     ` Stephen Boyd
2016-06-28  6:36     ` Roger Quadros
2016-06-28  6:36       ` Roger Quadros
2016-06-28  6:36       ` Roger Quadros
2016-06-28  8:47       ` Stephen Boyd
2016-06-28  8:47         ` Stephen Boyd
2016-06-28  9:13         ` Roger Quadros [this message]
2016-06-28  9:13           ` Roger Quadros
2016-06-28  9:13           ` Roger Quadros
2016-06-28 22:01           ` Stephen Boyd
2016-06-28 22:01             ` Stephen Boyd
2016-06-29  6:10             ` Roger Quadros
2016-06-29  6:10               ` Roger Quadros
2016-06-29  6:10               ` Roger Quadros
2016-06-29 18:51               ` Stephen Boyd
2016-06-29 18:51                 ` Stephen Boyd

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=57723FD5.8050305@ti.com \
    --to=rogerq@ti.com \
    --cc=cw00.choi@samsung.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=stephen.boyd@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.