From: Eric Blake <eblake@redhat.com>
To: Peter Maydell <peter.maydell@linaro.org>,
qemu-devel@nongnu.org, qemu-trivial@nongnu.org
Cc: patches@linaro.org
Subject: Re: [Qemu-trivial] [Qemu-devel] [PATCH 1/6] fsdev/9p-iov-marshal.c: Don't use cpu_to_*w() functions
Date: Tue, 28 Jun 2016 09:09:31 -0600 [thread overview]
Message-ID: <5772932B.1000302@redhat.com> (raw)
In-Reply-To: <1467125451-16700-2-git-send-email-peter.maydell@linaro.org>
[-- Attachment #1.1: Type: text/plain, Size: 729 bytes --]
On 06/28/2016 08:50 AM, Peter Maydell wrote:
> Don't use the cpu_to_*w() functions, which we are trying to deprecate.
> Instead just use cpu_to_*() to do the byteswap, which brings the
> code in the marshal function in line with that in the unmarshal.
>
> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
> ---
> fsdev/9p-iov-marshal.c | 18 ++++++------------
> 1 file changed, 6 insertions(+), 12 deletions(-)
>
> case 'q': {
> - uint64_t val;
> + uint64_t val = va_arg(ap, uint64_t);;
s/;;/;/
With that fix,
Reviewed-by: Eric Blake <eblake@redhat.com>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Eric Blake <eblake@redhat.com>
To: Peter Maydell <peter.maydell@linaro.org>,
qemu-devel@nongnu.org, qemu-trivial@nongnu.org
Cc: patches@linaro.org
Subject: Re: [Qemu-devel] [PATCH 1/6] fsdev/9p-iov-marshal.c: Don't use cpu_to_*w() functions
Date: Tue, 28 Jun 2016 09:09:31 -0600 [thread overview]
Message-ID: <5772932B.1000302@redhat.com> (raw)
In-Reply-To: <1467125451-16700-2-git-send-email-peter.maydell@linaro.org>
[-- Attachment #1: Type: text/plain, Size: 729 bytes --]
On 06/28/2016 08:50 AM, Peter Maydell wrote:
> Don't use the cpu_to_*w() functions, which we are trying to deprecate.
> Instead just use cpu_to_*() to do the byteswap, which brings the
> code in the marshal function in line with that in the unmarshal.
>
> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
> ---
> fsdev/9p-iov-marshal.c | 18 ++++++------------
> 1 file changed, 6 insertions(+), 12 deletions(-)
>
> case 'q': {
> - uint64_t val;
> + uint64_t val = va_arg(ap, uint64_t);;
s/;;/;/
With that fix,
Reviewed-by: Eric Blake <eblake@redhat.com>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]
next prev parent reply other threads:[~2016-06-28 15:09 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-28 14:50 [Qemu-trivial] [PATCH 0/6] Drop cpu_to_*w, *_to_cpup, document cpu_to_*, *_to_cpu Peter Maydell
2016-06-28 14:50 ` [Qemu-devel] " Peter Maydell
2016-06-28 14:50 ` [Qemu-trivial] [PATCH 1/6] fsdev/9p-iov-marshal.c: Don't use cpu_to_*w() functions Peter Maydell
2016-06-28 14:50 ` [Qemu-devel] " Peter Maydell
2016-06-28 15:09 ` Eric Blake [this message]
2016-06-28 15:09 ` Eric Blake
2016-06-28 14:50 ` [Qemu-trivial] [PATCH 2/6] block/qcow2: Don't use cpu_to_*w() Peter Maydell
2016-06-28 14:50 ` [Qemu-devel] " Peter Maydell
2016-06-28 15:13 ` [Qemu-trivial] " Eric Blake
2016-06-28 15:13 ` Eric Blake
2016-06-28 15:13 ` [Qemu-trivial] " Peter Maydell
2016-06-28 15:13 ` Peter Maydell
2016-06-28 14:50 ` [Qemu-trivial] [PATCH 3/6] hw/bt: Don't use cpu_to_*w() and *_to_cpup() Peter Maydell
2016-06-28 14:50 ` [Qemu-devel] " Peter Maydell
2016-06-28 15:27 ` [Qemu-trivial] " Eric Blake
2016-06-28 15:27 ` Eric Blake
2016-06-28 14:50 ` [Qemu-trivial] [PATCH 4/6] bswap.h: Remove unused " Peter Maydell
2016-06-28 14:50 ` [Qemu-devel] " Peter Maydell
2016-06-28 15:38 ` [Qemu-trivial] " Eric Blake
2016-06-28 15:38 ` Eric Blake
2016-06-28 14:50 ` [Qemu-trivial] [PATCH 5/6] bswap.h: Fix comment typo Peter Maydell
2016-06-28 14:50 ` [Qemu-devel] " Peter Maydell
2016-06-28 15:05 ` [Qemu-trivial] " Stefan Weil
2016-06-28 15:05 ` Stefan Weil
2016-06-28 14:50 ` [Qemu-trivial] [PATCH 6/6] bswap.h: Document cpu_to_* and *_to_cpu conversion functions Peter Maydell
2016-06-28 14:50 ` [Qemu-devel] " Peter Maydell
2016-06-28 14:58 ` [Qemu-trivial] " Peter Maydell
2016-06-28 14:58 ` Peter Maydell
2016-06-28 15:40 ` [Qemu-trivial] " Eric Blake
2016-06-28 15:40 ` Eric Blake
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5772932B.1000302@redhat.com \
--to=eblake@redhat.com \
--cc=patches@linaro.org \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.