All of lore.kernel.org
 help / color / mirror / Atom feed
From: Arnd Bergmann <arnd@arndb.de>
To: Sudeep Holla <sudeep.holla@arm.com>
Cc: Jassi Brar <jaswinder.singh@linaro.org>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"ks.giri@samsung.com" <ks.giri@samsung.com>,
	"ijc+devicetree@hellion.org.uk" <ijc+devicetree@hellion.org.uk>,
	Mark Rutland <Mark.Rutland@arm.com>,
	"robh+dt@kernel.org" <robh+dt@kernel.org>,
	Pawel Moll <Pawel.Moll@arm.com>,
	"courtney.cavin@sonymobile.com" <courtney.cavin@sonymobile.com>,
	"mporter@linaro.org" <mporter@linaro.org>,
	"slapdau@yahoo.com.au" <slapdau@yahoo.com.au>,
	"lftan.linux@gmail.com" <lftan.linux@gmail.com>,
	"loic.pallardy@st.com" <loic.pallardy@st.com>,
	"s-anna@ti.com" <s-anna@ti.com>,
	"ashwin.chaugule@linaro.org" <ashwin.chaugule@linaro.org>,
	"bjorn@kryo.se" <bjorn@kryo.se>,
	"patches@linaro.org" <patches@linaro.org>,
	"Mollie.Wu@tw.fujitsu.com" <Mollie.Wu@tw.fujitsu.com>,
	t.takinishi@jp.fu
Subject: Re: [PATCHv8 2/2] mailbox: Introduce framework for mailbox
Date: Wed, 16 Jul 2014 13:32:44 +0200	[thread overview]
Message-ID: <5773443.uubaG3Evxs@wuerfel> (raw)
In-Reply-To: <53C65F22.20101@arm.com>

On Wednesday 16 July 2014 12:16:50 Sudeep Holla wrote:
> 
> Agreed if these mbox-names are more specific to attached devices and that
> was my initial understanding too. But I got confused when I saw something
> like below in the patch[1]
> 
> +       mhu: mhu0@2b1f0000 {
> +               #mbox-cells = <1>;
> +               compatible = "fujitsu,mhu";
> +               reg = <0 0x2B1F0000 0x1000>;
> +               interrupts = <0 36 4>, /* LP Non-Sec */
> +                            <0 35 4>, /* HP Non-Sec */
> +                            <0 37 4>; /* Secure */
> +       };
> +
> +       mhu_client: scb@0 {
> +               compatible = "fujitsu,scb";
> +               mbox = <&mhu 1>;
> +               mbox-names = "HP_NonSec";
> +       };
> 
> Here the name used is more controller specific.

The name is definitely specific to the client, not the master. The
string "HP_NonSec" should be required in the binding for the "fujitsu,scb"
device here, and the scb driver should pass that hardcoded string
to the mailbox API to ask for a channel.

	Arnd

WARNING: multiple messages have this Message-ID (diff)
From: Arnd Bergmann <arnd@arndb.de>
To: Sudeep Holla <sudeep.holla@arm.com>
Cc: Jassi Brar <jaswinder.singh@linaro.org>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"ks.giri@samsung.com" <ks.giri@samsung.com>,
	"ijc+devicetree@hellion.org.uk" <ijc+devicetree@hellion.org.uk>,
	Mark Rutland <Mark.Rutland@arm.com>,
	"robh+dt@kernel.org" <robh+dt@kernel.org>,
	Pawel Moll <Pawel.Moll@arm.com>,
	"courtney.cavin@sonymobile.com" <courtney.cavin@sonymobile.com>,
	"mporter@linaro.org" <mporter@linaro.org>,
	"slapdau@yahoo.com.au" <slapdau@yahoo.com.au>,
	"lftan.linux@gmail.com" <lftan.linux@gmail.com>,
	"loic.pallardy@st.com" <loic.pallardy@st.com>,
	"s-anna@ti.com" <s-anna@ti.com>,
	"ashwin.chaugule@linaro.org" <ashwin.chaugule@linaro.org>,
	"bjorn@kryo.se" <bjorn@kryo.se>,
	"patches@linaro.org" <patches@linaro.org>,
	"Mollie.Wu@tw.fujitsu.com" <Mollie.Wu@tw.fujitsu.com>,
	"t.takinishi@jp.fujitsu.com" <t.takinishi@jp.fujitsu.com>
Subject: Re: [PATCHv8 2/2] mailbox: Introduce framework for mailbox
Date: Wed, 16 Jul 2014 13:32:44 +0200	[thread overview]
Message-ID: <5773443.uubaG3Evxs@wuerfel> (raw)
In-Reply-To: <53C65F22.20101@arm.com>

On Wednesday 16 July 2014 12:16:50 Sudeep Holla wrote:
> 
> Agreed if these mbox-names are more specific to attached devices and that
> was my initial understanding too. But I got confused when I saw something
> like below in the patch[1]
> 
> +       mhu: mhu0@2b1f0000 {
> +               #mbox-cells = <1>;
> +               compatible = "fujitsu,mhu";
> +               reg = <0 0x2B1F0000 0x1000>;
> +               interrupts = <0 36 4>, /* LP Non-Sec */
> +                            <0 35 4>, /* HP Non-Sec */
> +                            <0 37 4>; /* Secure */
> +       };
> +
> +       mhu_client: scb@0 {
> +               compatible = "fujitsu,scb";
> +               mbox = <&mhu 1>;
> +               mbox-names = "HP_NonSec";
> +       };
> 
> Here the name used is more controller specific.

The name is definitely specific to the client, not the master. The
string "HP_NonSec" should be required in the binding for the "fujitsu,scb"
device here, and the scb driver should pass that hardcoded string
to the mailbox API to ask for a channel.

	Arnd

  reply	other threads:[~2014-07-16 11:32 UTC|newest]

Thread overview: 48+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-07-11  9:32 [PATCHv8 0/2] Common Mailbox Framework Jassi Brar
2014-07-11  9:32 ` Jassi Brar
     [not found] ` <1405071167-14503-1-git-send-email-jaswinder.singh-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2014-07-11  9:34   ` [PATCHv8 1/2] mailbox: rename pl320-ipc specific mailbox.h Jassi Brar
2014-07-11  9:34     ` Jassi Brar
     [not found]     ` <1405071252-14630-1-git-send-email-jaswinder.singh-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2014-07-11 17:12       ` Arnd Bergmann
2014-07-11 17:12         ` Arnd Bergmann
2014-07-11  9:35 ` [PATCHv8 2/2] mailbox: Introduce framework for mailbox Jassi Brar
     [not found]   ` <1405071325-14683-1-git-send-email-jaswinder.singh-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2014-07-11 11:46     ` Ashwin Chaugule
2014-07-11 11:46       ` Ashwin Chaugule
     [not found]       ` <CAJ5Y-eYPffYQ57ERODyBYYKjL2FVhGapKmP0YxzcT9rswfaJaA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2014-07-14  4:17         ` Jassi Brar
2014-07-14  4:17           ` Jassi Brar
     [not found]           ` <CAJe_Zhe5W4D+TzyfKdE8KvSc8SJwyHG3SQGpUyd8-ML-wHBDyg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2014-07-14  8:04             ` Ashwin Chaugule
2014-07-14  8:04               ` Ashwin Chaugule
2014-07-16  9:40     ` Sudeep Holla
2014-07-16  9:40       ` Sudeep Holla
     [not found]       ` <53C64883.2050709-5wv7dgnIgG8@public.gmane.org>
2014-07-16 10:16         ` Arnd Bergmann
2014-07-16 10:16           ` Arnd Bergmann
2014-07-16 11:16           ` Sudeep Holla
2014-07-16 11:16             ` Sudeep Holla
2014-07-16 11:32             ` Arnd Bergmann [this message]
2014-07-16 11:32               ` Arnd Bergmann
2014-07-16 13:29               ` Sudeep Holla
2014-07-16 13:29                 ` Sudeep Holla
2014-07-16 12:37           ` Jassi Brar
2014-07-16 12:37             ` Jassi Brar
     [not found]             ` <CAJe_ZheAjhufEf3c72bwbvF11P070hxh0qZ9s5KDxwFUgH1ixg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2014-07-16 12:45               ` Arnd Bergmann
2014-07-16 12:45                 ` Arnd Bergmann
2014-07-16 13:05                 ` Jassi Brar
2014-07-16 13:05                   ` Jassi Brar
2014-07-16 13:09                   ` Arnd Bergmann
2014-07-16 13:09                     ` Arnd Bergmann
2014-07-16 13:12                     ` Jassi Brar
2014-07-16 13:12                       ` Jassi Brar
2014-07-16 14:08                       ` Arnd Bergmann
2014-07-16 14:08                         ` Arnd Bergmann
2014-07-16 14:18                         ` Jassi Brar
2014-07-16 14:18                           ` Jassi Brar
2014-07-16 16:09                           ` Suman Anna
     [not found]                             ` <53C6A3CB.5060005-l0cyMroinI0@public.gmane.org>
2014-07-17  7:25                               ` Jassi Brar
2014-07-17  7:25                                 ` Jassi Brar
2014-07-16 14:34                         ` Sudeep Holla
2014-07-16 14:34                           ` Sudeep Holla
2014-07-11 17:26   ` Arnd Bergmann
     [not found]     ` <201407111926.13939.arnd-r2nGTMty4D4@public.gmane.org>
2014-07-14  5:40       ` Jassi Brar
2014-07-14  5:40         ` Jassi Brar
2014-07-11 22:09   ` Markus Mayer
     [not found]     ` <CAPdLdqmBUFaCjdLrYJh3P2jizYC3GP0g7ut+FNaLQ5a73gMp0w-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2014-07-14  4:56       ` Jassi Brar
2014-07-14  4:56         ` Jassi Brar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5773443.uubaG3Evxs@wuerfel \
    --to=arnd@arndb.de \
    --cc=Mark.Rutland@arm.com \
    --cc=Mollie.Wu@tw.fujitsu.com \
    --cc=Pawel.Moll@arm.com \
    --cc=ashwin.chaugule@linaro.org \
    --cc=bjorn@kryo.se \
    --cc=courtney.cavin@sonymobile.com \
    --cc=devicetree@vger.kernel.org \
    --cc=ijc+devicetree@hellion.org.uk \
    --cc=jaswinder.singh@linaro.org \
    --cc=ks.giri@samsung.com \
    --cc=lftan.linux@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=loic.pallardy@st.com \
    --cc=mporter@linaro.org \
    --cc=patches@linaro.org \
    --cc=robh+dt@kernel.org \
    --cc=s-anna@ti.com \
    --cc=slapdau@yahoo.com.au \
    --cc=sudeep.holla@arm.com \
    --cc=t.takinishi@jp.fu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.