From: Keerthy <a0393675@ti.com>
To: Manish Badarkhe <badarkhe.manish@gmail.com>, Keerthy <j-keerthy@ti.com>
Cc: linus.walleij@linaro.org, gnurou@gmail.com,
Lee Jones <lee.jones@linaro.org>,
linux-omap@vger.kernel.org,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
linux-gpio@vger.kernel.org, Mark Brown <broonie@kernel.org>,
robh+dt@kernel.org, Tony Lindgren <tony@atomide.com>
Subject: Re: [PATCH v4 3/3] gpio: lp873x: Add support for General Purpose Outputs
Date: Wed, 29 Jun 2016 18:10:08 +0530 [thread overview]
Message-ID: <5773C1A8.2070504@ti.com> (raw)
In-Reply-To: <CAKDJKT4yNAO6OdYTtWQ3W-aNvvFb46p8=g02grvz07af-jTjyw@mail.gmail.com>
On Wednesday 29 June 2016 04:15 PM, Manish Badarkhe wrote:
> Hi Keerthy,
>
> sorry ignore my last two comments in previous mail.
>
> On Wed, Jun 29, 2016 at 4:13 PM, Manish Badarkhe
> <badarkhe.manish@gmail.com> wrote:
>> Hi Keerthy
>>
>> Some minor comment
>>
>>> +static int lp873x_gpio_direction_output(struct gpio_chip *chip,
>>> + unsigned int offset, int value)
>>> +{
>>> + struct lp873x_gpio *gpio = gpiochip_get_data(chip);
>>> +
>>> + /* Set the initial value */
>>> + regmap_update_bits(gpio->lp873->regmap, LP873X_REG_GPO_CTRL,
>>> + BIT(offset * 4), value ? BIT(offset * 4) : 0);
>>> +
>>> + return 0;
>>> +}
>
> Error needs to be return, this function always return 0.
Yes! I can just do:
return regmap_update_bits(gpio->lp873->regmap, LP873X_REG_GPO_CTRL,
BIT(offset * 4), value ? BIT(offset * 4) : 0);
>
> Regards
> Manish Badarkhe
>
WARNING: multiple messages have this Message-ID (diff)
From: Keerthy <a0393675@ti.com>
To: Manish Badarkhe <badarkhe.manish@gmail.com>, Keerthy <j-keerthy@ti.com>
Cc: <linus.walleij@linaro.org>, <gnurou@gmail.com>,
Lee Jones <lee.jones@linaro.org>, <linux-omap@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
<linux-gpio@vger.kernel.org>, Mark Brown <broonie@kernel.org>,
<robh+dt@kernel.org>, Tony Lindgren <tony@atomide.com>
Subject: Re: [PATCH v4 3/3] gpio: lp873x: Add support for General Purpose Outputs
Date: Wed, 29 Jun 2016 18:10:08 +0530 [thread overview]
Message-ID: <5773C1A8.2070504@ti.com> (raw)
In-Reply-To: <CAKDJKT4yNAO6OdYTtWQ3W-aNvvFb46p8=g02grvz07af-jTjyw@mail.gmail.com>
On Wednesday 29 June 2016 04:15 PM, Manish Badarkhe wrote:
> Hi Keerthy,
>
> sorry ignore my last two comments in previous mail.
>
> On Wed, Jun 29, 2016 at 4:13 PM, Manish Badarkhe
> <badarkhe.manish@gmail.com> wrote:
>> Hi Keerthy
>>
>> Some minor comment
>>
>>> +static int lp873x_gpio_direction_output(struct gpio_chip *chip,
>>> + unsigned int offset, int value)
>>> +{
>>> + struct lp873x_gpio *gpio = gpiochip_get_data(chip);
>>> +
>>> + /* Set the initial value */
>>> + regmap_update_bits(gpio->lp873->regmap, LP873X_REG_GPO_CTRL,
>>> + BIT(offset * 4), value ? BIT(offset * 4) : 0);
>>> +
>>> + return 0;
>>> +}
>
> Error needs to be return, this function always return 0.
Yes! I can just do:
return regmap_update_bits(gpio->lp873->regmap, LP873X_REG_GPO_CTRL,
BIT(offset * 4), value ? BIT(offset * 4) : 0);
>
> Regards
> Manish Badarkhe
>
next prev parent reply other threads:[~2016-06-29 12:40 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-29 9:30 [PATCH v4 0/3] mfd: lp873x: Add lp873x PMIC support Keerthy
2016-06-29 9:30 ` Keerthy
2016-06-29 9:30 ` [PATCH v4 1/3] Documentation: mfd: LP873X: Add information for the mfd driver Keerthy
2016-06-29 9:30 ` Keerthy
2016-06-29 9:30 ` [PATCH v4 2/3] mfd: lp873x: Add lp873x PMIC support Keerthy
2016-06-29 9:30 ` Keerthy
2016-06-29 9:30 ` [PATCH v4 3/3] gpio: lp873x: Add support for General Purpose Outputs Keerthy
2016-06-29 9:30 ` Keerthy
2016-06-29 10:43 ` Manish Badarkhe
2016-06-29 10:45 ` Manish Badarkhe
2016-06-29 12:40 ` Keerthy [this message]
2016-06-29 12:40 ` Keerthy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5773C1A8.2070504@ti.com \
--to=a0393675@ti.com \
--cc=badarkhe.manish@gmail.com \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=gnurou@gmail.com \
--cc=j-keerthy@ti.com \
--cc=lee.jones@linaro.org \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.