All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andreas Ziegler <andreas.ziegler@fau.de>
To: "Naveen N. Rao" <naveen.n.rao@linux.vnet.ibm.com>
Cc: Michael Ellerman <mpe@ellerman.id.au>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCHv2 0/7] eBPF JIT for PPC64
Date: Thu, 30 Jun 2016 11:06:04 +0200	[thread overview]
Message-ID: <5774E0FC.7010407@fau.de> (raw)
In-Reply-To: <cover.1466612260.git.naveen.n.rao@linux.vnet.ibm.com>

Hi Naveen,

this patchset makes a change to arch/powerpc/net/Makefile in order to only
compile the previously existing bpf_jit_comp.c if !CONFIG_PPC64, and use
bpf_jit_comp64.c if CONFIG_PPC64 is enabled.

Inside arch/powerpc/net/bpf_jit_comp.c, however, there is still an #ifdef
CONFIG_PPC64 block at line 667 (linux-next of today, i.e., next-20160630):

  #ifdef CONFIG_PPC64
                  /* Function descriptor nastiness: Address + TOC */
                  ((u64 *)image)[0] = (u64)code_base;
                  ((u64 *)image)[1] = local_paca->kernel_toc;
  #endif

>From my understanding of the code, this #ifdef can now be removed, as there is
no way the file could be compiled with CONFIG_PPC64 enabled. Is this correct?

Best regards,

Andreas

  parent reply	other threads:[~2016-06-30  9:13 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-06-22 16:25 [PATCHv2 0/7] eBPF JIT for PPC64 Naveen N. Rao
2016-06-22 16:25 ` [PATCHv2 1/7] ppc bpf/jit: Disable classic BPF JIT on ppc64le Naveen N. Rao
2016-06-22 16:50   ` Thadeu Lima de Souza Cascardo
2016-06-23  9:26   ` [PATCHv2,1/7] " Michael Ellerman
2016-06-22 16:25 ` [PATCHv2 2/7] ppc: bpf/jit: Fix/enhance 32-bit Load Immediate implementation Naveen N. Rao
2016-06-28 12:10   ` [PATCHv2, " Michael Ellerman
2016-06-22 16:25 ` [PATCHv2 3/7] ppc: bpf/jit: Optimize 64-bit Immediate loads Naveen N. Rao
2016-06-22 16:25 ` [PATCHv2 4/7] ppc: bpf/jit: Introduce rotate immediate instructions Naveen N. Rao
2016-06-22 16:25 ` [PATCHv2 5/7] ppc: bpf/jit: A few cleanups Naveen N. Rao
2016-06-22 16:25 ` [PATCHv2 6/7] ppc: bpf/jit: Isolate classic BPF JIT specifics into a separate header Naveen N. Rao
2016-06-22 16:25 ` [PATCHv2 7/7] ppc: ebpf/jit: Implement JIT compiler for extended BPF Naveen N. Rao
2016-06-30  9:06 ` Andreas Ziegler [this message]
2016-06-30  9:34   ` [PATCHv2 0/7] eBPF JIT for PPC64 Denis Kirjanov
2016-06-30 10:32     ` Naveen N. Rao

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5774E0FC.7010407@fau.de \
    --to=andreas.ziegler@fau.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=mpe@ellerman.id.au \
    --cc=naveen.n.rao@linux.vnet.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.