From: Arnd Bergmann <arnd@arndb.de>
To: outreachy-kernel@googlegroups.com
Cc: Eva Rachel Retuya <eraretuya@gmail.com>
Subject: Re: [Outreachy kernel] [PATCH] Staging: mt29f_spinand: Replace udelay function with usleep_range
Date: Fri, 30 Oct 2015 22:32:40 +0100 [thread overview]
Message-ID: <5775905.RiZkvh7Klu@wuerfel> (raw)
In-Reply-To: <1445707491-28304-1-git-send-email-eraretuya@gmail.com>
On Sunday 25 October 2015 01:24:51 Eva Rachel Retuya wrote:
> Use 'usleep_range' instead of 'udelay' to elapse time. For
> spinand_reset, define the upper limit by a factor of 2 to keep the wait
> short while still allowing a "good enough" range for wakeup. Define the
> range 250us - 1ms for spinand_cmdfunc to provide enough leeway before
> issuing spinand_reset. Checkpatch found this issue.
>
> CHECK: usleep_range is preferred over udelay; see
> Documentation/timers/timers-howto.txt
You are missing here an explanation about how you verified that the
conversion is safe: Are you sure that the spinand_reset() function
is never called from "atomic" context?
Arnd
next prev parent reply other threads:[~2015-10-30 21:32 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-24 17:24 [PATCH] Staging: mt29f_spinand: Replace udelay function with usleep_range Eva Rachel Retuya
2015-10-30 21:32 ` Arnd Bergmann [this message]
2015-10-31 8:53 ` [Outreachy kernel] " Eva Rachel Retuya
2015-11-02 20:12 ` Arnd Bergmann
2015-11-05 18:19 ` Eva Rachel Retuya
2015-11-05 18:48 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5775905.RiZkvh7Klu@wuerfel \
--to=arnd@arndb.de \
--cc=eraretuya@gmail.com \
--cc=outreachy-kernel@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.