From: Arnd Bergmann <arnd@arndb.de>
To: Eva Rachel Retuya <eraretuya@gmail.com>
Cc: outreachy-kernel@googlegroups.com
Subject: Re: [Outreachy kernel] [PATCH] Staging: mt29f_spinand: Replace udelay function with usleep_range
Date: Thu, 05 Nov 2015 19:48:37 +0100 [thread overview]
Message-ID: <6220768.i1voOuvBYI@wuerfel> (raw)
In-Reply-To: <20151105181955.GA6328@Socrates-Mint>
On Friday 06 November 2015 02:19:59 Eva Rachel Retuya wrote:
>
> The change from udelay to usleep is a safe conversion because the
> spinand_reset() calls spinand_cmd(). The return value of the latter
> depends on the return value of spi_sync() which is a function that is
> allowed to sleep therefore, I have confirmed that spinand_reset() is
> not in atomic context.
>
> I hope I got it right this time. Thank you for bringing this up.
>
Yes, very good. FWIW, the wait_till_ready() function also sleeps
when it calls cond_resched().
Arnd
prev parent reply other threads:[~2015-11-05 18:48 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-24 17:24 [PATCH] Staging: mt29f_spinand: Replace udelay function with usleep_range Eva Rachel Retuya
2015-10-30 21:32 ` [Outreachy kernel] " Arnd Bergmann
2015-10-31 8:53 ` Eva Rachel Retuya
2015-11-02 20:12 ` Arnd Bergmann
2015-11-05 18:19 ` Eva Rachel Retuya
2015-11-05 18:48 ` Arnd Bergmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6220768.i1voOuvBYI@wuerfel \
--to=arnd@arndb.de \
--cc=eraretuya@gmail.com \
--cc=outreachy-kernel@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.