Re: [PATCH v3] kasan/quarantine: fix bugs on qlist_move_cache()

[Andrey Ryabinin <aryabinin@virtuozzo.com>]

On 07/01/2016 05:15 PM, Dmitry Vyukov wrote:
> On Fri, Jul 1, 2016 at 4:09 PM, Joonsoo Kim <js1304@gmail.com> wrote:
>> 2016-07-01 23:03 GMT+09:00 Dmitry Vyukov <dvyukov@google.com>:

>>>> +
>>>> +               if (obj_cache == cache)
>>>> +                       qlist_put(to, qlink, cache->size);
>>>> +               else
>>>> +                       qlist_put(from, qlink, cache->size);
>>>
>>> This line is wrong. If obj_cache != cache, object size != cache->size.
>>> Quarantine contains objects of different sizes.
>>
>> You're right. 11 pm is not good time to work. :/
>> If it is fixed, the patch looks correct to you?
>> I will fix it and send v4 on next week.
> 
> 
> I don't see anything else wrong. But I need to see how you fix the size issue.
> Performance of this operation is not particularly critical, so the
> simpler the better.

Is there any other way besides obvious: s/cache->size/obj_cache->size ?

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>