From: Jeremy Linton <jeremy.linton@arm.com>
To: Punit Agrawal <punit.agrawal@arm.com>
Cc: mark.rutland@arm.com, Lorenzo.Pieralisi@arm.com,
linux-acpi@vger.kernel.org, alexander.shishkin@linux.intel.com,
catalin.marinas@arm.com, Steve.Capper@arm.com,
will.deacon@arm.com, acme@kernel.org, mlangsdorf@redhat.com,
peterz@infradead.org, mingo@redhat.com,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 09/11] arm64: pmu: Add routines for detecting differing PMU types in the system
Date: Fri, 1 Jul 2016 10:28:05 -0500 [thread overview]
Message-ID: <57768C05.1050509@arm.com> (raw)
In-Reply-To: <87mvm1e9ye.fsf@e105922-lin.cambridge.arm.com>
On 07/01/2016 08:58 AM, Punit Agrawal wrote:
(trimming)
>> + if (!pmu) {
>> + pr_warn("Unable to allocate pmu_types\n");
>
> Bail out with error if the memory can't be allocated. Otherwise, we risk
> silently failing to register a PMU type.
Reading this again, I think I misunderstood what you were saying.. Aka,
this should be pr_error() not that the error handing is failing to catch
the failure.
Anyway, I will promote this.
WARNING: multiple messages have this Message-ID (diff)
From: jeremy.linton@arm.com (Jeremy Linton)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 09/11] arm64: pmu: Add routines for detecting differing PMU types in the system
Date: Fri, 1 Jul 2016 10:28:05 -0500 [thread overview]
Message-ID: <57768C05.1050509@arm.com> (raw)
In-Reply-To: <87mvm1e9ye.fsf@e105922-lin.cambridge.arm.com>
On 07/01/2016 08:58 AM, Punit Agrawal wrote:
(trimming)
>> + if (!pmu) {
>> + pr_warn("Unable to allocate pmu_types\n");
>
> Bail out with error if the memory can't be allocated. Otherwise, we risk
> silently failing to register a PMU type.
Reading this again, I think I misunderstood what you were saying.. Aka,
this should be pr_error() not that the error handing is failing to catch
the failure.
Anyway, I will promote this.
next prev parent reply other threads:[~2016-07-01 15:28 UTC|newest]
Thread overview: 52+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-21 17:11 [PATCH v6 00/11] Enable PMUs in ACPI systems Jeremy Linton
2016-06-21 17:11 ` Jeremy Linton
2016-06-21 17:11 ` [PATCH 01/11] arm64: pmu: add fallback probe table Jeremy Linton
2016-06-21 17:11 ` Jeremy Linton
2016-06-21 17:11 ` [PATCH 02/11] arm64: pmu: Probe default hw/cache counters Jeremy Linton
2016-06-21 17:11 ` Jeremy Linton
2016-06-21 17:11 ` [PATCH 03/11] arm64: pmu: Hoist pmu platform device name Jeremy Linton
2016-06-21 17:11 ` Jeremy Linton
2016-06-21 17:11 ` [PATCH 04/11] arm64: Rename the common MADT parse routine Jeremy Linton
2016-06-21 17:11 ` Jeremy Linton
2016-06-21 17:11 ` [PATCH 05/11] arm64: pmu: Add support for probing with ACPI Jeremy Linton
2016-06-21 17:11 ` Jeremy Linton
2016-07-06 16:45 ` Will Deacon
2016-07-06 16:45 ` Will Deacon
2016-06-21 17:11 ` [PATCH 06/11] arm: arm64: Add routine to determine cpuid of other cpus Jeremy Linton
2016-06-21 17:11 ` Jeremy Linton
2016-07-06 16:30 ` Will Deacon
2016-07-06 16:30 ` Will Deacon
2016-07-07 0:34 ` Jeremy Linton
2016-07-07 0:34 ` Jeremy Linton
2016-06-21 17:11 ` [PATCH 07/11] arm: arm64: pmu: Assign platform PMU CPU affinity Jeremy Linton
2016-06-21 17:11 ` Jeremy Linton
2016-07-01 14:00 ` Punit Agrawal
2016-07-01 14:00 ` Punit Agrawal
2016-06-21 17:11 ` [PATCH 08/11] arm64: pmu: Provide cpumask attribute for PMU Jeremy Linton
2016-06-21 17:11 ` Jeremy Linton
2016-07-07 16:21 ` Mark Rutland
2016-07-07 16:21 ` Mark Rutland
2016-07-11 15:05 ` Jeremy Linton
2016-07-11 15:05 ` Jeremy Linton
2016-07-11 15:58 ` Mark Rutland
2016-07-11 15:58 ` Mark Rutland
2016-07-11 16:14 ` Will Deacon
2016-07-11 16:14 ` Will Deacon
2016-06-21 17:11 ` [PATCH 09/11] arm64: pmu: Add routines for detecting differing PMU types in the system Jeremy Linton
2016-06-21 17:11 ` Jeremy Linton
2016-07-01 13:58 ` Punit Agrawal
2016-07-01 13:58 ` Punit Agrawal
2016-07-01 14:54 ` Jeremy Linton
2016-07-01 14:54 ` Jeremy Linton
2016-07-01 15:43 ` Punit Agrawal
2016-07-01 15:43 ` Punit Agrawal
2016-07-01 16:21 ` Jeremy Linton
2016-07-01 16:21 ` Jeremy Linton
2016-07-01 15:28 ` Jeremy Linton [this message]
2016-07-01 15:28 ` Jeremy Linton
2016-06-21 17:11 ` [PATCH 10/11] arm64: pmu: Enable multiple PMUs in an ACPI system Jeremy Linton
2016-06-21 17:11 ` Jeremy Linton
2016-07-01 13:57 ` Punit Agrawal
2016-07-01 13:57 ` Punit Agrawal
2016-06-21 17:11 ` [PATCH 11/11] MAINTAINERS: Tweak ARM PMU maintainers Jeremy Linton
2016-06-21 17:11 ` Jeremy Linton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=57768C05.1050509@arm.com \
--to=jeremy.linton@arm.com \
--cc=Lorenzo.Pieralisi@arm.com \
--cc=Steve.Capper@arm.com \
--cc=acme@kernel.org \
--cc=alexander.shishkin@linux.intel.com \
--cc=catalin.marinas@arm.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=mark.rutland@arm.com \
--cc=mingo@redhat.com \
--cc=mlangsdorf@redhat.com \
--cc=peterz@infradead.org \
--cc=punit.agrawal@arm.com \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.