* [PATCH 0/2] mmc: sdhci-iproc: Use defines instead of magic numbers
@ 2016-07-02 19:23 ` Stefan Wahren
0 siblings, 0 replies; 12+ messages in thread
From: Stefan Wahren @ 2016-07-02 19:23 UTC (permalink / raw)
To: linux-arm-kernel
Hi,
this small patch series should make the sdhci-iproc platform data easier
to read. Since i don't have the adequate hardware it's only compile tested.
Stefan
Stefan Wahren (2):
mmc: sdhci: add define for suspend/resume capability
mmc: sdhci-iproc: Use defines instead of magic numbers
drivers/mmc/host/sdhci-iproc.c | 13 +++++++++++--
drivers/mmc/host/sdhci.h | 1 +
2 files changed, 12 insertions(+), 2 deletions(-)
--
1.7.9.5
^ permalink raw reply [flat|nested] 12+ messages in thread
* [PATCH 1/2] mmc: sdhci: add define for suspend/resume capability
2016-07-02 19:23 ` Stefan Wahren
@ 2016-07-02 19:23 ` Stefan Wahren
-1 siblings, 0 replies; 12+ messages in thread
From: Stefan Wahren @ 2016-07-02 19:23 UTC (permalink / raw)
To: Ray Jui, Scott Branden, Jon Mason
Cc: Stefan Wahren, Ulf Hansson, linux-mmc, Adrian Hunter,
bcm-kernel-feedback-list, linux-arm-kernel
This patch adds the missing define for the suspend/resume
capability (according to SD Host Controller spec).
Signed-off-by: Stefan Wahren <stefan.wahren@i2se.com>
---
drivers/mmc/host/sdhci.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/mmc/host/sdhci.h b/drivers/mmc/host/sdhci.h
index 609f87c..42584f0 100644
--- a/drivers/mmc/host/sdhci.h
+++ b/drivers/mmc/host/sdhci.h
@@ -186,6 +186,7 @@
#define SDHCI_CAN_DO_ADMA1 0x00100000
#define SDHCI_CAN_DO_HISPD 0x00200000
#define SDHCI_CAN_DO_SDMA 0x00400000
+#define SDHCI_CAN_DO_SUSPEND 0x00800000
#define SDHCI_CAN_VDD_330 0x01000000
#define SDHCI_CAN_VDD_300 0x02000000
#define SDHCI_CAN_VDD_180 0x04000000
--
1.7.9.5
^ permalink raw reply related [flat|nested] 12+ messages in thread
* [PATCH 1/2] mmc: sdhci: add define for suspend/resume capability
@ 2016-07-02 19:23 ` Stefan Wahren
0 siblings, 0 replies; 12+ messages in thread
From: Stefan Wahren @ 2016-07-02 19:23 UTC (permalink / raw)
To: linux-arm-kernel
This patch adds the missing define for the suspend/resume
capability (according to SD Host Controller spec).
Signed-off-by: Stefan Wahren <stefan.wahren@i2se.com>
---
drivers/mmc/host/sdhci.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/mmc/host/sdhci.h b/drivers/mmc/host/sdhci.h
index 609f87c..42584f0 100644
--- a/drivers/mmc/host/sdhci.h
+++ b/drivers/mmc/host/sdhci.h
@@ -186,6 +186,7 @@
#define SDHCI_CAN_DO_ADMA1 0x00100000
#define SDHCI_CAN_DO_HISPD 0x00200000
#define SDHCI_CAN_DO_SDMA 0x00400000
+#define SDHCI_CAN_DO_SUSPEND 0x00800000
#define SDHCI_CAN_VDD_330 0x01000000
#define SDHCI_CAN_VDD_300 0x02000000
#define SDHCI_CAN_VDD_180 0x04000000
--
1.7.9.5
^ permalink raw reply related [flat|nested] 12+ messages in thread
* [PATCH 2/2] mmc: sdhci-iproc: Use defines instead of magic numbers
2016-07-02 19:23 ` Stefan Wahren
@ 2016-07-02 19:23 ` Stefan Wahren
-1 siblings, 0 replies; 12+ messages in thread
From: Stefan Wahren @ 2016-07-02 19:23 UTC (permalink / raw)
To: Ray Jui, Scott Branden, Jon Mason
Cc: Stefan Wahren, Ulf Hansson, linux-mmc, Adrian Hunter,
bcm-kernel-feedback-list, linux-arm-kernel
The capabilities in iproc platform data are magic numbers. So
replace them with the proper capability defines to make it
readable.
Signed-off-by: Stefan Wahren <stefan.wahren@i2se.com>
---
drivers/mmc/host/sdhci-iproc.c | 13 +++++++++++--
1 file changed, 11 insertions(+), 2 deletions(-)
diff --git a/drivers/mmc/host/sdhci-iproc.c b/drivers/mmc/host/sdhci-iproc.c
index 1110f73..53abecc 100644
--- a/drivers/mmc/host/sdhci-iproc.c
+++ b/drivers/mmc/host/sdhci-iproc.c
@@ -164,8 +164,17 @@ static const struct sdhci_pltfm_data sdhci_iproc_pltfm_data = {
static const struct sdhci_iproc_data iproc_data = {
.pdata = &sdhci_iproc_pltfm_data,
- .caps = 0x05E90000,
- .caps1 = 0x00000064,
+ .caps = ((0x1 << SDHCI_MAX_BLOCK_SHIFT)
+ & SDHCI_MAX_BLOCK_MASK) |
+ SDHCI_CAN_VDD_330 |
+ SDHCI_CAN_VDD_180 |
+ SDHCI_CAN_DO_SUSPEND |
+ SDHCI_CAN_DO_HISPD |
+ SDHCI_CAN_DO_ADMA2 |
+ SDHCI_CAN_DO_SDMA,
+ .caps1 = SDHCI_DRIVER_TYPE_C |
+ SDHCI_DRIVER_TYPE_D |
+ SDHCI_SUPPORT_DDR50,
.mmc_caps = MMC_CAP_1_8V_DDR,
};
--
1.7.9.5
^ permalink raw reply related [flat|nested] 12+ messages in thread* [PATCH 2/2] mmc: sdhci-iproc: Use defines instead of magic numbers
@ 2016-07-02 19:23 ` Stefan Wahren
0 siblings, 0 replies; 12+ messages in thread
From: Stefan Wahren @ 2016-07-02 19:23 UTC (permalink / raw)
To: linux-arm-kernel
The capabilities in iproc platform data are magic numbers. So
replace them with the proper capability defines to make it
readable.
Signed-off-by: Stefan Wahren <stefan.wahren@i2se.com>
---
drivers/mmc/host/sdhci-iproc.c | 13 +++++++++++--
1 file changed, 11 insertions(+), 2 deletions(-)
diff --git a/drivers/mmc/host/sdhci-iproc.c b/drivers/mmc/host/sdhci-iproc.c
index 1110f73..53abecc 100644
--- a/drivers/mmc/host/sdhci-iproc.c
+++ b/drivers/mmc/host/sdhci-iproc.c
@@ -164,8 +164,17 @@ static const struct sdhci_pltfm_data sdhci_iproc_pltfm_data = {
static const struct sdhci_iproc_data iproc_data = {
.pdata = &sdhci_iproc_pltfm_data,
- .caps = 0x05E90000,
- .caps1 = 0x00000064,
+ .caps = ((0x1 << SDHCI_MAX_BLOCK_SHIFT)
+ & SDHCI_MAX_BLOCK_MASK) |
+ SDHCI_CAN_VDD_330 |
+ SDHCI_CAN_VDD_180 |
+ SDHCI_CAN_DO_SUSPEND |
+ SDHCI_CAN_DO_HISPD |
+ SDHCI_CAN_DO_ADMA2 |
+ SDHCI_CAN_DO_SDMA,
+ .caps1 = SDHCI_DRIVER_TYPE_C |
+ SDHCI_DRIVER_TYPE_D |
+ SDHCI_SUPPORT_DDR50,
.mmc_caps = MMC_CAP_1_8V_DDR,
};
--
1.7.9.5
^ permalink raw reply related [flat|nested] 12+ messages in thread
* Re: [PATCH 0/2] mmc: sdhci-iproc: Use defines instead of magic numbers
2016-07-02 19:23 ` Stefan Wahren
@ 2016-07-04 17:02 ` Scott Branden
-1 siblings, 0 replies; 12+ messages in thread
From: Scott Branden @ 2016-07-04 17:02 UTC (permalink / raw)
To: Stefan Wahren, Ray Jui, Scott Branden, Jon Mason
Cc: bcm-kernel-feedback-list, Ulf Hansson, linux-mmc, Adrian Hunter,
linux-arm-kernel
Hi Stefan,
On 16-07-02 12:23 PM, Stefan Wahren wrote:
> Hi,
>
> this small patch series should make the sdhci-iproc platform data easier
> to read. Since i don't have the adequate hardware it's only compile tested.
>
> Stefan
>
> Stefan Wahren (2):
> mmc: sdhci: add define for suspend/resume capability
> mmc: sdhci-iproc: Use defines instead of magic numbers
>
> drivers/mmc/host/sdhci-iproc.c | 13 +++++++++++--
> drivers/mmc/host/sdhci.h | 1 +
> 2 files changed, 12 insertions(+), 2 deletions(-)
>
Patch series looks fine.
Acked-by: Scott Branden <scott.branden@broadcom.com>
^ permalink raw reply [flat|nested] 12+ messages in thread
* [PATCH 0/2] mmc: sdhci-iproc: Use defines instead of magic numbers
@ 2016-07-04 17:02 ` Scott Branden
0 siblings, 0 replies; 12+ messages in thread
From: Scott Branden @ 2016-07-04 17:02 UTC (permalink / raw)
To: linux-arm-kernel
Hi Stefan,
On 16-07-02 12:23 PM, Stefan Wahren wrote:
> Hi,
>
> this small patch series should make the sdhci-iproc platform data easier
> to read. Since i don't have the adequate hardware it's only compile tested.
>
> Stefan
>
> Stefan Wahren (2):
> mmc: sdhci: add define for suspend/resume capability
> mmc: sdhci-iproc: Use defines instead of magic numbers
>
> drivers/mmc/host/sdhci-iproc.c | 13 +++++++++++--
> drivers/mmc/host/sdhci.h | 1 +
> 2 files changed, 12 insertions(+), 2 deletions(-)
>
Patch series looks fine.
Acked-by: Scott Branden <scott.branden@broadcom.com>
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH 0/2] mmc: sdhci-iproc: Use defines instead of magic numbers
2016-07-04 17:02 ` Scott Branden
@ 2016-07-05 6:06 ` Adrian Hunter
-1 siblings, 0 replies; 12+ messages in thread
From: Adrian Hunter @ 2016-07-05 6:06 UTC (permalink / raw)
To: Scott Branden, Stefan Wahren, Ray Jui, Scott Branden, Jon Mason
Cc: Ulf Hansson, linux-arm-kernel, linux-mmc,
bcm-kernel-feedback-list
On 04/07/16 20:02, Scott Branden wrote:
> Hi Stefan,
>
> On 16-07-02 12:23 PM, Stefan Wahren wrote:
>> Hi,
>>
>> this small patch series should make the sdhci-iproc platform data easier
>> to read. Since i don't have the adequate hardware it's only compile tested.
>>
>> Stefan
>>
>> Stefan Wahren (2):
>> mmc: sdhci: add define for suspend/resume capability
>> mmc: sdhci-iproc: Use defines instead of magic numbers
>>
>> drivers/mmc/host/sdhci-iproc.c | 13 +++++++++++--
>> drivers/mmc/host/sdhci.h | 1 +
>> 2 files changed, 12 insertions(+), 2 deletions(-)
>>
> Patch series looks fine.
>
> Acked-by: Scott Branden <scott.branden@broadcom.com>
Acked-by: Adrian Hunter <adrian.hunter@intel.com>
^ permalink raw reply [flat|nested] 12+ messages in thread
* [PATCH 0/2] mmc: sdhci-iproc: Use defines instead of magic numbers
@ 2016-07-05 6:06 ` Adrian Hunter
0 siblings, 0 replies; 12+ messages in thread
From: Adrian Hunter @ 2016-07-05 6:06 UTC (permalink / raw)
To: linux-arm-kernel
On 04/07/16 20:02, Scott Branden wrote:
> Hi Stefan,
>
> On 16-07-02 12:23 PM, Stefan Wahren wrote:
>> Hi,
>>
>> this small patch series should make the sdhci-iproc platform data easier
>> to read. Since i don't have the adequate hardware it's only compile tested.
>>
>> Stefan
>>
>> Stefan Wahren (2):
>> mmc: sdhci: add define for suspend/resume capability
>> mmc: sdhci-iproc: Use defines instead of magic numbers
>>
>> drivers/mmc/host/sdhci-iproc.c | 13 +++++++++++--
>> drivers/mmc/host/sdhci.h | 1 +
>> 2 files changed, 12 insertions(+), 2 deletions(-)
>>
> Patch series looks fine.
>
> Acked-by: Scott Branden <scott.branden@broadcom.com>
Acked-by: Adrian Hunter <adrian.hunter@intel.com>
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH 0/2] mmc: sdhci-iproc: Use defines instead of magic numbers
2016-07-02 19:23 ` Stefan Wahren
@ 2016-07-06 16:21 ` Ulf Hansson
-1 siblings, 0 replies; 12+ messages in thread
From: Ulf Hansson @ 2016-07-06 16:21 UTC (permalink / raw)
To: Stefan Wahren
Cc: Ray Jui, Scott Branden, Jon Mason, Adrian Hunter,
linux-arm-kernel@lists.infradead.org, linux-mmc,
bcm-kernel-feedback-list
On 2 July 2016 at 21:23, Stefan Wahren <stefan.wahren@i2se.com> wrote:
> Hi,
>
> this small patch series should make the sdhci-iproc platform data easier
> to read. Since i don't have the adequate hardware it's only compile tested.
>
> Stefan
>
> Stefan Wahren (2):
> mmc: sdhci: add define for suspend/resume capability
> mmc: sdhci-iproc: Use defines instead of magic numbers
>
> drivers/mmc/host/sdhci-iproc.c | 13 +++++++++++--
> drivers/mmc/host/sdhci.h | 1 +
> 2 files changed, 12 insertions(+), 2 deletions(-)
>
> --
> 1.7.9.5
>
Thanks, applied for next!
Kind regards
Uffe
^ permalink raw reply [flat|nested] 12+ messages in thread
* [PATCH 0/2] mmc: sdhci-iproc: Use defines instead of magic numbers
@ 2016-07-06 16:21 ` Ulf Hansson
0 siblings, 0 replies; 12+ messages in thread
From: Ulf Hansson @ 2016-07-06 16:21 UTC (permalink / raw)
To: linux-arm-kernel
On 2 July 2016 at 21:23, Stefan Wahren <stefan.wahren@i2se.com> wrote:
> Hi,
>
> this small patch series should make the sdhci-iproc platform data easier
> to read. Since i don't have the adequate hardware it's only compile tested.
>
> Stefan
>
> Stefan Wahren (2):
> mmc: sdhci: add define for suspend/resume capability
> mmc: sdhci-iproc: Use defines instead of magic numbers
>
> drivers/mmc/host/sdhci-iproc.c | 13 +++++++++++--
> drivers/mmc/host/sdhci.h | 1 +
> 2 files changed, 12 insertions(+), 2 deletions(-)
>
> --
> 1.7.9.5
>
Thanks, applied for next!
Kind regards
Uffe
^ permalink raw reply [flat|nested] 12+ messages in thread