From: Shannon Zhao <zhaoshenglong@huawei.com>
To: Igor Mammedov <imammedo@redhat.com>, qemu-devel@nongnu.org
Cc: marcel@redhat.com, peter.maydell@linaro.org,
david@gibson.dropbear.id.au, mst@redhat.com
Subject: Re: [Qemu-devel] [PATCH v4 3/5] numa: reduce code duplication by adding helper numa_get_node_for_cpu()
Date: Tue, 5 Jul 2016 09:09:19 +0800 [thread overview]
Message-ID: <577B08BF.8070105@huawei.com> (raw)
In-Reply-To: <1467647479-40202-4-git-send-email-imammedo@redhat.com>
On 2016/7/4 23:51, Igor Mammedov wrote:
> Replace repeated pattern
>
> for (i = 0; i < nb_numa_nodes; i++) {
> if (test_bit(idx, numa_info[i].node_cpu)) {
> ...
> break;
>
> with a helper function to lookup numa node index for cpu.
>
> Suggested-by: Michael S. Tsirkin <mst@redhat.com>
> Signed-off-by: Igor Mammedov <imammedo@redhat.com>
> Reviewed-by: David Gibson <david@gibson.dropbear.id.au>
Reviewed-by: Shannon Zhao <shannon.zhao@linaro.org>
--
Shannon
next prev parent reply other threads:[~2016-07-05 1:09 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-04 15:51 [Qemu-devel] [PATCH v4 0/5] fix numa node mapping for hotplugged CPUs Igor Mammedov
2016-07-04 15:51 ` [Qemu-devel] [PATCH v4 1/5] tests: acpi: add CPU hotplug testcase Igor Mammedov
2016-07-04 15:51 ` [Qemu-devel] [PATCH v4 2/5] tests: DO NOT APPLY: add APIC.cphp and DSDT.cphp blobs Igor Mammedov
2016-07-04 15:51 ` [Qemu-devel] [PATCH v4 3/5] numa: reduce code duplication by adding helper numa_get_node_for_cpu() Igor Mammedov
2016-07-05 1:09 ` Shannon Zhao [this message]
2016-07-04 15:51 ` [Qemu-devel] [PATCH v4 4/5] acpi: provide _PXM method for CPU devices if QEMU is started numa enabled Igor Mammedov
2016-07-04 15:51 ` [Qemu-devel] [PATCH v4 5/5] tests: acpi: extend cphp testcase with numa check Igor Mammedov
2016-07-18 7:51 ` [Qemu-devel] [PATCH v4 0/5] fix numa node mapping for hotplugged CPUs Igor Mammedov
2016-07-27 9:28 ` Igor Mammedov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=577B08BF.8070105@huawei.com \
--to=zhaoshenglong@huawei.com \
--cc=david@gibson.dropbear.id.au \
--cc=imammedo@redhat.com \
--cc=marcel@redhat.com \
--cc=mst@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.