Re: [Qemu-devel] [Qemu-block] [PATCH v8 10/16] block: Simplify drive-mirror

[Eric Blake <eblake@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 1334 bytes --]

On 07/05/2016 02:27 PM, John Snow wrote:
> 
> 
> On 07/02/2016 10:58 PM, Eric Blake wrote:
>> Now that we can support boxed commands, use it to greatly
>> reduce the number of parameters (and likelihood of getting
>> out of sync) when adjusting drive-mirror parameters.
>>
>> Signed-off-by: Eric Blake <eblake@redhat.com>
>>

>> @@ -1154,12 +1169,9 @@
>>  #         written. Both will result in identical contents.
>>  #         Default is true. (Since 2.4)
>>  #
>> -# Returns: nothing on success
>> -#          If @device is not a valid block device, DeviceNotFound
>> -#
>>  # Since 1.3
> 
> Should this still be "Since 1.3" for DriveMirror as a structure, since
> it's being newly created?
> 
> (What color of shed would you like? Any color is fine for me.)

Introspection output is unchanged, and doesn't include 'since:'
information (we intentionally made introspection agnostic to
backwards-compatible changes, such as creating a named type in place of
an inline one).  So unless Markus has any particular advice on a better
number to use, I think leaving the version number associated with the
first time the associated command was around is as close to the truth as
is necessary.


-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]