* [PATCH] extcon: Move extcon_get_edev_by_phandle() errors to dbg level @ 2016-07-05 18:57 ` Stephen Boyd 2016-07-06 0:06 ` Chanwoo Choi 0 siblings, 1 reply; 2+ messages in thread From: Stephen Boyd @ 2016-07-05 18:57 UTC (permalink / raw) To: Chanwoo Choi; +Cc: linux-kernel Sometimes drivers may call this API and expect it to fail because the extcon they're looking for is optional. Let's move these prints to debug level so it doesn't look like there's a problem when there isn't one. Signed-off-by: Stephen Boyd <stephen.boyd@linaro.org> --- drivers/extcon/extcon.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/extcon/extcon.c b/drivers/extcon/extcon.c index 161acb826334..984f50d5297c 100644 --- a/drivers/extcon/extcon.c +++ b/drivers/extcon/extcon.c @@ -1096,13 +1096,13 @@ struct extcon_dev *extcon_get_edev_by_phandle(struct device *dev, int index) return ERR_PTR(-EINVAL); if (!dev->of_node) { - dev_err(dev, "device does not have a device node entry\n"); + dev_dbg(dev, "device does not have a device node entry\n"); return ERR_PTR(-EINVAL); } node = of_parse_phandle(dev->of_node, "extcon", index); if (!node) { - dev_err(dev, "failed to get phandle in %s node\n", + dev_dbg(dev, "failed to get phandle in %s node\n", dev->of_node->full_name); return ERR_PTR(-ENODEV); } -- 2.9.0.rc2.8.ga28705d ^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] extcon: Move extcon_get_edev_by_phandle() errors to dbg level 2016-07-05 18:57 ` [PATCH] extcon: Move extcon_get_edev_by_phandle() errors to dbg level Stephen Boyd @ 2016-07-06 0:06 ` Chanwoo Choi 0 siblings, 0 replies; 2+ messages in thread From: Chanwoo Choi @ 2016-07-06 0:06 UTC (permalink / raw) To: Stephen Boyd; +Cc: linux-kernel Hi Stephen, On 2016년 07월 06일 03:57, Stephen Boyd wrote: > Sometimes drivers may call this API and expect it to fail because > the extcon they're looking for is optional. Let's move these > prints to debug level so it doesn't look like there's a problem > when there isn't one. > > Signed-off-by: Stephen Boyd <stephen.boyd@linaro.org> > --- > drivers/extcon/extcon.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/extcon/extcon.c b/drivers/extcon/extcon.c > index 161acb826334..984f50d5297c 100644 > --- a/drivers/extcon/extcon.c > +++ b/drivers/extcon/extcon.c > @@ -1096,13 +1096,13 @@ struct extcon_dev *extcon_get_edev_by_phandle(struct device *dev, int index) > return ERR_PTR(-EINVAL); > > if (!dev->of_node) { > - dev_err(dev, "device does not have a device node entry\n"); > + dev_dbg(dev, "device does not have a device node entry\n"); > return ERR_PTR(-EINVAL); > } > > node = of_parse_phandle(dev->of_node, "extcon", index); > if (!node) { > - dev_err(dev, "failed to get phandle in %s node\n", > + dev_dbg(dev, "failed to get phandle in %s node\n", > dev->of_node->full_name); > return ERR_PTR(-ENODEV); > } > Applied it. Thanks, Chanwoo Choi ^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-07-06 0:06 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <CGME20160705185711epcas1p3cf1e93b383eda62cd71da5f892649cd7@epcas1p3.samsung.com>
2016-07-05 18:57 ` [PATCH] extcon: Move extcon_get_edev_by_phandle() errors to dbg level Stephen Boyd
2016-07-06 0:06 ` Chanwoo Choi
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.