Re: [PATCH 0/4] Add delete layer and fix layer rev saving

[Michael Wood <michael.g.wood@intel.com>]

On 06/07/16 14:28, Barros Pena, Belen wrote:
>
> On 06/07/2016 14:22, "toaster-bounces@yoctoproject.org on behalf of Barros
> Pena, Belen" <toaster-bounces@yoctoproject.org on behalf of
> belen.barros.pena@intel.com> wrote:
>
>>
>> On 04/07/2016 21:56, "toaster-bounces@yoctoproject.org on behalf of
>> Michael Wood" <toaster-bounces@yoctoproject.org on behalf of
>> michael.g.wood@intel.com> wrote:
>>
>>> Michael Wood (4):
>>>   toaster: layerdetails api Fix saving of git revision of a layer
>>>   toaster: api Add util function for returning the error response
>>>   toaster: add Layer delete front end feature to layerdetails
>>>   toaster: tests Add selenium test for layerdetails page
>> The fix to the revision changes for imported layers (8952) works like a
>> charm: I can edit all the layer details now. I can also delete an imported
>> layer \0/, but when I get redirected to the project configuration page
>> after clicking the 'delete' button no notification appears, so I am left
>> wondering if the layer was deleted or not.
> Ignore me: browser cache playing tricks. But the question mark really is
> missing ;)

OK, I fixed the missing question mark in the branch, so if who ever is 
reviewing pulls from the branch then it should be there.

>
>> I also spotted that the question in the delete confirmation dialog is
>> missing the question mark.
>>
>> Thanks!!
>>
>> Belén
>>
>> PS: I hate delete confirmation dialogs ... For the record ;)
>>
>>> .../tests/browser/test_layerdetails_page.py        | 190
>>> +++++++++++++++++++++
>>> bitbake/lib/toaster/toastergui/api.py              | 121 +++++++++++--
>>> .../toaster/toastergui/static/js/layerdetails.js   |  20 +++
>>> .../toaster/toastergui/static/js/projectpage.js    |  18 ++
>>> .../toaster/toastergui/templates/layerdetails.html |  18 +-
>>> bitbake/lib/toaster/toastergui/urls.py             |   5 +-
>>> bitbake/lib/toaster/toastergui/views.py            |  43 -----
>>> 7 files changed, 360 insertions(+), 55 deletions(-)
>>> create mode 100644
>>> bitbake/lib/toaster/tests/browser/test_layerdetails_page.py
>>>
>>> -- 
>>> 2.7.4
>>>
>>> -- 
>>> _______________________________________________
>>> toaster mailing list
>>> toaster@yoctoproject.org
>>> https://lists.yoctoproject.org/listinfo/toaster
>> -- 
>> _______________________________________________
>> toaster mailing list
>> toaster@yoctoproject.org
>> https://lists.yoctoproject.org/listinfo/toaster