From: David Vrabel <david.vrabel@citrix.com>
To: Jan Beulich <JBeulich@suse.com>,
plagnioj@jcrosoft.com, tomi.valkeinen@ti.com
Cc: Juergen Gross <JGross@suse.com>,
xen-devel@lists.xenproject.org,
Boris Ostrovsky <boris.ostrovsky@oracle.com>,
David Vrabel <david.vrabel@citrix.com>,
linux-fbdev <linux-fbdev@vger.kernel.org>
Subject: Re: [Xen-devel] [PATCH] xen-fbfront: correct return value checks on xenbus_scanf()
Date: Thu, 07 Jul 2016 09:46:07 +0000 [thread overview]
Message-ID: <577E24DF.5000203@citrix.com> (raw)
In-Reply-To: <577E258502000078000FBE6F@prv-mh.provo.novell.com>
On 07/07/16 08:48, Jan Beulich wrote:
>
> Signed-off-by: Jan Beulich <jbeulich@suse.com>
> ---
> drivers/video/fbdev/xen-fbfront.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> --- 4.7-rc6-xenbus_scanf.orig/drivers/video/fbdev/xen-fbfront.c
> +++ 4.7-rc6-xenbus_scanf/drivers/video/fbdev/xen-fbfront.c
> @@ -658,13 +658,13 @@ InitWait:
> goto InitWait; /* no InitWait seen yet, fudge it */
>
> if (xenbus_scanf(XBT_NIL, info->xbdev->otherend,
> - "request-update", "%d", &val) < 0)
> + "request-update", "%d", &val) <= 0)
> val = 0;
> if (val)
> info->update_wanted = 1;
>
> if (xenbus_scanf(XBT_NIL, dev->otherend,
> - "feature-resize", "%d", &val) < 0)
> + "feature-resize", "%d", &val) <= 0)
xenbus_scanf() has:
/* Single read and scanf: returns -errno or num scanned. */
...
if (ret = 0)
return -ERANGE;
...
So none of these patches are necessary.
David
WARNING: multiple messages have this Message-ID (diff)
From: David Vrabel <david.vrabel@citrix.com>
To: Jan Beulich <JBeulich@suse.com>,
plagnioj@jcrosoft.com, tomi.valkeinen@ti.com
Cc: Juergen Gross <JGross@suse.com>,
xen-devel@lists.xenproject.org,
Boris Ostrovsky <boris.ostrovsky@oracle.com>,
David Vrabel <david.vrabel@citrix.com>,
linux-fbdev <linux-fbdev@vger.kernel.org>
Subject: Re: [PATCH] xen-fbfront: correct return value checks on xenbus_scanf()
Date: Thu, 7 Jul 2016 10:46:07 +0100 [thread overview]
Message-ID: <577E24DF.5000203@citrix.com> (raw)
In-Reply-To: <577E258502000078000FBE6F@prv-mh.provo.novell.com>
On 07/07/16 08:48, Jan Beulich wrote:
>
> Signed-off-by: Jan Beulich <jbeulich@suse.com>
> ---
> drivers/video/fbdev/xen-fbfront.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> --- 4.7-rc6-xenbus_scanf.orig/drivers/video/fbdev/xen-fbfront.c
> +++ 4.7-rc6-xenbus_scanf/drivers/video/fbdev/xen-fbfront.c
> @@ -658,13 +658,13 @@ InitWait:
> goto InitWait; /* no InitWait seen yet, fudge it */
>
> if (xenbus_scanf(XBT_NIL, info->xbdev->otherend,
> - "request-update", "%d", &val) < 0)
> + "request-update", "%d", &val) <= 0)
> val = 0;
> if (val)
> info->update_wanted = 1;
>
> if (xenbus_scanf(XBT_NIL, dev->otherend,
> - "feature-resize", "%d", &val) < 0)
> + "feature-resize", "%d", &val) <= 0)
xenbus_scanf() has:
/* Single read and scanf: returns -errno or num scanned. */
...
if (ret == 0)
return -ERANGE;
...
So none of these patches are necessary.
David
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
next prev parent reply other threads:[~2016-07-07 9:46 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-07 7:48 [PATCH] xen-fbfront: correct return value checks on xenbus_scanf() Jan Beulich
2016-07-07 7:48 ` Jan Beulich
2016-07-07 9:46 ` David Vrabel [this message]
2016-07-07 9:46 ` David Vrabel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=577E24DF.5000203@citrix.com \
--to=david.vrabel@citrix.com \
--cc=JBeulich@suse.com \
--cc=JGross@suse.com \
--cc=boris.ostrovsky@oracle.com \
--cc=linux-fbdev@vger.kernel.org \
--cc=plagnioj@jcrosoft.com \
--cc=tomi.valkeinen@ti.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.